| Message ID | 1426749398-13682-2-git-send-email-alex.hung@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Mar 19, 2015 at 03:16:38PM +0800, Alex Hung wrote: > The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due > to insufficient documentation for the driver implementation, blacklist > it as a workaround. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > drivers/acpi/blacklist.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > index 1a00d17..6f4f63e 100644 > --- a/drivers/acpi/blacklist.c > +++ b/drivers/acpi/blacklist.c > @@ -363,7 +363,6 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3546"), > }, > }, > - > /* > * The following Lenovo models have a broken workaround in the > * acpi_video backlight implementation to meet the Windows 8 > @@ -442,6 +441,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5537"), > }, > }, > + /* > + * The brightness hotkeys do not work on those machines when > + * returning true for _OSI("Windows 2012") > + */ > + { > + .callback = dmi_disable_osi_win8, > + .ident = "HP Pavilion dv6", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), > + }, > + }, > > /* > * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. > -- > 1.7.9.5 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Looks good.
On Thu, Mar 19, 2015 at 03:16:38PM +0800, Alex Hung wrote: > The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due > to insufficient documentation for the driver implementation, blacklist > it as a workaround. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> Ack on the patch. The commit message should have the sauce annotation and buglink added when it is applied.
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 1a00d17..6f4f63e 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c @@ -363,7 +363,6 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3546"), }, }, - /* * The following Lenovo models have a broken workaround in the * acpi_video backlight implementation to meet the Windows 8 @@ -442,6 +441,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5537"), }, }, + /* + * The brightness hotkeys do not work on those machines when + * returning true for _OSI("Windows 2012") + */ + { + .callback = dmi_disable_osi_win8, + .ident = "HP Pavilion dv6", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"), + }, + }, /* * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due to insufficient documentation for the driver implementation, blacklist it as a workaround. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- drivers/acpi/blacklist.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)