| Message ID | 1426017584-6096-3-git-send-email-ps.report@gmx.net |
|---|---|
| State | Accepted |
| Headers | show |
Dear Peter Seiderer, On Tue, 10 Mar 2015 20:59:39 +0100, Peter Seiderer wrote: > +# unsupported platform, overwrite manually > +ifeq ($(BR2_bfin),y) > +POSTGRESQL_CONF_OPTS += --with-template=linux > +endif Do we really need to make this conditional? I believe --with-template=linux is fine in all cases since Buildroot only targets Linux. So what about having --with-template=linux unconditionally in POSTGRESQL_CONF_OPTS instead? If that's OK for you, I can adjust this when applying. Thanks, Thomas
Dear Peter Seiderer, On Tue, 10 Mar 2015 20:59:39 +0100, Peter Seiderer wrote: > - overwrite platform support with linux template > - disable spinlock support > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> Applied, after making --with-template=linux used unconditionally, as we discussed. Thanks! Thomas
Dear Peter Seiderer, On Tue, 10 Mar 2015 20:59:39 +0100, Peter Seiderer wrote: > - overwrite platform support with linux template > - disable spinlock support > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> postgresql uses fork(), which is not available on Blackfin: http://autobuild.buildroot.org/results/c9c/c9c93156fe64e89f35627aa592c47d8c5181ed7d/build-end.log. So what was the point of enabling postgresql on Blackfin ? Thomas
diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk index 7ebf795..76b19d5 100644 --- a/package/postgresql/postgresql.mk +++ b/package/postgresql/postgresql.mk @@ -13,6 +13,11 @@ POSTGRESQL_LICENSE_FILES = COPYRIGHT POSTGRESQL_INSTALL_STAGING = YES POSTGRESQL_CONFIG_SCRIPTS = pg_config +# unsupported platform, overwrite manually +ifeq ($(BR2_bfin),y) +POSTGRESQL_CONF_OPTS += --with-template=linux +endif + ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y) # overwrite IPV6 detection ifeq ($(BR2_INET_IPV6),y) @@ -31,7 +36,7 @@ ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y) POSTGRESQL_CONF_OPTS += --disable-thread-safety endif -ifeq ($(BR2_microblazeel)$(BR2_microblazebe)$(BR2_nios2),y) +ifeq ($(BR2_bfin)$(BR2_microblazebe)$(BR2_microblazeel)$(BR2_nios2),y) POSTGRESQL_CONF_OPTS += --disable-spinlocks endif
- overwrite platform support with linux template - disable spinlock support Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Changes v1 --> v3: - no changes --- package/postgresql/postgresql.mk | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)