diff mbox

parted not building static

Message ID F9C551623D2CBB4C9488801D14F864C68C8AD59C@ex-mb3.corp.adtran.com
State Rejected
Headers show

Commit Message

ANDY KENNEDY Sept. 8, 2014, 3:46 p.m. UTC
Parted would not build when PREFER_STATIC_LIB was selected.  The configure
error reports "Add --disable-dynamic-loading" as the fix.  Added this fix.

Signed-off-by:  Andy Kennedy <andy.kennedy@adtran.com>
---

Comments

Thomas Petazzoni Sept. 8, 2014, 8:06 p.m. UTC | #1
Dear ANDY KENNEDY,

On Mon, 8 Sep 2014 15:46:55 +0000, ANDY KENNEDY wrote:

> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +PARTED_CONF_OPT += --disable-dynamic-loading
> +endif

Your Buildroot tree is probably not up-to-date because this has already
been fixed by Gustavo in commit
ea7061f40e04f6a475705a579529978de1b9cc91 (June 2014). This commit is
part of the 2014.08 release.

Thanks for your patch!

Thomas
ANDY KENNEDY Sept. 8, 2014, 8:48 p.m. UTC | #2
> Your Buildroot tree is probably not up-to-date because this has already

Not even that.  I'm using the released version of 2014.02 to diff against.

I didn't do my due diligence on this one.  I figured that was probably not
something that anyone else would have seen.

I _SHOULD_ have done a sync with today and checked against that.

Sorry about that.  Shouldn't have wasted your time.

Andy
diff mbox

Patch

diff -Naur a/package/parted/parted.mk b/package/parted/parted.mk
--- a/package/parted/parted.mk  2014-02-27 14:51:23.000000000 -0600
+++ b/package/parted/parted.mk  2014-09-08 10:37:39.288121610 -0500
@@ -19,6 +19,10 @@ 
 PARTED_CONF_OPT += --without-readline
 endif

+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+PARTED_CONF_OPT += --disable-dynamic-loading
+endif
+
 ifeq ($(BR2_PACKAGE_LVM2),y)
 PARTED_DEPENDENCIES += lvm2
 PARTED_CONF_OPT += --enable-device-mapper