Message ID | 20140521192928.GA3672@ned |
---|---|
State | Accepted |
Commit | 6d49c243cf5ba8c4e48eebc6afdf75bbdd383780 |
Headers | show |
On 21-05-14 21:29, Eric Le Bihan wrote: > Please find attached a patch that installs two new services for using psplash > with systemd. These are inspired by the ones from Plymouth > (http://cgit.freedesktop.org/plymouth/tree/systemd-units/): Hello Eric, Thanks for this patch it helps me indeed and works. However I am looking into starting it even earlier in the boot process so I'll let something know if I find it. Thanks, Best regards, Tom, Email Confidentiality: e-BO Enterprises<http://www.ebo-enterprises.com/> Company Registration Number BE 0470174242. This email message and any attachments are for the sole use of the intended recipient(s) and may contain information that is proprietary to e-BO Enterprises<http://www.ebo-enterprises.com/>. If you have received this message in error, please notify the sender by reply, and delete all copies of this message and any attachments. If you are the intended recipient you may use the information contained in this message and any files attached to this message only as authorized by e-BO Enterprises<http://www.ebo-enterprises.com/>. Any unauthorized use, dissemination or disclosure of this message or its attachments is strictly prohibited. The contents of this e-mail are not to be considered binding upon e-BO Enterprises<http://www.ebo-enterprises.com/>.
Dear Eric Le Bihan, On Wed, 21 May 2014 21:29:28 +0200, Eric Le Bihan wrote: > Hi! > > On Wed, May 21, 2014 at 10:36:15AM +0200, Tom Deblauwe wrote: > > Hello, > > > > I am using psplash in my initramfs and it shows up a graphical > > bootscreen, but then the regular bootprocess starts and there I would > > like to continue showing the splash screen. I am using the 6d3336a > > commit of master buildroot. So I would like to use systemd. What is the > > best solution for this? > > Please find attached a patch that installs two new services for using psplash > with systemd. These are inspired by the ones from Plymouth > (http://cgit.freedesktop.org/plymouth/tree/systemd-units/): Can you submit this patch properly, i.e with git send-email, so that it can be applied? I'll mark it as "Changes requested" in patchwork in the mean time, awaiting for your new posting. Thanks a lot, having psplash integration looks really useful! Thomas
Dear Tom Deblauwe, On Mon, 09 Jun 2014 17:37:46 +0200, Tom Deblauwe wrote: > I also have added some basic support to choose the .png image you want > as a bootscreen. I had to install in ubuntu "libgdk-pixbuf2.0-dev" to > have the "gdk-pixbuf-csource" utility which the generate header script > uses. Probably there is a better buildroot-specific way but I provide > the patch as a start. Thanks for your patch. To get the gdk-pixbuf-csource tool in Buildroot, you simply need to make your package depend on host-gdk-pixbuf. It would be good to take the systemd psplash patch and your patch, create proper commit logs, and submit them using git send-email. See http://buildroot.org/downloads/manual/manual.html#submitting-patches for details. Your contribution would be much appreciated! Thanks! Thomas
Hi! On Mon, Jun 09, 2014 at 02:27:34PM +0200, Thomas Petazzoni wrote: > Dear Eric Le Bihan, > > On Wed, 21 May 2014 21:29:28 +0200, Eric Le Bihan wrote: > > Hi! > > > > On Wed, May 21, 2014 at 10:36:15AM +0200, Tom Deblauwe wrote: > > > Hello, > > > > > > I am using psplash in my initramfs and it shows up a graphical > > > bootscreen, but then the regular bootprocess starts and there I would > > > like to continue showing the splash screen. I am using the 6d3336a > > > commit of master buildroot. So I would like to use systemd. What is the > > > best solution for this? > > > > Please find attached a patch that installs two new services for using psplash > > with systemd. These are inspired by the ones from Plymouth > > (http://cgit.freedesktop.org/plymouth/tree/systemd-units/): > > Can you submit this patch properly, i.e with git send-email, so that it > can be applied? I posted a proper patch. As for adding progress report from systemd to psplash, this would require a patch to src/core/manager.c in systemd to write to psplash socket. BTW, maybe we should provide a patch to set the default image with the famous Buildroot hard hat, to replace the "POKY" theme... Best regards, ELB
Dear Eric Le Bihan, On Wed, 11 Jun 2014 23:18:21 +0200, Eric Le Bihan wrote: > > Can you submit this patch properly, i.e with git send-email, so that it > > can be applied? > I posted a proper patch. Ok, found at http://patchwork.ozlabs.org/patch/358888/. > As for adding progress report from systemd to > psplash, this would require a patch to src/core/manager.c in systemd to write > to psplash socket. Ok. > BTW, maybe we should provide a patch to set the default image with the famous > Buildroot hard hat, to replace the "POKY" theme... Indeed, that would be good to have. Thanks! Thomas
diff --git a/package/psplash/psplash-quit.service b/package/psplash/psplash-quit.service new file mode 100644 index 0000000..14bd499 --- /dev/null +++ b/package/psplash/psplash-quit.service @@ -0,0 +1,11 @@ +[Unit] +Description=Terminate Psplash Boot Screen +After=psplash-start.service + +[Service] +Type=oneshot +ExecStart=/usr/bin/psplash-write QUIT +TimeoutSec=20 + +[Install] +WantedBy=multi-user.target diff --git a/package/psplash/psplash-start.service b/package/psplash/psplash-start.service new file mode 100644 index 0000000..2de3cfc --- /dev/null +++ b/package/psplash/psplash-start.service @@ -0,0 +1,11 @@ +[Unit] +Description=Starts Psplash Boot screen +Wants=systemd-vconsole-setup.service +After=systemd-vconsole-setup.service systemd-udev-trigger.service systemd-udevd.service +DefaultDependencies=no + +[Service] +ExecStart=/usr/bin/psplash -n + +[Install] +WantedBy=sysinit.target diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk index 83b6f79..b756266 100644 --- a/package/psplash/psplash.mk +++ b/package/psplash/psplash.mk @@ -9,4 +9,18 @@ PSPLASH_SITE = git://git.yoctoproject.org/psplash PSPLASH_LICENSE = GPLv2+ PSPLASH_AUTORECONF = YES +define PSPLASH_INSTALL_INIT_SYSTEMD + $(INSTALL) -D -m 644 package/psplash/psplash-start.service \ + $(TARGET_DIR)/etc/systemd/system/psplash-start.service + $(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants + ln -sf ../psplash-start.service \ + $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants/ + + $(INSTALL) -D -m 644 package/psplash/psplash-quit.service \ + $(TARGET_DIR)/etc/systemd/system/psplash-quit.service + $(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants + ln -sf ../psplash-quit.service \ + $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/ +endef + $(eval $(autotools-package))