diff mbox

DT: video: atmel_lcdc: Add example of fixed framebuffer memory

Message ID 1396333730-10592-1-git-send-email-alexander.stein@systec-electronic.com
State Superseded, archived
Headers show

Commit Message

Alexander Stein April 1, 2014, 6:28 a.m. UTC
This drivers allows a fixed framebuffer memory to be set by an additional
IORESOURCE_MEM resource. Thus add an example to the DT documentation.

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
Actually I stumbled myself over this wondering how can I use this specific
feature. In the end I found it myself my coincidence. So it's best to add
this as an example for other people maybe not that experienced on
device-tree.

 Documentation/devicetree/bindings/video/atmel,lcdc.txt | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Alexander Stein April 15, 2014, 2:57 p.m. UTC | #1
Any feedback in this?

Regards,
Alexander

On Tuesday 01 April 2014 08:28:50, Alexander Stein wrote:
> This drivers allows a fixed framebuffer memory to be set by an additional
> IORESOURCE_MEM resource. Thus add an example to the DT documentation.
> 
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> Actually I stumbled myself over this wondering how can I use this specific
> feature. In the end I found it myself my coincidence. So it's best to add
> this as an example for other people maybe not that experienced on
> device-tree.
> 
>  Documentation/devicetree/bindings/video/atmel,lcdc.txt | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/video/atmel,lcdc.txt b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
> index 1ec175e..92492b7 100644
> --- a/Documentation/devicetree/bindings/video/atmel,lcdc.txt
> +++ b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
> @@ -10,7 +10,9 @@ Required properties:
>  	"atmel,at91sam9g45es-lcdc" ,
>  	"atmel,at91sam9rl-lcdc" ,
>  	"atmel,at32ap-lcdc"
> -- reg : Should contain 1 register ranges(address and length)
> +- reg : Should contain 1 register ranges(address and length).
> +	Can contain an additional register range(address and length)
> +	for fixed framebuffer memory.Usefull for dedicated memories.
>  - interrupts : framebuffer controller interrupt
>  - display: a phandle pointing to the display node
>  
> @@ -35,6 +37,14 @@ Example:
>  
>  	};
>  
> +Example for fixed framebuffer memory:
> +
> +	fb0: fb@0x00500000 {
> +		compatible = "atmel,at91sam9263-lcdc";
> +		reg = <0x00700000 0x1000 0x70000000 0x200000>;
> +		[...]
> +	};
> +
>  Atmel LCDC Display
>  -----------------------------------------------------
>  Required properties (as per of_videomode_helper):
>
Nicolas Ferre April 15, 2014, 3:19 p.m. UTC | #2
On 15/04/2014 16:57, Alexander Stein :
> Any feedback in this?

Actually I didn't notice it previously: thanks for the heads up.

> Regards,
> Alexander
> 
> On Tuesday 01 April 2014 08:28:50, Alexander Stein wrote:
>> This drivers allows a fixed framebuffer memory to be set by an additional
>> IORESOURCE_MEM resource. Thus add an example to the DT documentation.
>>
>> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>

Indeed, it can be useful:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>


>> ---
>> Actually I stumbled myself over this wondering how can I use this specific
>> feature. In the end I found it myself my coincidence. So it's best to add
>> this as an example for other people maybe not that experienced on
>> device-tree.
>>
>>  Documentation/devicetree/bindings/video/atmel,lcdc.txt | 12 +++++++++++-
>>  1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/video/atmel,lcdc.txt b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
>> index 1ec175e..92492b7 100644
>> --- a/Documentation/devicetree/bindings/video/atmel,lcdc.txt
>> +++ b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
>> @@ -10,7 +10,9 @@ Required properties:
>>  	"atmel,at91sam9g45es-lcdc" ,
>>  	"atmel,at91sam9rl-lcdc" ,
>>  	"atmel,at32ap-lcdc"
>> -- reg : Should contain 1 register ranges(address and length)
>> +- reg : Should contain 1 register ranges(address and length).
>> +	Can contain an additional register range(address and length)
>> +	for fixed framebuffer memory.Usefull for dedicated memories.
>>  - interrupts : framebuffer controller interrupt
>>  - display: a phandle pointing to the display node
>>  
>> @@ -35,6 +37,14 @@ Example:
>>  
>>  	};
>>  
>> +Example for fixed framebuffer memory:
>> +
>> +	fb0: fb@0x00500000 {
>> +		compatible = "atmel,at91sam9263-lcdc";
>> +		reg = <0x00700000 0x1000 0x70000000 0x200000>;
>> +		[...]
>> +	};
>> +
>>  Atmel LCDC Display
>>  -----------------------------------------------------
>>  Required properties (as per of_videomode_helper):
>>
>
Alexander Stein Oct. 29, 2014, 11:38 a.m. UTC | #3
Will someone pick this up? It is laying around for 6 months now.

Thanks and best regards,
Alexander

On Tuesday 15 April 2014 17:19:16, Nicolas Ferre wrote:
> On 15/04/2014 16:57, Alexander Stein :
> > Any feedback in this?
> 
> Actually I didn't notice it previously: thanks for the heads up.
> 
> > Regards,
> > Alexander
> > 
> > On Tuesday 01 April 2014 08:28:50, Alexander Stein wrote:
> >> This drivers allows a fixed framebuffer memory to be set by an additional
> >> IORESOURCE_MEM resource. Thus add an example to the DT documentation.
> >>
> >> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> 
> Indeed, it can be useful:
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> 
> >> ---
> >> Actually I stumbled myself over this wondering how can I use this specific
> >> feature. In the end I found it myself my coincidence. So it's best to add
> >> this as an example for other people maybe not that experienced on
> >> device-tree.
> >>
> >>  Documentation/devicetree/bindings/video/atmel,lcdc.txt | 12 +++++++++++-
> >>  1 file changed, 11 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/video/atmel,lcdc.txt b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
> >> index 1ec175e..92492b7 100644
> >> --- a/Documentation/devicetree/bindings/video/atmel,lcdc.txt
> >> +++ b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
> >> @@ -10,7 +10,9 @@ Required properties:
> >>  	"atmel,at91sam9g45es-lcdc" ,
> >>  	"atmel,at91sam9rl-lcdc" ,
> >>  	"atmel,at32ap-lcdc"
> >> -- reg : Should contain 1 register ranges(address and length)
> >> +- reg : Should contain 1 register ranges(address and length).
> >> +	Can contain an additional register range(address and length)
> >> +	for fixed framebuffer memory.Usefull for dedicated memories.
> >>  - interrupts : framebuffer controller interrupt
> >>  - display: a phandle pointing to the display node
> >>  
> >> @@ -35,6 +37,14 @@ Example:
> >>  
> >>  	};
> >>  
> >> +Example for fixed framebuffer memory:
> >> +
> >> +	fb0: fb@0x00500000 {
> >> +		compatible = "atmel,at91sam9263-lcdc";
> >> +		reg = <0x00700000 0x1000 0x70000000 0x200000>;
> >> +		[...]
> >> +	};
> >> +
> >>  Atmel LCDC Display
> >>  -----------------------------------------------------
> >>  Required properties (as per of_videomode_helper):
> >>
> > 
> 
> 
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/video/atmel,lcdc.txt b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
index 1ec175e..92492b7 100644
--- a/Documentation/devicetree/bindings/video/atmel,lcdc.txt
+++ b/Documentation/devicetree/bindings/video/atmel,lcdc.txt
@@ -10,7 +10,9 @@  Required properties:
 	"atmel,at91sam9g45es-lcdc" ,
 	"atmel,at91sam9rl-lcdc" ,
 	"atmel,at32ap-lcdc"
-- reg : Should contain 1 register ranges(address and length)
+- reg : Should contain 1 register ranges(address and length).
+	Can contain an additional register range(address and length)
+	for fixed framebuffer memory.Usefull for dedicated memories.
 - interrupts : framebuffer controller interrupt
 - display: a phandle pointing to the display node
 
@@ -35,6 +37,14 @@  Example:
 
 	};
 
+Example for fixed framebuffer memory:
+
+	fb0: fb@0x00500000 {
+		compatible = "atmel,at91sam9263-lcdc";
+		reg = <0x00700000 0x1000 0x70000000 0x200000>;
+		[...]
+	};
+
 Atmel LCDC Display
 -----------------------------------------------------
 Required properties (as per of_videomode_helper):