| Message ID | 1391172318-17853-1-git-send-email-richard@nod.at |
|---|---|
| State | Accepted |
| Headers | show |
Am 31.01.2014 13:45, schrieb Richard Weinberger: > On archs like S390 or um this driver cannot build nor work. > Make it depend on HAS_IOMEM to bypass build failures. > > drivers/built-in.o: In function `tpu_probe': > drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource' > > Signed-off-by: Richard Weinberger <richard@nod.at> Ping? Thanks, //richard > --- > drivers/pwm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 22f2f28..0b7a3c9 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -160,6 +160,7 @@ config PWM_PXA > config PWM_RENESAS_TPU > tristate "Renesas TPU PWM support" > depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on HAS_IOMEM > help > This driver exposes the Timer Pulse Unit (TPU) PWM controller found > in Renesas chips through the PWM API. > -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 31, 2014 at 01:45:18PM +0100, Richard Weinberger wrote: > On archs like S390 or um this driver cannot build nor work. > Make it depend on HAS_IOMEM to bypass build failures. > > drivers/built-in.o: In function `tpu_probe': > drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource' > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/pwm/Kconfig | 1 + > 1 file changed, 1 insertion(+) In the long run I think it might be better to add a dummy implementation for devm_ioremap_resource() in order to make it build properly even for architectures where it isn't implemented. For now this looks like the best option. Applied, thanks. Thierry
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 26.02.2014 13:08, schrieb Thierry Reding: > On Fri, Jan 31, 2014 at 01:45:18PM +0100, Richard Weinberger wrote: >> On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. >> >> drivers/built-in.o: In function `tpu_probe': drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource' >> >> Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/pwm/Kconfig | 1 + 1 file changed, 1 insertion(+) > > In the long run I think it might be better to add a dummy implementation for devm_ioremap_resource() in order to make it build properly even for architectures where it isn't > implemented. And what should devm_ioremap_resource() or in general ioremap() do on archs without iomem? BUG()? Returning a random error and hoping that the driver handles it correctly? :) IMHO such a dummy implementation does not make much sense. > For now this looks like the best option. Applied, thanks. Thanks! //richard -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTDfTnAAoJEPmeIjfg4Uaa0hsP/1lgoKuMLbfXEw8Z064st3lk pOQoQQYiyk9nW5Uj/yjFAq9hly+jtL6YdY9+i2q9aQAaIOqTj0I0VbmMy+1nFrdF x7ahD1Z4BAI0PSTj3P8LaYs6Jn+zaok2Zo7B6BlJIvLlNZqqvgQHcCVWHK5srdHu sjd6JwpvBykWSmNUMBG2oAkWCTKLjisXTIL1OsIbcyTgBSS7/17dHfaFqhgZJBTI L3aHRQYOTEdXJyCRZq4SUwNSBXUdP2AmaDJZ4HQ17nuXUTOTnAMgpVUgidgLasmF GAmSDunoi/i7Pu6Vu+562cZhmuzO+uYFo87hDivjn7tTPIJ0OMh4pHeWWaMWVye/ o9GYI1Ew86Lbekd5Xxhf32hNnhz5RxZlNrnjdO1y2GNW5bt7A5ukF4jY0QEuHC+q tgLsS45NIECkqA2hk7nvgRdds1ZaqueuY1dw8mb2jIbuAuR3XXSfjVzdfQiXKxzA tXugXynMSP93mHEeOwzc1pRnFl6j1KgbNOMX9MuYwc5corUShab/Z1d+RVWNat7c iTn6b/GxWpPeMQv3qXvIe77R2UnFv50M2KW4RXs2MRZdXCbIR2FLojGl0fTp1lNo 7mTnB/8SnJBbHz5+1tQv2exFfmalNhM78RighfONJcTnmXfvmA20aNo9Kn3IEU0t m2V40kQySnkcb7+gRXrR =34dU -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 26, 2014 at 03:06:31PM +0100, Richard Weinberger wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 26.02.2014 13:08, schrieb Thierry Reding: > > On Fri, Jan 31, 2014 at 01:45:18PM +0100, Richard Weinberger wrote: > >> On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. > >> > >> drivers/built-in.o: In function `tpu_probe': drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource' > >> > >> Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/pwm/Kconfig | 1 + 1 file changed, 1 insertion(+) > > > > In the long run I think it might be better to add a dummy implementation for devm_ioremap_resource() in order to make it build properly even for architectures where it isn't > > implemented. > > And what should devm_ioremap_resource() or in general ioremap() do on archs without > iomem? > BUG()? Returning a random error and hoping that the driver handles it correctly? :) > > IMHO such a dummy implementation does not make much sense. Well, it could still be useful for drivers that want to support COMPILE_TEST. If we just make it return any error drivers should simply refuse to probe just like if the error was genuine. Thierry
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 22f2f28..0b7a3c9 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -160,6 +160,7 @@ config PWM_PXA config PWM_RENESAS_TPU tristate "Renesas TPU PWM support" depends on ARCH_SHMOBILE || COMPILE_TEST + depends on HAS_IOMEM help This driver exposes the Timer Pulse Unit (TPU) PWM controller found in Renesas chips through the PWM API.
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `tpu_probe': drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource' Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/pwm/Kconfig | 1 + 1 file changed, 1 insertion(+)