[3/4] DT: Add binding for Altera FPGAs in passive-serial mode

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: devicetree@vger.kernel.org
---
 .../devicetree/bindings/firmware/altr,passive-serial.txt    | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/firmware/altr,passive-serial.txt

On Tuesday 12 November 2013 15:31:40 Sascha Hauer wrote:
> [...]
> +Required properties:
> +- compatible: shall be "altr,passive-serial"
> +- reg: SPI chip select
> +- nstat-gpio: Specify GPIO for controlling the nstat pin
> +- confd-gpio: Specify GPIO for controlling the confd pin
> +- nconfig-gpio: Specify GPIO for controlling the nconfig pin

A suggestion was to use the genuine signal names at the FPGA side:

 "nstatus", "config-done" and "nconfig" (all with the trailing "-gpio")

jbe

On Nov 12, 2013, at 8:31 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:

> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: devicetree@vger.kernel.org
> ---
> .../devicetree/bindings/firmware/altr,passive-serial.txt    | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> 
> diff --git a/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> new file mode 100644
> index 0000000..6d40c91
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> @@ -0,0 +1,13 @@
> +Altera FPGAs in passive serial mode
> +-----------------------------------
> +
> +This binding defines the control interface to Altera FPGAs in
> +passive serial mode. This is used to upload the firmware and
> +to start the FPGA.
> +
> +Required properties:
> +- compatible: shall be "altr,passive-serial”

This doesn’t seem quite descriptive enough, easy to confuse with a serial port.

> +- reg: SPI chip select

Is this a SPI device than?

> +- nstat-gpio: Specify GPIO for controlling the nstat pin
> +- confd-gpio: Specify GPIO for controlling the confd pin
> +- nconfig-gpio: Specify GPIO for controlling the nconfig pin
> -- 
> 1.8.4.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tue, Nov 12, 2013 at 10:21:02AM -0600, Kumar Gala wrote:
> 
> On Nov 12, 2013, at 8:31 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: devicetree@vger.kernel.org
> > ---
> > .../devicetree/bindings/firmware/altr,passive-serial.txt    | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > new file mode 100644
> > index 0000000..6d40c91
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > @@ -0,0 +1,13 @@
> > +Altera FPGAs in passive serial mode
> > +-----------------------------------
> > +
> > +This binding defines the control interface to Altera FPGAs in
> > +passive serial mode. This is used to upload the firmware and
> > +to start the FPGA.
> > +
> > +Required properties:
> > +- compatible: shall be "altr,passive-serial”
> 
> This doesn’t seem quite descriptive enough, easy to confuse with a serial port.

How about altr,fpga-passive-serial? Other suggestions?

> 
> > +- reg: SPI chip select
> 
> Is this a SPI device than?

Yes, it is.

Sascha