Message ID | CAFULd4agWAgfk_-ey_mYgHYYMYY2-KsfAjxC0y2A_xSoute_sQ@mail.gmail.com |
---|---|
State | New |
Headers | show |
Hi Uros,
On 21 Jul 2013, at 08:34, Uros Bizjak wrote:
> <p.diff.txt>
Sure, I can test that - do you want me to apply it assuming it reg-tests OK on darwin & linux?
(also I can amend the back ports - since I didn't have time to get to them yesterday)
thanks
Iain
On Sun, Jul 21, 2013 at 9:42 AM, Iain Sandoe <iain@codesourcery.com> wrote: >> <p.diff.txt> > > Sure, I can test that - do you want me to apply it assuming it reg-tests OK on darwin & linux? > (also I can amend the back ports - since I didn't have time to get to them yesterday) Yes, please test it on darwin. The build test on linux went OK. However, the change is not effective on linux, so I have no means to properly test it by myself. If everything is OK, please also use this change in backports. The ChangeLog is attached below. 2013-07-21 Uros Bizjak <ubizjak@gmail.com> * config/i386/i386.md (nonlocal_goto_receiver): Delete insn if it is not needed after split. Thanks, Uros.
Hi Uros, On 21 Jul 2013, at 09:15, Uros Bizjak wrote: > On Sun, Jul 21, 2013 at 9:42 AM, Iain Sandoe <iain@codesourcery.com> wrote: > >>> <p.diff.txt> >> >> Sure, I can test that - do you want me to apply it assuming it reg-tests OK on darwin & linux? >> (also I can amend the back ports - since I didn't have time to get to them yesterday) > > Yes, please test it on darwin. The build test on linux went OK. > However, the change is not effective on linux, so I have no means to > properly test it by myself. > > If everything is OK, please also use this change in backports. Thanks, that checked out fine, so I've applied it to mainline and the combined version to 4.8. I'm travelling this week with limited access to my Darwin boxen, so the 4.7 version might be a bit delayed - similarly, I might take more time than usual to respond to emails. thanks, Iain
Index: i386.md =================================================================== --- i386.md (revision 201091) +++ i386.md (working copy) @@ -16233,12 +16233,7 @@ (define_insn_and_split "nonlocal_goto_receiver" [(unspec_volatile [(const_int 0)] UNSPECV_NLGR)] "TARGET_MACHO && !TARGET_64BIT && flag_pic" -{ - if (crtl->uses_pic_offset_table) - return "#"; - else - return ""; /* No pic reg restore needed. */ -} + "#" "&& reload_completed" [(const_int 0)] { @@ -16258,6 +16253,10 @@ xops[2] = gen_rtx_CONST (Pmode, tmp); ix86_expand_binary_operator (MINUS, SImode, xops); } + else + /* No pic reg restore needed. */ + emit_note (NOTE_INSN_DELETED); + DONE; })