[U-Boot,v2] Add support for Wandboard quad.

Add support for Wandboard quad.

Signed-off-by: Tapani Utriainen <tapani@technexion.com>
---
 Changes from v1:
 - reorganized the board names into alphabetical order
 - added quad entry to the Wandboard README
 
 board/wandboard/README      | 5 +++++
 boards.cfg                  | 1 +
 include/configs/wandboard.h | 2 ++
 3 files changed, 8 insertions(+)

--
1.8.0.3

On Tue, May 28, 2013 at 5:04 AM, Tapani Utriainen <tapani@technexion.com>wrote:

>
> Add support for Wandboard quad.
>
> Signed-off-by: Tapani Utriainen <tapani@technexion.com>
>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

Hi Tapani,

On 28/05/2013 10:04, Tapani Utriainen wrote:
> 
> Add support for Wandboard quad.
> 
> Signed-off-by: Tapani Utriainen <tapani@technexion.com>
> ---

Due to increased memory, a warning is generated for wandboard_quad:

wandboard.c: In function 'dram_init':
wandboard.c:47:31: warning: integer overflow in expression [-Woverflow]

It is better to fix it directly into this patch. Can you fix it by
casting to phys_size_t and resubmit ?

	gd->ram_size = (phys_size_t)CONFIG_DDR_MB * SZ_1M;

By the way, I forget why it is not possible to use get_ram_size() here.
I know this is not part of this patch (could be done later), but any
hints why we cannot use as usual get_ram_size() in dram_init ?

Thanks,
Stefano Babic

Dear Stefano Babic,

In message <51AC61A6.9050609@denx.de> you wrote:
> 
> It is better to fix it directly into this patch. Can you fix it by
> casting to phys_size_t and resubmit ?
> 
> 	gd->ram_size = (phys_size_t)CONFIG_DDR_MB * SZ_1M;

Please do NOT use these terrible  SZ_*  defines.  Never, ever.

They are dangerous and should be avoided.

Best regards,

Wolfgang Denk

On Mon, Jun 3, 2013 at 8:21 AM, Wolfgang Denk <wd@denx.de> wrote:

> Dear Stefano Babic,
>
> In message <51AC61A6.9050609@denx.de> you wrote:
> >
> > It is better to fix it directly into this patch. Can you fix it by
> > casting to phys_size_t and resubmit ?
> >
> >       gd->ram_size = (phys_size_t)CONFIG_DDR_MB * SZ_1M;
>
> Please do NOT use these terrible  SZ_*  defines.  Never, ever.
>
> They are dangerous and should be avoided.
>

Do you mind to explain why?

Dear Otavio,

In message <CAP9ODKonqM3QLeryOBrgvgfqwdrT+2ePfk+MBECzewDhjQ6FQg@mail.gmail.com> you wrote:
>
> > Please do NOT use these terrible  SZ_*  defines.  Never, ever.
> >
> > They are dangerous and should be avoided.
> >
> 
> Do you mind to explain why?

Well, what does "SZ_1M" mean?  Is it 1000 * 1000 (as on hard disk
drives) or 1000 * 1024 (as on floppy disks) or 1024 * 1024 (as for
memory sizes)?

Instead of just seeing at first look what the code does, you have to
look up the actual define, i. e. it obfuscates the code instead of
being helpful.

This has been discussed several times before on the list; see for
example [1] or [2].

[1] http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67552/focus=67575
[2] http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/93425

Best regards,

Wolfgang Denk

Hello Tapani,

On Tue, May 28, 2013 at 5:04 AM, Tapani Utriainen <tapani@technexion.com> wrote:
>
> Add support for Wandboard quad.
>
> Signed-off-by: Tapani Utriainen <tapani@technexion.com>

Can you handle the comments done by Wolfgang and Stefano?

It'd be very good to have it merged for 2013.07 but we're getting short on time.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750