| Message ID | 20240501-qcom-phy-fixes-v1-0-f1fd15c33fb3@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: fix PHY-related warnings | expand |
Hi, On Wed, May 1, 2024 at 9:19 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > The DT schema doesn't have a fallback compatible for > qcom,sc7180-qmp-ufs-phy. Drop it from the dtsi too. > > Fixes: 858536d9dc94 ("arm64: dts: qcom: sc7180: Add UFS nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 4774a859bd7e..52d074a4fbf3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1582,8 +1582,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > }; > > ufs_mem_phy: phy@1d87000 { > - compatible = "qcom,sc7180-qmp-ufs-phy", > - "qcom,sm7150-qmp-ufs-phy"; > + compatible = "qcom,sc7180-qmp-ufs-phy"; Seems OK to me. It looks like UFS support for sc7180 is new enough that we're not breaking any sort of compatbility by changing this. Reviewed-by: Douglas Anderson <dianders@chromium.org>
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The UFS PHY is powered on via the UFS_PHY_GDSC power domain. Add > corresponding power-domain the the PHY node. > > Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> however this screams for a follow-up fix to use UFS_CARD(_2)_GDSC on respective hosts Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The UFS PHY is powered on via the UFS_PHY_GDSC power domain. Add > corresponding power-domain the the PHY node. > > Fixes: cc16687fbd74 ("arm64: dts: qcom: sdm845: add UFS controller") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> (same comment as p5) Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The UFS PHY is powered on via the UFS_PHY_GDSC power domain. Add > corresponding power-domain the the PHY node. > > Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> (same comment as p5) Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The UFS PHY is powered on via the UFS_PHY_GDSC power domain. Add > corresponding power-domain the the PHY node. > > Fixes: 5a814af5fc22 ("arm64: dts: qcom: sm6350: Add UFS nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> (same comment as p5) Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The UFS PHY is powered on via the UFS_PHY_GDSC power domain. Add > corresponding power-domain the the PHY node. > > Fixes: b7e2fba06622 ("arm64: dts: qcom: sm8250: Add UFS controller and PHY") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> (same comment as p5) Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The UFS PHY is powered on via the UFS_PHY_GDSC power domain. Add > corresponding power-domain the the PHY node. > > Fixes: 59c7cf814783 ("arm64: dts: qcom: sm8350: Add UFS nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> (same comment as p5) Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The UFS PHY is powered on via the UFS_PHY_GDSC power domain. Add > corresponding power-domain the the PHY node. > > Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> (same comment as p5) Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > On the IFC6560 one of the USB PHY supplies is the L10A power supply. > However this regulator also supplies VDDA_APC1_CS, VDD_PLL2 and VDD_P11 > consumers. Touching the supply causes the board to be reset. Document > the supply as a fixed always-on regulator. how not to design your power rails 101 > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts > index 702ab49bbc59..60412281ab27 100644 > --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts > +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts > @@ -96,6 +96,18 @@ v5p0_boost: v5p0-boost-regulator { > > vin-supply = <&vph_pwr>; > }; > + > + /* > + * this is also used for APC1 CPU power, touching it resets the board > + */ /* This... */ Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 1.05.2024 6:19 PM, Dmitry Baryshkov wrote: > The USB PHYs don't use extcon connectors, drop the extcon property from > the hsusb_phy1 node. These don't, some do (like the one on 8916( > > Fixes: 46680fe9ba61 ("arm64: dts: qcom: msm8996: Add support for the Xiaomi MSM8996 platform") > Cc: Yassine Oudjana <y.oudjana@protonmail.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Wed, 01 May 2024 19:19:26 +0300, Dmitry Baryshkov wrote: > This series goes over Qualcomm PHY bindings and device DTs and fixes > obvious errors and warnings reported by dt-validate. > > Applied, thanks! [01/13] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: fix x1e80100-gen3x2 schema commit: 484b139a4cd7e629f8fcb43d71997f400c5b8537 [02/13] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: fix msm899[68] power-domains commit: 59e377a124dc9039d9554d823b1cb4942bcee9a0 [03/13] dt-bindings: phy: qcom,usb-snps-femto-v2: use correct fallback for sc8180x commit: 960b3f023d3bda0efd6e573a0647227d1115d266 Best regards,
On Wed, 01 May 2024 19:19:26 +0300, Dmitry Baryshkov wrote: > This series goes over Qualcomm PHY bindings and device DTs and fixes > obvious errors and warnings reported by dt-validate. > > Applied, thanks! [04/13] arm64: dts: qcom: sc7180: drop extra UFS PHY compat commit: 48299f604d27dad1168cc90b89f33853162c6e33 [05/13] arm64: dts: qcom: sc8180x: add power-domain to UFS PHY commit: 9a80ecce60bd4919019a3cdb64604c9b183a8518 [06/13] arm64: dts: qcom: sdm845: add power-domain to UFS PHY commit: fd39ae8b9bc10419b1e4b849cdbc6755a967ade1 [07/13] arm64: dts: qcom: sm6115: add power-domain to UFS PHY commit: a9eb454873a813ddc4578e5c3b37778de6fda472 [08/13] arm64: dts: qcom: sm6350: add power-domain to UFS PHY commit: 18c2727282c5264ff5502daac26c43000e8eb202 [09/13] arm64: dts: qcom: sm8250: add power-domain to UFS PHY commit: 154ed5ea328d8a97a4ef5d1447e6f06d11fe2bbe [10/13] arm64: dts: qcom: sm8350: add power-domain to UFS PHY commit: 634acc8cea1584b507801315831a330443f819b4 [11/13] arm64: dts: qcom: sm8450: add power-domain to UFS PHY commit: 27d3f57cf5a71484ea38770d4bfd10f6ef035cf4 [12/13] arm64: dts: sda660-ifc6560: document missing USB PHY supplies commit: 4edbcf264fe2c0167e0b0b0af060bc767e01f9f3 [13/13] arm64: dts: qcom: msm8996-xiaomi-common: drop excton from the USB PHY commit: c1aefeae8cb7b71c1bb6d33b1bda7fc322094e16 Best regards,
This series goes over Qualcomm PHY bindings and device DTs and fixes obvious errors and warnings reported by dt-validate. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Dmitry Baryshkov (13): dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: fix x1e80100-gen3x2 schema dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: fix msm899[68] power-domains dt-bindings: phy: qcom,usb-snps-femto-v2: use correct fallback for sc8180x arm64: dts: qcom: sc7180: drop extra UFS PHY compat arm64: dts: qcom: sc8180x: add power-domain to UFS PHY arm64: dts: qcom: sdm845: add power-domain to UFS PHY arm64: dts: qcom: sm6115: add power-domain to UFS PHY arm64: dts: qcom: sm6350: add power-domain to UFS PHY arm64: dts: qcom: sm8250: add power-domain to UFS PHY arm64: dts: qcom: sm8350: add power-domain to UFS PHY arm64: dts: qcom: sm8450: add power-domain to UFS PHY arm64: dts: sda660-ifc6560: document missing USB PHY supplies arm64: dts: qcom: msm8996-xiaomi-common: drop excton from the USB PHY .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 1 - .../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 16 +++++++++++++++- .../devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 4 +--- arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 1 - arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +-- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 15 +++++++++++++++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm6115.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++ 13 files changed, 46 insertions(+), 8 deletions(-) --- base-commit: f0282d40f30868d986d9c94201949e5d1d44acc9 change-id: 20240429-qcom-phy-fixes-84170a781e13 Best regards,