| Message ID | cover.1709655755.git.u.kleine-koenig@pengutronix.de |
|---|---|
| Headers | show |
| Series | ipmi: Convert to platform remove callback returning void | expand |
Hello, On Tue, Mar 05, 2024 at 05:26:57PM +0100, Uwe Kleine-König wrote: > this series converts all drivers below drivers/char/ipmi to struct > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform: Provide a > remove callback that returns no value") for an extended explanation and the > eventual goal. > > All conversations are trivial, because their .remove() callbacks > returned zero unconditionally. > > There are no interdependencies between these patches, so they could be > picked up individually. But I'd hope that they get picked up all > together by Corey. Apart from a (positive) review reply I didn't get any feedback to this series. My quest to change the prototype of struct platform_driver::remove depends on these patches, so it would be great if they made it in during the next merge window. Best regards Uwe
On Thu, Apr 11, 2024 at 09:15:03AM +0200, Uwe Kleine-König wrote: > Hello, > > On Tue, Mar 05, 2024 at 05:26:57PM +0100, Uwe Kleine-König wrote: > > this series converts all drivers below drivers/char/ipmi to struct > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform: Provide a > > remove callback that returns no value") for an extended explanation and the > > eventual goal. > > > > All conversations are trivial, because their .remove() callbacks > > returned zero unconditionally. > > > > There are no interdependencies between these patches, so they could be > > picked up individually. But I'd hope that they get picked up all > > together by Corey. Yeah, I was kind of waiting for more reviews, but this is pretty straightforward. I've pulled this into my tree. -corey > > Apart from a (positive) review reply I didn't get any feedback to this > series. My quest to change the prototype of struct > platform_driver::remove depends on these patches, so it would be great > if they made it in during the next merge window. > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello Corey, On Thu, Apr 11, 2024 at 10:11:21AM -0500, Corey Minyard wrote: > On Thu, Apr 11, 2024 at 09:15:03AM +0200, Uwe Kleine-König wrote: > > Hello, > > > > On Tue, Mar 05, 2024 at 05:26:57PM +0100, Uwe Kleine-König wrote: > > > this series converts all drivers below drivers/char/ipmi to struct > > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform: Provide a > > > remove callback that returns no value") for an extended explanation and the > > > eventual goal. > > > > > > All conversations are trivial, because their .remove() callbacks > > > returned zero unconditionally. > > > > > > There are no interdependencies between these patches, so they could be > > > picked up individually. But I'd hope that they get picked up all > > > together by Corey. > > Yeah, I was kind of waiting for more reviews, but this is pretty > straightforward. I've pulled this into my tree. These changes are in next since a while but didn't land in Linus tree for v6.10-rc1. I intend to send a PR to Greg early next week changing platform_driver::remove to match remove_new. If these commits don't make it in in time, I'll be so bold and just include the commits from your for-next branch in my PR. Best regards Uwe
Hello Corey, On Sat, May 25, 2024 at 09:39:36AM -0500, Corey Minyard wrote: > On Sat, May 25, 2024 at 12:10:38PM +0200, Uwe Kleine-König wrote: > > These changes are in next since a while but didn't land in Linus tree > > for v6.10-rc1. I intend to send a PR to Greg early next week changing > > platform_driver::remove to match remove_new. If these commits don't make > > it in in time, I'll be so bold and just include the commits from your > > for-next branch in my PR. > > I sent them to Linus right after 6.9 dropped, let me resend... That worked, they landed now in Linus' tree. Thanks, that makes it a bit less ugly for me. Best regards Uwe
Hello, this series converts all drivers below drivers/char/ipmi to struct platform_driver::remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. All conversations are trivial, because their .remove() callbacks returned zero unconditionally. There are no interdependencies between these patches, so they could be picked up individually. But I'd hope that they get picked up all together by Corey. Best regards Uwe Uwe Kleine-König (6): ipmi: bt-bmc: Convert to platform remove callback returning void ipmi: ipmi_powernv: Convert to platform remove callback returning void ipmi: ipmi_si_platform: Convert to platform remove callback returning void ipmi: ipmi_ssif: Convert to platform remove callback returning void ipmi: kcs_bmc_aspeed: Convert to platform remove callback returning void ipmi: kcs_bmc_npcm7xx: Convert to platform remove callback returning void drivers/char/ipmi/bt-bmc.c | 5 ++--- drivers/char/ipmi/ipmi_powernv.c | 6 ++---- drivers/char/ipmi/ipmi_si_platform.c | 6 ++---- drivers/char/ipmi/ipmi_ssif.c | 5 ++--- drivers/char/ipmi/kcs_bmc_aspeed.c | 6 ++---- drivers/char/ipmi/kcs_bmc_npcm7xx.c | 6 ++---- 6 files changed, 12 insertions(+), 22 deletions(-) base-commit: 11afac187274a6177a7ac82997f8691c0f469e41