Message ID | 20231203003224.1638841-1-ams@codesourcery.com |
---|---|
Headers | show |
Series | libgomp: OpenMP low-latency omp_alloc | expand |
Hi Andrew, On 03.12.23 01:32, Andrew Stubbs wrote: > This patch series is a rework of the patch series posted in August. > https://patchwork.sourceware.org/project/gcc/list/?series=23045&state=%2A&archive=both > > The series implements device-specific allocators and adds a low-latency > allocator for both GPUs architectures. As mentioned, can you also update libgomp/libgomp.texi? I don't have a strong preference where in that file nor how it is documented, but it seems to make sense to document as follows: (A) Document the GCN/NVPX specifics on the respective pages below https://gcc.gnu.org/onlinedocs/libgomp/Offload-Target-Specifics.html (B) To make it possible to find it, @ref'er to that page from: And https://gcc.gnu.org/onlinedocs/libgomp/Memory-allocation.html (May be just 'See also:' or 'For offload-device specifics to memory allocation, see' or something like that.) (C) Maybe, some wording should be added to OMP_ALLOCATOR that the cgrouppteam/thread pre-defined allocators use (implementation choice) the low-latency memory space; for instance, add a sentence under the first table – or use the first table 'omp_low_lat_mem_space (implementation choice)' or some other wordings which make clear what GCC does but that the spec does not specify this. https://gcc.gnu.org/onlinedocs/libgomp/OMP_005fALLOCATOR.html Maybe we should add to OMP_ALLOCATOR also a @ref to "Offload Target Specifics"? Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
I cannot "grep" – all three patches do contain .texi changes. I have a comment to them, but I will comment individually on them. Hence, scratch: On 04.12.23 16:34, Tobias Burnus wrote: > On 03.12.23 01:32, Andrew Stubbs wrote: >> This patch series is a rework of the patch series posted in August. >> https://patchwork.sourceware.org/project/gcc/list/?series=23045&state=%2A&archive=both >> >> >> The series implements device-specific allocators and adds a low-latency >> allocator for both GPUs architectures. > > As mentioned, can you also update libgomp/libgomp.texi? Sorry for missing those changes. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955