Message ID | 20230503084608.14008-2-biju.das.jz@bp.renesas.com |
---|---|
State | Superseded, archived |
Headers | show |
Series | Add Renesas PMIC RAA215300 and built-in RTC support | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
Hi Biju, On Wed, May 3, 2023 at 10:46 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Document Renesas RAA215300 PMIC bindings. > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > Memory, with Built-In Charger and RTC. > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > The internally compensated regulators, built-in Real-Time Clock (RTC), > 32kHz crystal oscillator, and coin cell battery charger provide a > highly integrated, small footprint power solution ideal for > System-On-Module (SOM) applications. A spread spectrum feature > provides an ease-of-use solution for noise-sensitive audio or RF > applications. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/renesas,raa215300.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > + > +maintainers: > + - Biju Das <biju.das.jz@bp.renesas.com> > + > +description: | > + The RAA215300 is a high-performance, low-cost 9-channel PMIC designed for > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, DDR3L, DDR4, > + and LPDDR4 memory power requirements. The internally compensated regulators, > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin cell > + battery charger provide a highly integrated, small footprint power solution > + ideal for System-On-Module (SOM) applications. A spread spectrum feature > + provides an ease-of-use solution for noise-sensitive audio or RF applications. > + > + This device exposes two devices via I2C. One for the integrated RTC IP, and > + one for everything else. > + > + Link to datasheet: > + https://www.renesas.com/in/en/products/power-power-management/multi-channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic-and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-memory-built-charger-and-rtc > + > +properties: > + compatible: > + enum: > + - renesas,raa215300 renesas,raa215300-pmic? > + > + reg: > + maxItems: 1 > + > + renesas,raa215300-rtc: renesas,rtc? > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the built-in RTC device. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic: raa215300@12 { > + compatible = "renesas,raa215300"; > + reg = <0x12>; > + > + renesas,raa215300-rtc = <&rtc_raa215300>; > + }; > + }; > -- > 2.25.1 > -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH RFC 1/6] dt-bindings: mfd: Add Renesas RAA215300 PMIC > bindings > > Hi Biju, > > On Wed, May 3, 2023 at 10:46 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Document Renesas RAA215300 PMIC bindings. > > > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > > Memory, with Built-In Charger and RTC. > > > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > > The internally compensated regulators, built-in Real-Time Clock (RTC), > > 32kHz crystal oscillator, and coin cell battery charger provide a > > highly integrated, small footprint power solution ideal for > > System-On-Module (SOM) applications. A spread spectrum feature > > provides an ease-of-use solution for noise-sensitive audio or RF > > applications. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fschemas%2Fmfd%2Frenesas%2Craa215300.yaml%23&data=05%7C01 > > +%7Cbiju.das.jz%40bp.renesas.com%7C37302c6f37b048ae260f08db4bba1f2f%7C > > +53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638187034978703511%7CUnkno > > +wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi > > +LCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qnhJGzPolFSsY1fN2p8BJTw%2FCZunFI > > +%2BWgZne6CXS0T4%3D&reserved=0 > > +$schema: > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cbiju.das.jz%4 > > +0bp.renesas.com%7C37302c6f37b048ae260f08db4bba1f2f%7C53d82571da1947e4 > > +9cb4625a166a4a2a%7C0%7C0%7C638187034978703511%7CUnknown%7CTWFpbGZsb3d > > +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > > +C3000%7C%7C%7C&sdata=86%2FKxrWS6oJZVpmTyYmKqJmRuBTYWqmqSlwMvtS16pc%3D > > +&reserved=0 > > + > > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > > + > > +maintainers: > > + - Biju Das <biju.das.jz@bp.renesas.com> > > + > > +description: | > > + The RAA215300 is a high-performance, low-cost 9-channel PMIC > > +designed for > > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, > > +DDR3L, DDR4, > > + and LPDDR4 memory power requirements. The internally compensated > > +regulators, > > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin > > +cell > > + battery charger provide a highly integrated, small footprint power > > +solution > > + ideal for System-On-Module (SOM) applications. A spread spectrum > > +feature > > + provides an ease-of-use solution for noise-sensitive audio or RF > applications. > > + > > + This device exposes two devices via I2C. One for the integrated RTC > > + IP, and one for everything else. > > + > > + Link to datasheet: > > + > > + https://www.renesas.com/in/en/products/power-power-management/multi- > > + channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic- > > + and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-me > > + mory-built-charger-and-rtc > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,raa215300 > > renesas,raa215300-pmic? OK. > > > + > > + reg: > > + maxItems: 1 > > + > > + renesas,raa215300-rtc: > > renesas,rtc? OK. Will wait for others comments. Cheers, Biju > > > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the built-in RTC device. > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pmic: raa215300@12 { > > + compatible = "renesas,raa215300"; > > + reg = <0x12>; > > + > > + renesas,raa215300-rtc = <&rtc_raa215300>; > > + }; > > + }; > > -- > > 2.25.1 > >
On 03/05/2023 12:20, Biju Das wrote: > Hi Geert, > > Thanks for the feedback. > >> Subject: Re: [PATCH RFC 1/6] dt-bindings: mfd: Add Renesas RAA215300 PMIC >> bindings >> >> Hi Biju, >> >> On Wed, May 3, 2023 at 10:46 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: >>> Document Renesas RAA215300 PMIC bindings. >>> >>> The RAA215300 is a high Performance 9-Channel PMIC supporting DDR >>> Memory, with Built-In Charger and RTC. >>> >>> It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. >>> The internally compensated regulators, built-in Real-Time Clock (RTC), >>> 32kHz crystal oscillator, and coin cell battery charger provide a >>> highly integrated, small footprint power solution ideal for >>> System-On-Module (SOM) applications. A spread spectrum feature >>> provides an ease-of-use solution for noise-sensitive audio or RF >>> applications. >>> >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> >> >> Thanks for your patch! >> >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml >>> @@ -0,0 +1,57 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>> +--- >>> +$id: >>> +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi >>> +cetree.org%2Fschemas%2Fmfd%2Frenesas%2Craa215300.yaml%23&data=05%7C01 >>> +%7Cbiju.das.jz%40bp.renesas.com%7C37302c6f37b048ae260f08db4bba1f2f%7C >>> +53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638187034978703511%7CUnkno >>> +wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi >>> +LCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qnhJGzPolFSsY1fN2p8BJTw%2FCZunFI >>> +%2BWgZne6CXS0T4%3D&reserved=0 >>> +$schema: >>> +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi >>> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cbiju.das.jz%4 >>> +0bp.renesas.com%7C37302c6f37b048ae260f08db4bba1f2f%7C53d82571da1947e4 >>> +9cb4625a166a4a2a%7C0%7C0%7C638187034978703511%7CUnknown%7CTWFpbGZsb3d >>> +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 >>> +C3000%7C%7C%7C&sdata=86%2FKxrWS6oJZVpmTyYmKqJmRuBTYWqmqSlwMvtS16pc%3D >>> +&reserved=0 >>> + >>> +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) >>> + >>> +maintainers: >>> + - Biju Das <biju.das.jz@bp.renesas.com> >>> + >>> +description: | >>> + The RAA215300 is a high-performance, low-cost 9-channel PMIC >>> +designed for >>> + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, >>> +DDR3L, DDR4, >>> + and LPDDR4 memory power requirements. The internally compensated >>> +regulators, >>> + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin >>> +cell >>> + battery charger provide a highly integrated, small footprint power >>> +solution >>> + ideal for System-On-Module (SOM) applications. A spread spectrum >>> +feature >>> + provides an ease-of-use solution for noise-sensitive audio or RF >> applications. >>> + >>> + This device exposes two devices via I2C. One for the integrated RTC >>> + IP, and one for everything else. >>> + >>> + Link to datasheet: >>> + >>> + https://www.renesas.com/in/en/products/power-power-management/multi- >>> + channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic- >>> + and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-me >>> + mory-built-charger-and-rtc >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - renesas,raa215300 >> >> renesas,raa215300-pmic? Depends if raa215300 is piece of SoC or just PMIC. If the latter, usually compatibles do not have types added. Best regards, Krzysztof
On 03/05/2023 10:46, Biju Das wrote: > Document Renesas RAA215300 PMIC bindings. > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > Memory, with Built-In Charger and RTC. > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > The internally compensated regulators, built-in Real-Time Clock (RTC), > 32kHz crystal oscillator, and coin cell battery charger provide a > highly integrated, small footprint power solution ideal for > System-On-Module (SOM) applications. A spread spectrum feature > provides an ease-of-use solution for noise-sensitive audio or RF > applications. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > .../bindings/mfd/renesas,raa215300.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > new file mode 100644 > index 000000000000..1e65f7618333 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/renesas,raa215300.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > + > +maintainers: > + - Biju Das <biju.das.jz@bp.renesas.com> > + > +description: | > + The RAA215300 is a high-performance, low-cost 9-channel PMIC designed for > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, DDR3L, DDR4, > + and LPDDR4 memory power requirements. The internally compensated regulators, > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin cell > + battery charger provide a highly integrated, small footprint power solution > + ideal for System-On-Module (SOM) applications. A spread spectrum feature > + provides an ease-of-use solution for noise-sensitive audio or RF applications. > + > + This device exposes two devices via I2C. One for the integrated RTC IP, and > + one for everything else. > + > + Link to datasheet: > + https://www.renesas.com/in/en/products/power-power-management/multi-channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic-and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-memory-built-charger-and-rtc > + > +properties: > + compatible: > + enum: > + - renesas,raa215300 > + > + reg: > + maxItems: 1 > + > + renesas,raa215300-rtc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the built-in RTC device. Why do you need phandle to anything else? This looks like wrong relationship described. If these are siblings, why do you need cross-linking via phandles? Most of PMICs are described with one node, even though RTC is on separate address. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic: raa215300@12 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "renesas,raa215300"; > + reg = <0x12>; > + > + renesas,raa215300-rtc = <&rtc_raa215300>; > + }; > + }; Best regards, Krzysztof
Hi Krzysztof Kozlowski, Thanks for the feedback. > Subject: Re: [PATCH RFC 1/6] dt-bindings: mfd: Add Renesas RAA215300 PMIC > bindings > > On 03/05/2023 10:46, Biju Das wrote: > > Document Renesas RAA215300 PMIC bindings. > > > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > > Memory, with Built-In Charger and RTC. > > > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > > The internally compensated regulators, built-in Real-Time Clock (RTC), > > 32kHz crystal oscillator, and coin cell battery charger provide a > > highly integrated, small footprint power solution ideal for > > System-On-Module (SOM) applications. A spread spectrum feature > > provides an ease-of-use solution for noise-sensitive audio or RF > > applications. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > .../bindings/mfd/renesas,raa215300.yaml | 57 +++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > new file mode 100644 > > index 000000000000..1e65f7618333 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > > + > > +maintainers: > > + - Biju Das <biju.das.jz@bp.renesas.com> > > + > > +description: | > > + The RAA215300 is a high-performance, low-cost 9-channel PMIC > > +designed for > > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, > > +DDR3L, DDR4, > > + and LPDDR4 memory power requirements. The internally compensated > > +regulators, > > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin > > +cell > > + battery charger provide a highly integrated, small footprint power > > +solution > > + ideal for System-On-Module (SOM) applications. A spread spectrum > > +feature > > + provides an ease-of-use solution for noise-sensitive audio or RF > applications. > > + > > + This device exposes two devices via I2C. One for the integrated RTC > > + IP, and one for everything else. > > + > > + Link to datasheet: > > + > > + https://www.renesas.com/in/en/products/power-power-management/multi- > > + channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic- > > + and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-me > > + mory-built-charger-and-rtc > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,raa215300 > > + > > + reg: > > + maxItems: 1 > > + > > + renesas,raa215300-rtc: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the built-in RTC device. > > Why do you need phandle to anything else? This looks like wrong relationship > described. If these are siblings, why do you need cross-linking via > phandles? > > Most of PMICs are described with one node, even though RTC is on separate > address. OK, will model like below raa215300: pmic@12 { compatible = "renesas,raa215300"; reg = <0x12 0x6f>; reg-names = "main", "rtc"; }; Cheers, Biju > > > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pmic: raa215300@12 { > > Node names should be generic. OK, will fix. > > > + compatible = "renesas,raa215300"; > > + reg = <0x12>; > > + > > + renesas,raa215300-rtc = <&rtc_raa215300>; > > + }; > > + }; > > Best regards, > Krzysztof
On 04/05/2023 18:13, Biju Das wrote: > Hi Krzysztof Kozlowski, > > Thanks for the feedback. > >> Subject: Re: [PATCH RFC 1/6] dt-bindings: mfd: Add Renesas RAA215300 PMIC >> bindings >> >> On 03/05/2023 10:46, Biju Das wrote: >>> Document Renesas RAA215300 PMIC bindings. >>> >>> The RAA215300 is a high Performance 9-Channel PMIC supporting DDR >>> Memory, with Built-In Charger and RTC. >>> >>> It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. >>> The internally compensated regulators, built-in Real-Time Clock (RTC), >>> 32kHz crystal oscillator, and coin cell battery charger provide a >>> highly integrated, small footprint power solution ideal for >>> System-On-Module (SOM) applications. A spread spectrum feature >>> provides an ease-of-use solution for noise-sensitive audio or RF >>> applications. >>> >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> >>> --- >>> .../bindings/mfd/renesas,raa215300.yaml | 57 +++++++++++++++++++ >>> 1 file changed, 57 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml >>> b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml >>> new file mode 100644 >>> index 000000000000..1e65f7618333 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml >>> @@ -0,0 +1,57 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>> +--- >>> +$id: >>> +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) >>> + >>> +maintainers: >>> + - Biju Das <biju.das.jz@bp.renesas.com> >>> + >>> +description: | >>> + The RAA215300 is a high-performance, low-cost 9-channel PMIC >>> +designed for >>> + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, >>> +DDR3L, DDR4, >>> + and LPDDR4 memory power requirements. The internally compensated >>> +regulators, >>> + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin >>> +cell >>> + battery charger provide a highly integrated, small footprint power >>> +solution >>> + ideal for System-On-Module (SOM) applications. A spread spectrum >>> +feature >>> + provides an ease-of-use solution for noise-sensitive audio or RF >> applications. >>> + >>> + This device exposes two devices via I2C. One for the integrated RTC >>> + IP, and one for everything else. >>> + >>> + Link to datasheet: >>> + >>> + https://www.renesas.com/in/en/products/power-power-management/multi- >>> + channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic- >>> + and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-me >>> + mory-built-charger-and-rtc >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - renesas,raa215300 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + renesas,raa215300-rtc: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: phandle to the built-in RTC device. >> >> Why do you need phandle to anything else? This looks like wrong relationship >> described. If these are siblings, why do you need cross-linking via >> phandles? >> >> Most of PMICs are described with one node, even though RTC is on separate >> address. > > OK, will model like below > > raa215300: pmic@12 { > compatible = "renesas,raa215300"; > reg = <0x12 0x6f>; > reg-names = "main", "rtc"; Just two separate regs. I think this should work for I2C bus. The DT schema allows multiple addresses for children. Best regards, Krzysztof
Hi Krzysztof Kozlowski, > Subject: Re: [PATCH RFC 1/6] dt-bindings: mfd: Add Renesas RAA215300 PMIC > bindings > > On 04/05/2023 18:13, Biju Das wrote: > > Hi Krzysztof Kozlowski, > > > > Thanks for the feedback. > > > >> Subject: Re: [PATCH RFC 1/6] dt-bindings: mfd: Add Renesas RAA215300 > >> PMIC bindings > >> > >> On 03/05/2023 10:46, Biju Das wrote: > >>> Document Renesas RAA215300 PMIC bindings. > >>> > >>> The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > >>> Memory, with Built-In Charger and RTC. > >>> > >>> It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > >>> The internally compensated regulators, built-in Real-Time Clock > >>> (RTC), 32kHz crystal oscillator, and coin cell battery charger > >>> provide a highly integrated, small footprint power solution ideal > >>> for System-On-Module (SOM) applications. A spread spectrum feature > >>> provides an ease-of-use solution for noise-sensitive audio or RF > >>> applications. > >>> > >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > >>> --- > >>> .../bindings/mfd/renesas,raa215300.yaml | 57 +++++++++++++++++++ > >>> 1 file changed, 57 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > >>> b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > >>> new file mode 100644 > >>> index 000000000000..1e65f7618333 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > >>> @@ -0,0 +1,57 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > >>> +--- > >>> +$id: > >>> +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > >>> + > >>> +maintainers: > >>> + - Biju Das <biju.das.jz@bp.renesas.com> > >>> + > >>> +description: | > >>> + The RAA215300 is a high-performance, low-cost 9-channel PMIC > >>> +designed for > >>> + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, > >>> +DDR3L, DDR4, > >>> + and LPDDR4 memory power requirements. The internally compensated > >>> +regulators, > >>> + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and > >>> +coin cell > >>> + battery charger provide a highly integrated, small footprint > >>> +power solution > >>> + ideal for System-On-Module (SOM) applications. A spread spectrum > >>> +feature > >>> + provides an ease-of-use solution for noise-sensitive audio or RF > >> applications. > >>> + > >>> + This device exposes two devices via I2C. One for the integrated > >>> + RTC IP, and one for everything else. > >>> + > >>> + Link to datasheet: > >>> + > >>> + https://www.renesas.com/in/en/products/power-power-management/mult > >>> + i- > >>> + channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmi > >>> + c- > >>> + and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr- > >>> + me > >>> + mory-built-charger-and-rtc > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - renesas,raa215300 > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + renesas,raa215300-rtc: > >>> + $ref: /schemas/types.yaml#/definitions/phandle > >>> + description: phandle to the built-in RTC device. > >> > >> Why do you need phandle to anything else? This looks like wrong > >> relationship described. If these are siblings, why do you need > >> cross-linking via phandles? > >> > >> Most of PMICs are described with one node, even though RTC is on > >> separate address. > > > > OK, will model like below > > > > raa215300: pmic@12 { > > compatible = "renesas,raa215300"; > > reg = <0x12 0x6f>; > > reg-names = "main", "rtc"; > > Just two separate regs. I think this should work for I2C bus. The DT schema > allows multiple addresses for children. OK, I will add like below reg = <0x12>, <0x6f>; Apart from this, I would like to add below optional properties as the enabling is based On board design. renesas,rtc-enable: To indicate RTC IP is enabled (eg:Cases like both XIN and XOUT grounded) interrupts: (eg: Cases like interrupt line is not connected to SoC) Cheers, Biju
diff --git a/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml new file mode 100644 index 000000000000..1e65f7618333 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/renesas,raa215300.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) + +maintainers: + - Biju Das <biju.das.jz@bp.renesas.com> + +description: | + The RAA215300 is a high-performance, low-cost 9-channel PMIC designed for + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, DDR3L, DDR4, + and LPDDR4 memory power requirements. The internally compensated regulators, + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin cell + battery charger provide a highly integrated, small footprint power solution + ideal for System-On-Module (SOM) applications. A spread spectrum feature + provides an ease-of-use solution for noise-sensitive audio or RF applications. + + This device exposes two devices via I2C. One for the integrated RTC IP, and + one for everything else. + + Link to datasheet: + https://www.renesas.com/in/en/products/power-power-management/multi-channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic-and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-memory-built-charger-and-rtc + +properties: + compatible: + enum: + - renesas,raa215300 + + reg: + maxItems: 1 + + renesas,raa215300-rtc: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the built-in RTC device. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pmic: raa215300@12 { + compatible = "renesas,raa215300"; + reg = <0x12>; + + renesas,raa215300-rtc = <&rtc_raa215300>; + }; + };
Document Renesas RAA215300 PMIC bindings. The RAA215300 is a high Performance 9-Channel PMIC supporting DDR Memory, with Built-In Charger and RTC. It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. The internally compensated regulators, built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin cell battery charger provide a highly integrated, small footprint power solution ideal for System-On-Module (SOM) applications. A spread spectrum feature provides an ease-of-use solution for noise-sensitive audio or RF applications. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- .../bindings/mfd/renesas,raa215300.yaml | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml