diff mbox series

[V10,2/6] i2c: nvidia-gpu: Add ACPI property to align with device-tree

Message ID 20230131175748.256423-3-jonathanh@nvidia.com
State Accepted
Headers show
Series Add device-tree support for Cypress CYPD4226 | expand

Commit Message

Jon Hunter Jan. 31, 2023, 5:57 p.m. UTC 
From: Wayne Chang <waynec@nvidia.com>

Device-tree uses the 'firmware-name' string property to pass a name of
the firmware build to the Cypress CCGx driver. Add a new ACPI string
property to the NVIDIA GPU I2C driver to align with device-tree so that
we can migrate to using a common property name for both ACPI and
device-tree.

Signed-off-by: Wayne Chang <waynec@nvidia.com>
Co-developed-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
V8 -> V10: no changes
V7: Added Heikki's reviewed-by
V6: no changes
V5: Added this patch from V3

 drivers/i2c/busses/i2c-nvidia-gpu.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jon Hunter Feb. 1, 2023, 4 p.m. UTC | #1 
H Wolfram,

On 31/01/2023 17:57, Jon Hunter wrote:
> From: Wayne Chang <waynec@nvidia.com>
> 
> Device-tree uses the 'firmware-name' string property to pass a name of
> the firmware build to the Cypress CCGx driver. Add a new ACPI string
> property to the NVIDIA GPU I2C driver to align with device-tree so that
> we can migrate to using a common property name for both ACPI and
> device-tree.
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Co-developed-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> V8 -> V10: no changes
> V7: Added Heikki's reviewed-by
> V6: no changes
> V5: Added this patch from V3
> 
>   drivers/i2c/busses/i2c-nvidia-gpu.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
> index 12e330cd7635..6d81ea530a83 100644
> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> @@ -261,6 +261,7 @@ MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
>   static const struct property_entry ccgx_props[] = {
>   	/* Use FW built for NVIDIA (nv) only */
>   	PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
> +	PROPERTY_ENTRY_STRING("firmware-name", "nvidia,gpu"),
>   	{ }
>   };
>   

Apologies, but we appear to be missing you on this series [0]. Please 
take a look at patches, 2, 3 and 4. If you are OK with the changes, I am 
not sure if it is easiest for Heikki or Greg to merge?

Thanks
Jon

[0] 
https://lore.kernel.org/linux-tegra/20230131175748.256423-1-jonathanh@nvidia.com/
Wolfram Sang Feb. 1, 2023, 4:56 p.m. UTC | #2 
> Apologies, but we appear to be missing you on this series [0].

Yup, me, the i2c-list and the dedicated maintainer for this driver:

$ scripts/get_maintainer.pl -f drivers/i2c/busses/i2c-nvidia-gpu.c
Ajay Gupta <ajayg@nvidia.com>
linux-i2c@vger.kernel.org
linux-kernel@vger.kernel.org

If Ajay Gupta is happy, you'll get my ack for free.
Jon Hunter Feb. 1, 2023, 8:21 p.m. UTC | #3 
On 01/02/2023 16:56, Wolfram Sang wrote:
> 
>> Apologies, but we appear to be missing you on this series [0].
> 
> Yup, me, the i2c-list and the dedicated maintainer for this driver:
> 
> $ scripts/get_maintainer.pl -f drivers/i2c/busses/i2c-nvidia-gpu.c
> Ajay Gupta <ajayg@nvidia.com>
> linux-i2c@vger.kernel.org
> linux-kernel@vger.kernel.org
> 
> If Ajay Gupta is happy, you'll get my ack for free.


Adding Ajay.

Jon
Ajay Gupta Feb. 1, 2023, 8:30 p.m. UTC | #4 
Hi,
> -----Original Message-----
> From: Jonathan Hunter <jonathanh@nvidia.com>
> Sent: Wednesday, February 1, 2023 12:21 PM
> To: Wolfram Sang <wsa@kernel.org>; Heikki Krogerus
> <heikki.krogerus@linux.intel.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Thierry Reding
> <thierry.reding@gmail.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-tegra@vger.kernel.org; Wayne Chang
> <waynec@nvidia.com>; Ajay Gupta <ajayg@nvidia.com>
> Subject: Re: [PATCH V10 2/6] i2c: nvidia-gpu: Add ACPI property to align with
> device-tree
> 
> 
> On 01/02/2023 16:56, Wolfram Sang wrote:
> >
> >> Apologies, but we appear to be missing you on this series [0].
> >
> > Yup, me, the i2c-list and the dedicated maintainer for this driver:
> >
> > $ scripts/get_maintainer.pl -f drivers/i2c/busses/i2c-nvidia-gpu.c
> > Ajay Gupta <ajayg@nvidia.com>
> > linux-i2c@vger.kernel.org
> > linux-kernel@vger.kernel.org
> >
> > If Ajay Gupta is happy, you'll get my ack for free.
> 
> 
> Adding Ajay.
Acked-by: Ajay Gupta <ajayg@nvidia.com>
 
Thanks
nvpublic
> Jon
> 
> --
> nvpublic
Wolfram Sang Feb. 1, 2023, 9:48 p.m. UTC | #5 
> > Adding Ajay.
> Acked-by: Ajay Gupta <ajayg@nvidia.com>

Acked-by: Wolfram Sang <wsa@kernel.org>
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
index 12e330cd7635..6d81ea530a83 100644
--- a/drivers/i2c/busses/i2c-nvidia-gpu.c
+++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
@@ -261,6 +261,7 @@  MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
 static const struct property_entry ccgx_props[] = {
 	/* Use FW built for NVIDIA (nv) only */
 	PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
+	PROPERTY_ENTRY_STRING("firmware-name", "nvidia,gpu"),
 	{ }
 };