| Message ID | 20221026130658.45601-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| Headers | show |
| Series | media: i2c: ov5645 driver enhancements | expand |
Hi Prabhakar, thanks for the patch, please see below my comments. On 22-10-26, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Make sure we dont stop the code flow in case of errors while stopping > the stream and return the error code of the first error case if any. > > v4l2-core takes care of warning the user so no need to add a warning > message in the driver. > > Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v2->v3 > * Now propagating the first error code in case of failure. > > v1->v2 > * New patch > --- > drivers/media/i2c/ov5645.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > index eea3067ddc8b..5702a55607fc 100644 > --- a/drivers/media/i2c/ov5645.c > +++ b/drivers/media/i2c/ov5645.c > @@ -996,17 +996,22 @@ static int ov5645_s_stream(struct v4l2_subdev *subdev, int enable) > if (ret < 0) > goto err_rpm_put; > } else { > + int stream_off_ret = 0; > + > ret = ov5645_write_reg(ov5645, OV5645_IO_MIPI_CTRL00, 0x40); If this write failed.. > if (ret < 0) > - return ret; > + stream_off_ret = ret; > > ret = ov5645_write_reg(ov5645, OV5645_SYSTEM_CTRL0, > OV5645_SYSTEM_CTRL0_STOP); why should this write be successful? Regards, Marco > - if (ret < 0) > - return ret; > + if (ret < 0 && !stream_off_ret) > + stream_off_ret = ret; > > pm_runtime_mark_last_busy(ov5645->dev); > pm_runtime_put_autosuspend(ov5645->dev); > + > + if (stream_off_ret) > + return stream_off_ret; > } > > return 0; > -- > 2.25.1 > > >
Hi Marco, Thank you for the review. On Wed, Oct 26, 2022 at 6:17 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > Hi Prabhakar, > > thanks for the patch, please see below my comments. > > On 22-10-26, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Make sure we dont stop the code flow in case of errors while stopping > > the stream and return the error code of the first error case if any. > > > > v4l2-core takes care of warning the user so no need to add a warning > > message in the driver. > > > > Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > v2->v3 > > * Now propagating the first error code in case of failure. > > > > v1->v2 > > * New patch > > --- > > drivers/media/i2c/ov5645.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > > index eea3067ddc8b..5702a55607fc 100644 > > --- a/drivers/media/i2c/ov5645.c > > +++ b/drivers/media/i2c/ov5645.c > > @@ -996,17 +996,22 @@ static int ov5645_s_stream(struct v4l2_subdev *subdev, int enable) > > if (ret < 0) > > goto err_rpm_put; > > } else { > > + int stream_off_ret = 0; > > + > > ret = ov5645_write_reg(ov5645, OV5645_IO_MIPI_CTRL00, 0x40); > > If this write failed.. > > > if (ret < 0) > > - return ret; > > + stream_off_ret = ret; > > > > ret = ov5645_write_reg(ov5645, OV5645_SYSTEM_CTRL0, > > OV5645_SYSTEM_CTRL0_STOP); > > why should this write be successful? > Indeed that will fail unless I have a lucky day ;-) But it seemed to be an overkill for adding an additional check to see if the previous write succeeded. Do you think this will create an issue? Cheers, Prabhakar
On 22-10-26, Lad, Prabhakar wrote: > Hi Marco, > > Thank you for the review. > > On Wed, Oct 26, 2022 at 6:17 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > > > Hi Prabhakar, > > > > thanks for the patch, please see below my comments. > > > > On 22-10-26, Prabhakar wrote: > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > Make sure we dont stop the code flow in case of errors while stopping > > > the stream and return the error code of the first error case if any. > > > > > > v4l2-core takes care of warning the user so no need to add a warning > > > message in the driver. > > > > > > Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > --- > > > v2->v3 > > > * Now propagating the first error code in case of failure. > > > > > > v1->v2 > > > * New patch > > > --- > > > drivers/media/i2c/ov5645.c | 11 ++++++++--- > > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > > > index eea3067ddc8b..5702a55607fc 100644 > > > --- a/drivers/media/i2c/ov5645.c > > > +++ b/drivers/media/i2c/ov5645.c > > > @@ -996,17 +996,22 @@ static int ov5645_s_stream(struct v4l2_subdev *subdev, int enable) > > > if (ret < 0) > > > goto err_rpm_put; > > > } else { > > > + int stream_off_ret = 0; > > > + > > > ret = ov5645_write_reg(ov5645, OV5645_IO_MIPI_CTRL00, 0x40); > > > > If this write failed.. > > > > > if (ret < 0) > > > - return ret; > > > + stream_off_ret = ret; > > > > > > ret = ov5645_write_reg(ov5645, OV5645_SYSTEM_CTRL0, > > > OV5645_SYSTEM_CTRL0_STOP); > > > > why should this write be successful? > > > Indeed that will fail unless I have a lucky day ;-) > > But it seemed to be an overkill for adding an additional check to see > if the previous write succeeded. Do you think this will create an > issue? Why not just say? ret = ov5645_write_reg(); if (ret < 0) goto out; ... out: dev_pm_xxx(); return ret; Regards, Marco
Hi Marco, On Wed, Oct 26, 2022 at 6:35 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > On 22-10-26, Lad, Prabhakar wrote: > > Hi Marco, > > > > Thank you for the review. > > > > On Wed, Oct 26, 2022 at 6:17 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > > > > > Hi Prabhakar, > > > > > > thanks for the patch, please see below my comments. > > > > > > On 22-10-26, Prabhakar wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > > > Make sure we dont stop the code flow in case of errors while stopping > > > > the stream and return the error code of the first error case if any. > > > > > > > > v4l2-core takes care of warning the user so no need to add a warning > > > > message in the driver. > > > > > > > > Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > --- > > > > v2->v3 > > > > * Now propagating the first error code in case of failure. > > > > > > > > v1->v2 > > > > * New patch > > > > --- > > > > drivers/media/i2c/ov5645.c | 11 ++++++++--- > > > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > > > > index eea3067ddc8b..5702a55607fc 100644 > > > > --- a/drivers/media/i2c/ov5645.c > > > > +++ b/drivers/media/i2c/ov5645.c > > > > @@ -996,17 +996,22 @@ static int ov5645_s_stream(struct v4l2_subdev *subdev, int enable) > > > > if (ret < 0) > > > > goto err_rpm_put; > > > > } else { > > > > + int stream_off_ret = 0; > > > > + > > > > ret = ov5645_write_reg(ov5645, OV5645_IO_MIPI_CTRL00, 0x40); > > > > > > If this write failed.. > > > > > > > if (ret < 0) > > > > - return ret; > > > > + stream_off_ret = ret; > > > > > > > > ret = ov5645_write_reg(ov5645, OV5645_SYSTEM_CTRL0, > > > > OV5645_SYSTEM_CTRL0_STOP); > > > > > > why should this write be successful? > > > > > Indeed that will fail unless I have a lucky day ;-) > > > > But it seemed to be an overkill for adding an additional check to see > > if the previous write succeeded. Do you think this will create an > > issue? > > Why not just say? > > ret = ov5645_write_reg(); > if (ret < 0) > goto out; > > ... > > out: > > dev_pm_xxx(); > > return ret; > Thanks for the suggestion, I will rework this in the next version. Cheers, Prabhakar
Hi Prabhakar, Thanks for the update. On Wed, Oct 26, 2022 at 02:06:55PM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Switch to using runtime PM for power management. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > v2->v3 > * Jumped to err_pm_runtime label in case of sd register failure > * Now calling pm_runtime_mark_last_busy() before pm_runtime_put_autosuspend() > call > * Now calling pm_runtime_put_sync() in case s_stream(1) fails > * In s_stream(0) no calling pm_runtime_mark_last_busy() and > pm_runtime_put_autosuspend() > * Included RB tag from Laurent. > > v1->v2 > * Moved pm_runtime_*_autosuspend() calls after registering the subdev. > --- > drivers/media/i2c/Kconfig | 2 +- > drivers/media/i2c/ov5645.c | 141 +++++++++++++++++++------------------ > 2 files changed, 73 insertions(+), 70 deletions(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 7806d4b81716..c0edd1017fe8 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -459,7 +459,7 @@ config VIDEO_OV5640 > config VIDEO_OV5645 > tristate "OmniVision OV5645 sensor support" > depends on OF > - depends on I2C && VIDEO_DEV > + depends on I2C && PM && VIDEO_DEV I think you can drop the PM dependency --- the driver will work fine without CONFIG_PM. Although one could question why do we have CONFIG_PM. Some systems won't boot without it and who would want to consume more power than necessary? Could this be removed altogether? Or perhaps we could add CONFIG_PM dependency to V4L2 and DVB? :-) Certainly out of scope of this set though.
Hello, On Wed, Oct 26, 2022 at 02:06:49PM +0100, Prabhakar wrote: > ARM: dts: imx6qdl-pico: Drop clock-names property > ARM: dts: imx6qdl-wandboard: Drop clock-names property > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-names > property Are Freescale/Renesas arch maintainers fine with me taking these patches or should they be merged through another tree? Thanks.
Hi Sakari, On Thu, Oct 27, 2022 at 10:22 AM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Prabhakar, > > Thanks for the update. > > On Wed, Oct 26, 2022 at 02:06:55PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Switch to using runtime PM for power management. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > v2->v3 > > * Jumped to err_pm_runtime label in case of sd register failure > > * Now calling pm_runtime_mark_last_busy() before pm_runtime_put_autosuspend() > > call > > * Now calling pm_runtime_put_sync() in case s_stream(1) fails > > * In s_stream(0) no calling pm_runtime_mark_last_busy() and > > pm_runtime_put_autosuspend() > > * Included RB tag from Laurent. > > > > v1->v2 > > * Moved pm_runtime_*_autosuspend() calls after registering the subdev. > > --- > > drivers/media/i2c/Kconfig | 2 +- > > drivers/media/i2c/ov5645.c | 141 +++++++++++++++++++------------------ > > 2 files changed, 73 insertions(+), 70 deletions(-) > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 7806d4b81716..c0edd1017fe8 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -459,7 +459,7 @@ config VIDEO_OV5640 > > config VIDEO_OV5645 > > tristate "OmniVision OV5645 sensor support" > > depends on OF > > - depends on I2C && VIDEO_DEV > > + depends on I2C && PM && VIDEO_DEV > > I think you can drop the PM dependency --- the driver will work fine > without CONFIG_PM. > Agreed, I'll send a new version dropping this and fixing the comments on patch #5 and patch #8. > Although one could question why do we have CONFIG_PM. Some systems won't > boot without it and who would want to consume more power than necessary? > > Could this be removed altogether? Or perhaps we could add CONFIG_PM > dependency to V4L2 and DVB? :-) > Or rather this option should be selected by the platform itself rather than subsystem? Cheers, Prabhakar
On Wed, Oct 26, 2022 at 3:07 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Now that the driver has been updated to drop fetching the clk reference by > name we no longer need the clock-names property in the ov5645 sensor node. > > This is in preparation for removal for clock-names property from the DT > binding. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v3 > * New patch Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Oct 27, 2022 at 09:32:20AM +0000, Sakari Ailus wrote: > Hello, > > On Wed, Oct 26, 2022 at 02:06:49PM +0100, Prabhakar wrote: > > ARM: dts: imx6qdl-pico: Drop clock-names property > > ARM: dts: imx6qdl-wandboard: Drop clock-names property > > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-names > > property > > Are Freescale/Renesas arch maintainers fine with me taking these patches > or should they be merged through another tree? Go ahead to take i.MX DTS patches: Acked-by: Shawn Guo <shawnguo@kernel.org>
On Sat, Oct 29, 2022 at 08:54:12PM +0800, Shawn Guo wrote: > On Thu, Oct 27, 2022 at 09:32:20AM +0000, Sakari Ailus wrote: > > Hello, > > > > On Wed, Oct 26, 2022 at 02:06:49PM +0100, Prabhakar wrote: > > > ARM: dts: imx6qdl-pico: Drop clock-names property > > > ARM: dts: imx6qdl-wandboard: Drop clock-names property > > > arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-names > > > property > > > > Are Freescale/Renesas arch maintainers fine with me taking these patches > > or should they be merged through another tree? > > Go ahead to take i.MX DTS patches: > > Acked-by: Shawn Guo <shawnguo@kernel.org> Thanks, Shawn and Geert!
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi All, The main aim of this series is to add Runtime PM support to the sensor driver alongside some cleanups and fixes. v2 -> v3 - Included patch#1 [2] as part of this series - Patched all in-tree DTS for dropping the clock preoperty to avoid dt warnings - Fixed review comments pointed by Sakari and Laurent for the Runtime PM patch - Now sending the error code of first error while stream off. - Included RB tags from Laurent v1-> v2 - patch #1 is infact a v3 [1] no changes - patch #2 fixed review comments pointed by Sakari - patch #3 [0] no changes - patches #4 and #5 are new [0] https://patchwork.linuxtv.org/project/linux-media/patch/20220927202005.750621-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ [1] https://patchwork.linuxtv.org/project/linux-media/patch/20220919153540.178732-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ [2] https://patchwork.kernel.org/project/linux-media/patch/20220919143350.176746-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Lad Prabhakar (9): media: i2c: ov5645: Drop fetching the clk reference by name ARM: dts: imx6qdl-pico: Drop clock-names property ARM: dts: imx6qdl-wandboard: Drop clock-names property arm64: dts: renesas: aistarvision-mipi-adapter-2.1: Drop clock-names property media: dt-bindings: ov5645: Convert OV5645 binding to a schema media: i2c: ov5645: Use runtime PM media: i2c: ov5645: Drop empty comment media: i2c: ov5645: Don't return early on failures for s_stream(0) media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev .../devicetree/bindings/media/i2c/ov5645.txt | 54 ------ .../bindings/media/i2c/ovti,ov5645.yaml | 104 ++++++++++++ arch/arm/boot/dts/imx6qdl-pico.dtsi | 1 - arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 1 - .../aistarvision-mipi-adapter-2.1.dtsi | 1 - drivers/media/i2c/Kconfig | 2 +- drivers/media/i2c/ov5645.c | 157 +++++++++--------- 7 files changed, 186 insertions(+), 134 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5645.txt create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml