Message ID | 20220927014846.32892-1-mailingradian@gmail.com |
---|---|
Headers | show |
Series | SDM670 GPI DMA support | expand |
On 27/09/2022 03:48, Richard Acayan wrote: > The dt schema for gpi-dma has been updated with a new fallback > compatible string. Add the compatible strings to existing device trees. > > Signed-off-by: Richard Acayan <mailingradian@gmail.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 27/09/2022 03:48, Richard Acayan wrote: > The drivers are transitioning from matching against lists of specific > compatible strings to matching against smaller lists of more generic > compatible strings. Continue the transition in the GPI DMA driver. > > Signed-off-by: Richard Acayan <mailingradian@gmail.com> > --- > drivers/dma/qcom/gpi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index 89839864b4ec..e5f37d61f30a 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -2289,8 +2289,6 @@ static const struct of_device_id gpi_of_match[] = { > { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, > { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, > { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, > - { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 }, > - { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 }, You cannot remove them that fast - it would be an ABI break. Just add a comment that these are deprecated and devices should match with a fallback compatible. Best regards, Krzysztof
On 26-09-22, 21:48, Richard Acayan wrote: > The drivers are transitioning from matching against lists of specific > compatible strings to matching against smaller lists of more generic > compatible strings. Continue the transition in the GPI DMA driver. > > Signed-off-by: Richard Acayan <mailingradian@gmail.com> > --- > drivers/dma/qcom/gpi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index 89839864b4ec..e5f37d61f30a 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -2289,8 +2289,6 @@ static const struct of_device_id gpi_of_match[] = { > { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, > { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, > { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, > - { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 }, > - { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 }, We cant do this without breaking stuff... There are DTs which have this id! > { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 }, > { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 }, > { }, > -- > 2.37.3