diff mbox series

[ovs-dev] controller: Fix assigment typo

Message ID 20220810073231.82480-1-amusil@redhat.com
State Accepted
Headers show
Series [ovs-dev] controller: Fix assigment typo | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Ales Musil Aug. 10, 2022, 7:32 a.m. UTC
Signed-off-by: Ales Musil <amusil@redhat.com>
---
 controller/chassis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dumitru Ceara Aug. 10, 2022, 8:09 a.m. UTC | #1
On 8/10/22 09:32, Ales Musil wrote:
> Signed-off-by: Ales Musil <amusil@redhat.com>
> ---
>  controller/chassis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/controller/chassis.c b/controller/chassis.c
> index 92850fcc1..ba6377ac2 100644
> --- a/controller/chassis.c
> +++ b/controller/chassis.c
> @@ -581,7 +581,7 @@ chassis_get_record(struct ovsdb_idl_txn *ovnsb_idl_txn,
>                     const struct sbrec_chassis **chassis_rec)
>  {
>      const struct sbrec_chassis *chassis =
> -        chassis = chassis_lookup_by_name(sbrec_chassis_by_name, chassis_id);
> +        chassis_lookup_by_name(sbrec_chassis_by_name, chassis_id);

Oops. :)

Acked-by: Dumitru Ceara <dceara@redhat.com>

>  
>      if (!chassis && ovnsb_idl_txn) {
>          /* Create the chassis record. */
Numan Siddique Aug. 15, 2022, 3:46 a.m. UTC | #2
On Wed, Aug 10, 2022 at 6:10 PM Dumitru Ceara <dceara@redhat.com> wrote:
>
> On 8/10/22 09:32, Ales Musil wrote:
> > Signed-off-by: Ales Musil <amusil@redhat.com>
> > ---
> >  controller/chassis.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/controller/chassis.c b/controller/chassis.c
> > index 92850fcc1..ba6377ac2 100644
> > --- a/controller/chassis.c
> > +++ b/controller/chassis.c
> > @@ -581,7 +581,7 @@ chassis_get_record(struct ovsdb_idl_txn *ovnsb_idl_txn,
> >                     const struct sbrec_chassis **chassis_rec)
> >  {
> >      const struct sbrec_chassis *chassis =
> > -        chassis = chassis_lookup_by_name(sbrec_chassis_by_name, chassis_id);
> > +        chassis_lookup_by_name(sbrec_chassis_by_name, chassis_id);
>
> Oops. :)
>
> Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks.  Applied to main.

Numan

>
> >
> >      if (!chassis && ovnsb_idl_txn) {
> >          /* Create the chassis record. */
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/controller/chassis.c b/controller/chassis.c
index 92850fcc1..ba6377ac2 100644
--- a/controller/chassis.c
+++ b/controller/chassis.c
@@ -581,7 +581,7 @@  chassis_get_record(struct ovsdb_idl_txn *ovnsb_idl_txn,
                    const struct sbrec_chassis **chassis_rec)
 {
     const struct sbrec_chassis *chassis =
-        chassis = chassis_lookup_by_name(sbrec_chassis_by_name, chassis_id);
+        chassis_lookup_by_name(sbrec_chassis_by_name, chassis_id);
 
     if (!chassis && ovnsb_idl_txn) {
         /* Create the chassis record. */