| Message ID | 20220513133520.3945820-5-michael@walle.cc |
|---|---|
| State | Superseded |
| Delegated to: | Pratyush Yadav |
| Headers | show |
| Series | mtd: spi-nor: generic flash driver | expand |
On 5/13/2022 10:35 PM, Michael Walle wrote: > sfdp.h should only contain constants related to the JEDEC SFDP > specification(s). > > Signed-off-by: Michael Walle <michael@walle.cc> I think sfdp.h can contain declaration for a function implemented in sfdp.c, but not a strong preference. Reviewed-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com> Thanks, Takahiro
diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 61886868cd02..3a19b8092ab8 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -694,6 +694,8 @@ int spi_nor_controller_ops_read_reg(struct spi_nor *nor, u8 opcode, int spi_nor_controller_ops_write_reg(struct spi_nor *nor, u8 opcode, const u8 *buf, size_t len); +int spi_nor_parse_sfdp(struct spi_nor *nor); + static inline struct spi_nor *mtd_to_spi_nor(struct mtd_info *mtd) { return container_of(mtd, struct spi_nor, mtd); diff --git a/drivers/mtd/spi-nor/sfdp.h b/drivers/mtd/spi-nor/sfdp.h index bbf80d2990ab..c1969f0a2f46 100644 --- a/drivers/mtd/spi-nor/sfdp.h +++ b/drivers/mtd/spi-nor/sfdp.h @@ -107,6 +107,4 @@ struct sfdp_parameter_header { u8 id_msb; }; -int spi_nor_parse_sfdp(struct spi_nor *nor); - #endif /* __LINUX_MTD_SFDP_H */
sfdp.h should only contain constants related to the JEDEC SFDP specification(s). Signed-off-by: Michael Walle <michael@walle.cc> --- drivers/mtd/spi-nor/core.h | 2 ++ drivers/mtd/spi-nor/sfdp.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)