diff mbox series

boot/arm-trusted-firmware: remove extra ending parentheses

Message ID 20220621135833.1148493-1-kory.maincent@bootlin.com
State Accepted
Headers show
Series boot/arm-trusted-firmware: remove extra ending parentheses | expand

Commit Message

Kory Maincent June 21, 2022, 1:58 p.m. UTC 
From: Kory Maincent <kory.maincent@bootlin.com>

There are two extra ending parentheses to be removed.
They are present from the beggining of TF-A package. I suppose extra
ending parenthese does not bring any issue, but it seems relevant to
remove them.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Arnout Vandecappelle July 23, 2022, 7:38 p.m. UTC | #1 
On 21/06/2022 15:58, Kory Maincent via buildroot wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
> 
> There are two extra ending parentheses to be removed.
> They are present from the beggining of TF-A package. I suppose extra
> ending parenthese does not bring any issue, but it seems relevant to
> remove them.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> index 998de4b814..965b1a2eb5 100644
> --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> @@ -191,8 +191,8 @@ endef
>   ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE)$(BR_BUILDING),yy)
>   
>   ifeq ($(ARM_TRUSTED_FIRMWARE_VERSION),custom)
> -ifeq ($(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION))),)
> -$(error No tarball location specified. Please check BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION))
> +ifeq ($(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION)),)
> +$(error No tarball location specified. Please check BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION)
>   endif
>   endif
>
Peter Korsgaard Aug. 16, 2022, 9:55 a.m. UTC | #2 
>>>>> "Kory" == Kory Maincent via buildroot <buildroot@buildroot.org> writes:

 > From: Kory Maincent <kory.maincent@bootlin.com>
 > There are two extra ending parentheses to be removed.
 > They are present from the beggining of TF-A package. I suppose extra
 > ending parenthese does not bring any issue, but it seems relevant to
 > remove them.

 > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Committed to 2022.05.x and 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
index 998de4b814..965b1a2eb5 100644
--- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
+++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
@@ -191,8 +191,8 @@  endef
 ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE)$(BR_BUILDING),yy)
 
 ifeq ($(ARM_TRUSTED_FIRMWARE_VERSION),custom)
-ifeq ($(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION))),)
-$(error No tarball location specified. Please check BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION))
+ifeq ($(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION)),)
+$(error No tarball location specified. Please check BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION)
 endif
 endif