diff mbox series

[1/1] package/libabseil-cpp: drop unrecognized option

Message ID 20220611130631.359062-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/libabseil-cpp: drop unrecognized option | expand

Commit Message

Fabrice Fontaine June 11, 2022, 1:06 p.m. UTC
ABSL_RUN_TESTS has been replaced by the standard BUILD_TESTING option
(which is already passed by cmake infrastructure) since version
20210324.0 and
https://github.com/abseil/abseil-cpp/commit/a50ae369a30f99f79d7559002aba3413dac1bd48

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libabseil-cpp/libabseil-cpp.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Arnout Vandecappelle June 14, 2022, 6:45 p.m. UTC | #1
On 11/06/2022 15:06, Fabrice Fontaine wrote:
> ABSL_RUN_TESTS has been replaced by the standard BUILD_TESTING option
> (which is already passed by cmake infrastructure) since version
> 20210324.0 and
> https://github.com/abseil/abseil-cpp/commit/a50ae369a30f99f79d7559002aba3413dac1bd48
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/libabseil-cpp/libabseil-cpp.mk | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/package/libabseil-cpp/libabseil-cpp.mk b/package/libabseil-cpp/libabseil-cpp.mk
> index 738cd03c39..7c6bda7659 100644
> --- a/package/libabseil-cpp/libabseil-cpp.mk
> +++ b/package/libabseil-cpp/libabseil-cpp.mk
> @@ -13,14 +13,12 @@ LIBABSEIL_CPP_INSTALL_STAGING = YES
>   LIBABSEIL_CPP_CONF_OPTS = \
>   	-DCMAKE_CXX_STANDARD=11 \
>   	-DABSL_ENABLE_INSTALL=ON \
> -	-DABSL_USE_GOOGLETEST_HEAD=OFF \
> -	-DABSL_RUN_TESTS=OFF
> +	-DABSL_USE_GOOGLETEST_HEAD=OFF
>   
>   HOST_LIBABSEIL_CPP_CONF_OPTS = \
>   	-DCMAKE_CXX_STANDARD=11 \
>   	-DABSL_ENABLE_INSTALL=ON \
> -	-DABSL_USE_GOOGLETEST_HEAD=OFF \
> -	-DABSL_RUN_TESTS=OFF
> +	-DABSL_USE_GOOGLETEST_HEAD=OFF
>   
>   $(eval $(cmake-package))
>   $(eval $(host-cmake-package))
diff mbox series

Patch

diff --git a/package/libabseil-cpp/libabseil-cpp.mk b/package/libabseil-cpp/libabseil-cpp.mk
index 738cd03c39..7c6bda7659 100644
--- a/package/libabseil-cpp/libabseil-cpp.mk
+++ b/package/libabseil-cpp/libabseil-cpp.mk
@@ -13,14 +13,12 @@  LIBABSEIL_CPP_INSTALL_STAGING = YES
 LIBABSEIL_CPP_CONF_OPTS = \
 	-DCMAKE_CXX_STANDARD=11 \
 	-DABSL_ENABLE_INSTALL=ON \
-	-DABSL_USE_GOOGLETEST_HEAD=OFF \
-	-DABSL_RUN_TESTS=OFF
+	-DABSL_USE_GOOGLETEST_HEAD=OFF
 
 HOST_LIBABSEIL_CPP_CONF_OPTS = \
 	-DCMAKE_CXX_STANDARD=11 \
 	-DABSL_ENABLE_INSTALL=ON \
-	-DABSL_USE_GOOGLETEST_HEAD=OFF \
-	-DABSL_RUN_TESTS=OFF
+	-DABSL_USE_GOOGLETEST_HEAD=OFF
 
 $(eval $(cmake-package))
 $(eval $(host-cmake-package))