| Message ID | 1320864823-5015-1-git-send-email-olof@lixom.net |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
On 11/09/2011 12:53 PM, Olof Johansson wrote: > fae2b89ab1 (ARM: l2x0: add empty l2x0_of_init) adds a static inline > function that returns -ENODEV, but at least on tegra cache-l2x0.h is > included without errno.h being pulled in first, resulting in compile > errors if OF isn't enabled: > > In file included from arch/arm/mach-tegra/common.c:26: > arch/arm/include/asm/hardware/cache-l2x0.h: In function 'l2x0_of_init': > arch/arm/include/asm/hardware/cache-l2x0.h:110: error: 'ENODEV' undeclared (first use in this function) > arch/arm/include/asm/hardware/cache-l2x0.h:110: error: (Each undeclared identifier is reported only once > arch/arm/include/asm/hardware/cache-l2x0.h:110: error: for each function it appears in.) > > Add errno.h to the include file to make it self-contained. > > Signed-off-by: Olof Johansson <olof@lixom.net> > Cc: Rob Herring <rob.herring@calxeda.com> Sigh... I guess the platforms I built happened to include errno.h first. Acked-by: Rob Herring <rob.herring@calxeda.com> > --- > arch/arm/include/asm/hardware/cache-l2x0.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h > index 1db1143..7df239b 100644 > --- a/arch/arm/include/asm/hardware/cache-l2x0.h > +++ b/arch/arm/include/asm/hardware/cache-l2x0.h > @@ -20,6 +20,8 @@ > #ifndef __ASM_ARM_HARDWARE_L2X0_H > #define __ASM_ARM_HARDWARE_L2X0_H > > +#include <linux/errno.h> > + > #define L2X0_CACHE_ID 0x000 > #define L2X0_CACHE_TYPE 0x004 > #define L2X0_CTRL 0x100 -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2011/11/10 Olof Johansson <olof@lixom.net>: > fae2b89ab1 (ARM: l2x0: add empty l2x0_of_init) adds a static inline > function that returns -ENODEV, but at least on tegra cache-l2x0.h is > included without errno.h being pulled in first, resulting in compile > errors if OF isn't enabled: > > In file included from arch/arm/mach-tegra/common.c:26: > arch/arm/include/asm/hardware/cache-l2x0.h: In function 'l2x0_of_init': > arch/arm/include/asm/hardware/cache-l2x0.h:110: error: 'ENODEV' undeclared (first use in this function) > arch/arm/include/asm/hardware/cache-l2x0.h:110: error: (Each undeclared identifier is reported only once > arch/arm/include/asm/hardware/cache-l2x0.h:110: error: for each function it appears in.) > > Add errno.h to the include file to make it self-contained. > > Signed-off-by: Olof Johansson <olof@lixom.net> > Cc: Rob Herring <rob.herring@calxeda.com> Acked-by: Barry Song <baohua.song@csr.com> > --- > arch/arm/include/asm/hardware/cache-l2x0.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h > index 1db1143..7df239b 100644 > --- a/arch/arm/include/asm/hardware/cache-l2x0.h > +++ b/arch/arm/include/asm/hardware/cache-l2x0.h > @@ -20,6 +20,8 @@ > #ifndef __ASM_ARM_HARDWARE_L2X0_H > #define __ASM_ARM_HARDWARE_L2X0_H > > +#include <linux/errno.h> > + > #define L2X0_CACHE_ID 0x000 > #define L2X0_CACHE_TYPE 0x004 > #define L2X0_CTRL 0x100 > -- > 1.7.5.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h index 1db1143..7df239b 100644 --- a/arch/arm/include/asm/hardware/cache-l2x0.h +++ b/arch/arm/include/asm/hardware/cache-l2x0.h @@ -20,6 +20,8 @@ #ifndef __ASM_ARM_HARDWARE_L2X0_H #define __ASM_ARM_HARDWARE_L2X0_H +#include <linux/errno.h> + #define L2X0_CACHE_ID 0x000 #define L2X0_CACHE_TYPE 0x004 #define L2X0_CTRL 0x100
fae2b89ab1 (ARM: l2x0: add empty l2x0_of_init) adds a static inline function that returns -ENODEV, but at least on tegra cache-l2x0.h is included without errno.h being pulled in first, resulting in compile errors if OF isn't enabled: In file included from arch/arm/mach-tegra/common.c:26: arch/arm/include/asm/hardware/cache-l2x0.h: In function 'l2x0_of_init': arch/arm/include/asm/hardware/cache-l2x0.h:110: error: 'ENODEV' undeclared (first use in this function) arch/arm/include/asm/hardware/cache-l2x0.h:110: error: (Each undeclared identifier is reported only once arch/arm/include/asm/hardware/cache-l2x0.h:110: error: for each function it appears in.) Add errno.h to the include file to make it self-contained. Signed-off-by: Olof Johansson <olof@lixom.net> Cc: Rob Herring <rob.herring@calxeda.com> --- arch/arm/include/asm/hardware/cache-l2x0.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)