Message ID | DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM |
---|---|
State | Accepted |
Headers | show |
Series | [1/1] package/dhcp: build internal bind tool gen for host (not target) | expand |
On Wed, Apr 06, 2022 at 02:52:25PM +0000, Tim Hammer wrote: > Building gen tool of the internal (bundled) bind needs to be for host, not target > Switch to use internal build in commit 0c8dd6ebd656e06cf99a63eb93343715f4853503 > overlooked this. > Much gratitude to Fabrice Fontaine for all the help (and patience) getting me and this patch to this point. After this is processed and merged to master, can we get both Fabrice's initial patch (commit 0c8dd6ebd656e06cf99a63eb93343715f4853503) and this one merged to 2022.02.x? Thanks! .Tim Tim D. Hammer tim.hammer@orolia.com > Building dns library in /home/autobuild/autobuild/instance-13/output-1/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns > /bin/sh: line 1: ./gen: cannot execute binary file: Exec format error > > Fixes: > - http://autobuild.buildroot.org/results/da6fd904d1a6bae73b6ff89dd008de1f459bb7d7/ > --- > package/dhcp/dhcp.mk | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk > index f1e3c22f1c..2faea48c46 100644 > --- a/package/dhcp/dhcp.mk > +++ b/package/dhcp/dhcp.mk > @@ -23,7 +23,11 @@ DHCP_CONF_ENV = \ > CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \ > -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \ > CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1' > -DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)' > + > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(HOSTCC)' > +DHCP_BIND_EXTRA_CONFIG += BUILD_CFLAGS='$(HOST_CFLAGS)' > +DHCP_BIND_EXTRA_CONFIG += BUILD_CPPFLAGS='$(HOST_CPPFLAGS)' > +DHCP_BIND_EXTRA_CONFIG += BUILD_LDFLAGS='$(HOST_LDFLAGS)' > > DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk > > -- > 2.25.1 > > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
On 06/04/2022 16:52, Tim Hammer wrote: > Building gen tool of the internal (bundled) bind needs to be for host, not target > Switch to use internal build in commit 0c8dd6ebd656e06cf99a63eb93343715f4853503 > overlooked this. > > Building dns library in /home/autobuild/autobuild/instance-13/output-1/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns > /bin/sh: line 1: ./gen: cannot execute binary file: Exec format error > > Fixes: > - http://autobuild.buildroot.org/results/da6fd904d1a6bae73b6ff89dd008de1f459bb7d7/ Your signed-off-by is missing here. I took the liberty of adding it and applied to master, thanks. Regards, Arnout > --- > package/dhcp/dhcp.mk | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk > index f1e3c22f1c..2faea48c46 100644 > --- a/package/dhcp/dhcp.mk > +++ b/package/dhcp/dhcp.mk > @@ -23,7 +23,11 @@ DHCP_CONF_ENV = \ > CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \ > -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \ > CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1' > -DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)' > + > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(HOSTCC)' > +DHCP_BIND_EXTRA_CONFIG += BUILD_CFLAGS='$(HOST_CFLAGS)' > +DHCP_BIND_EXTRA_CONFIG += BUILD_CPPFLAGS='$(HOST_CPPFLAGS)' > +DHCP_BIND_EXTRA_CONFIG += BUILD_LDFLAGS='$(HOST_LDFLAGS)' > > DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk >
>>>>> "Tim" == Tim Hammer <Tim.Hammer@orolia.com> writes: > Building gen tool of the internal (bundled) bind needs to be for host, not target > Switch to use internal build in commit 0c8dd6ebd656e06cf99a63eb93343715f4853503 > overlooked this. > Building dns library in /home/autobuild/autobuild/instance-13/output-1/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns > /bin/sh: line 1: ./gen: cannot execute binary file: Exec format error > Fixes: > - http://autobuild.buildroot.org/results/da6fd904d1a6bae73b6ff89dd008de1f459bb7d7/ Committed to 2022.02.x, thanks.
diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk index f1e3c22f1c..2faea48c46 100644 --- a/package/dhcp/dhcp.mk +++ b/package/dhcp/dhcp.mk @@ -23,7 +23,11 @@ DHCP_CONF_ENV = \ CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \ -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \ CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1' -DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)' + +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(HOSTCC)' +DHCP_BIND_EXTRA_CONFIG += BUILD_CFLAGS='$(HOST_CFLAGS)' +DHCP_BIND_EXTRA_CONFIG += BUILD_CPPFLAGS='$(HOST_CPPFLAGS)' +DHCP_BIND_EXTRA_CONFIG += BUILD_LDFLAGS='$(HOST_LDFLAGS)' DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk