| Message ID | 1633614519-26680-3-git-send-email-srivasam@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add pin control support for lpass sc7280 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 10 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
Quoting Srinivasa Rao Mandadapu (2021-10-07 06:48:38) > Add device tree binding compatible name for Qualcomm SC7280 LPASS LPI pinctrl driver. > > Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- > Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > index e47ebf9..578b283 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > @@ -16,7 +16,9 @@ description: | > > properties: > compatible: > - const: qcom,sm8250-lpass-lpi-pinctrl > + enum: > + - qcom,sc7280-lpass-lpi-pinctrl > + - qcom,sm8250-lpass-lpi-pinctrl I suspect we need to split the binding because the function list needs to change. Can you make a whole new file that's probably largely a copy of this file and/or extract the common bits into a meta schema and include that in both the files? Then the function list can be different and the clock property can be omitted in the sc7280 file.
On Thu, 07 Oct 2021 19:18:38 +0530, Srinivasa Rao Mandadapu wrote: > Add device tree binding compatible name for Qualcomm SC7280 LPASS LPI pinctrl driver. > > Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- > Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1537726 pinctrl@33c0000: dmic01-active-pins: 'clk', 'data' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: dmic01-active-pins: 'function' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: dmic01-active-pins: 'pins' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: dmic01-sleep-pins: 'clk', 'data' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: dmic01-sleep-pins: 'function' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: dmic01-sleep-pins: 'pins' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: wsa-swr-active-pins: 'clk', 'data' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: wsa-swr-active-pins: 'function' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: wsa-swr-active-pins: 'pins' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: wsa-swr-sleep-pins: 'clk', 'data' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: wsa-swr-sleep-pins: 'function' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml pinctrl@33c0000: wsa-swr-sleep-pins: 'pins' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml
On 10/7/2021 11:29 PM, Stephen Boyd wrote: > Quoting Srinivasa Rao Mandadapu (2021-10-07 06:48:38) >> Add device tree binding compatible name for Qualcomm SC7280 LPASS LPI pinctrl driver. >> >> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >> --- >> Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml >> index e47ebf9..578b283 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml >> @@ -16,7 +16,9 @@ description: | >> >> properties: >> compatible: >> - const: qcom,sm8250-lpass-lpi-pinctrl >> + enum: >> + - qcom,sc7280-lpass-lpi-pinctrl >> + - qcom,sm8250-lpass-lpi-pinctrl > I suspect we need to split the binding because the function list needs > to change. Can you make a whole new file that's probably largely a copy > of this file and/or extract the common bits into a meta schema and > include that in both the files? Then the function list can be different > and the clock property can be omitted in the sc7280 file. As most are common functions and fixed number of LPASS Lpi pin configuration across platforms, Only diff is ADSP bypass platforms 2 clocks are optional. Otherwise clock design also same for SC7280 and SM8250 based architecture. So I feel Keeping common file is better for now.
Quoting Srinivasa Rao Mandadapu (2021-10-27 00:47:52) > > On 10/7/2021 11:29 PM, Stephen Boyd wrote: > > Quoting Srinivasa Rao Mandadapu (2021-10-07 06:48:38) > >> Add device tree binding compatible name for Qualcomm SC7280 LPASS LPI pinctrl driver. > >> > >> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > >> --- > >> Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > >> index e47ebf9..578b283 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > >> @@ -16,7 +16,9 @@ description: | > >> > >> properties: > >> compatible: > >> - const: qcom,sm8250-lpass-lpi-pinctrl > >> + enum: > >> + - qcom,sc7280-lpass-lpi-pinctrl > >> + - qcom,sm8250-lpass-lpi-pinctrl > > I suspect we need to split the binding because the function list needs > > to change. Can you make a whole new file that's probably largely a copy > > of this file and/or extract the common bits into a meta schema and > > include that in both the files? Then the function list can be different > > and the clock property can be omitted in the sc7280 file. > > As most are common functions and fixed number of LPASS Lpi pin > configuration across platforms, > > Only diff is ADSP bypass platforms 2 clocks are optional. Otherwise > clock design also same for SC7280 and SM8250 based architecture. > > So I feel Keeping common file is better for now. I don't agree. We want to be very strict about what is exposed. It needs to match exactly what is supported on the SoC, not be a superset of it.
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml index e47ebf9..578b283 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml @@ -16,7 +16,9 @@ description: | properties: compatible: - const: qcom,sm8250-lpass-lpi-pinctrl + enum: + - qcom,sc7280-lpass-lpi-pinctrl + - qcom,sm8250-lpass-lpi-pinctrl reg: minItems: 2