| Message ID | 20211019072552.428270-1-thuth@redhat.com |
|---|---|
| State | Accepted, archived |
| Commit | 0c83c8ac407e4d889c4c0541070c191a3d977299 |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | doc: Remove obsolete README.440-DDR-performance file | expand |
On 19.10.21 09:25, Thomas Huth wrote: > The PPC 440 support has been removed in commit 98f705c9ce > ("powerpc: remove 4xx support") already, so this file is > certainly not required anymore. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > doc/README.440-DDR-performance | 90 ---------------------------------- > 1 file changed, 90 deletions(-) > delete mode 100644 doc/README.440-DDR-performance > > diff --git a/doc/README.440-DDR-performance b/doc/README.440-DDR-performance > deleted file mode 100644 > index 66b97bc9b5..0000000000 > --- a/doc/README.440-DDR-performance > +++ /dev/null > @@ -1,90 +0,0 @@ > -AMCC suggested to set the PMU bit to 0 for best performace on the > -PPC440 DDR controller. The 440er common DDR setup files (sdram.c & > -spd_sdram.c) are changed accordingly. So all 440er boards using > -these setup routines will automatically receive this performance > -increase. > - > -Please see below some benchmarks done by AMCC to demonstrate this > -performance changes: > - > - > ----------------------------------------- > -SDRAM0_CFG0[PMU] = 1 (U-Boot default for Bamboo, Yosemite and Yellowstone) > ----------------------------------------- > -Stream benchmark results > -------------------------------------------------------------- > -This system uses 8 bytes per DOUBLE PRECISION word. > -------------------------------------------------------------- > -Array size = 2000000, Offset = 0 > -Total memory required = 45.8 MB. > -Each test is run 10 times, but only > -the *best* time for each is used. > -------------------------------------------------------------- > -Your clock granularity/precision appears to be 1 microseconds. > -Each test below will take on the order of 112345 microseconds. > - (= 112345 clock ticks) > -Increase the size of the arrays if this shows that you are not getting > -at least 20 clock ticks per test. > -------------------------------------------------------------- > -WARNING -- The above is only a rough guideline. > -For best results, please be sure you know the precision of your system > -timer. > -------------------------------------------------------------- > -Function Rate (MB/s) RMS time Min time Max time > -Copy: 256.7683 0.1248 0.1246 0.1250 > -Scale: 246.0157 0.1302 0.1301 0.1302 > -Add: 255.0316 0.1883 0.1882 0.1885 > -Triad: 253.1245 0.1897 0.1896 0.1899 > - > - > -TTCP Benchmark Results > -ttcp-t: socket > -ttcp-t: connect > -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> > -localhost > -ttcp-t: 16777216 bytes in 0.28 real seconds = 454.29 Mbit/sec +++ > -ttcp-t: 2048 I/O calls, msec/call = 0.14, calls/sec = 7268.57 > -ttcp-t: 0.0user 0.1sys 0:00real 60% 0i+0d 0maxrss 0+2pf 3+1506csw > - > ----------------------------------------- > -SDRAM0_CFG0[PMU] = 0 (Suggested modification) > -Setting PMU = 0 provides a noticeable performance improvement *2% to > -5% improvement in memory performance. > -*Improves the Mbit/sec for TTCP benchmark by almost 76%. > ----------------------------------------- > -Stream benchmark results > -------------------------------------------------------------- > -This system uses 8 bytes per DOUBLE PRECISION word. > -------------------------------------------------------------- > -Array size = 2000000, Offset = 0 > -Total memory required = 45.8 MB. > -Each test is run 10 times, but only > -the *best* time for each is used. > -------------------------------------------------------------- > -Your clock granularity/precision appears to be 1 microseconds. > -Each test below will take on the order of 120066 microseconds. > - (= 120066 clock ticks) > -Increase the size of the arrays if this shows that you are not getting > -at least 20 clock ticks per test. > -------------------------------------------------------------- > -WARNING -- The above is only a rough guideline. > -For best results, please be sure you know the precision of your system > -timer. > -------------------------------------------------------------- > -Function Rate (MB/s) RMS time Min time Max time > -Copy: 262.5167 0.1221 0.1219 0.1223 > -Scale: 258.4856 0.1238 0.1238 0.1240 > -Add: 262.5404 0.1829 0.1828 0.1831 > -Triad: 266.8594 0.1800 0.1799 0.1802 > - > -TTCP Benchmark Results > -ttcp-t: socket > -ttcp-t: connect > -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> > -localhost > -ttcp-t: 16777216 bytes in 0.16 real seconds = 804.06 Mbit/sec +++ > -ttcp-t: 2048 I/O calls, msec/call = 0.08, calls/sec = 12864.89 > -ttcp-t: 0.0user 0.0sys 0:00real 46% 0i+0d 0maxrss 0+2pf 120+1csw > - > - > -2006-07-28, Stefan Roese <sr@denx.de> > Viele Grüße, Stefan
On 10/19/21 9:25 AM, Thomas Huth wrote: > The PPC 440 support has been removed in commit 98f705c9ce > ("powerpc: remove 4xx support") already, so this file is > certainly not required anymore. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > Reviewed-by: Stefan Roese <sr@denx.de> > --- > doc/README.440-DDR-performance | 90 ---------------------------------- Shouldn't doc/README.nand-boot-ppc440 be removed too? Best regards Heinrich > 1 file changed, 90 deletions(-) > delete mode 100644 doc/README.440-DDR-performance > > diff --git a/doc/README.440-DDR-performance b/doc/README.440-DDR-performance > deleted file mode 100644 > index 66b97bc9b5..0000000000 > --- a/doc/README.440-DDR-performance > +++ /dev/null > @@ -1,90 +0,0 @@ > -AMCC suggested to set the PMU bit to 0 for best performace on the > -PPC440 DDR controller. The 440er common DDR setup files (sdram.c & > -spd_sdram.c) are changed accordingly. So all 440er boards using > -these setup routines will automatically receive this performance > -increase. > - > -Please see below some benchmarks done by AMCC to demonstrate this > -performance changes: > - > - > ----------------------------------------- > -SDRAM0_CFG0[PMU] = 1 (U-Boot default for Bamboo, Yosemite and Yellowstone) > ----------------------------------------- > -Stream benchmark results > -------------------------------------------------------------- > -This system uses 8 bytes per DOUBLE PRECISION word. > -------------------------------------------------------------- > -Array size = 2000000, Offset = 0 > -Total memory required = 45.8 MB. > -Each test is run 10 times, but only > -the *best* time for each is used. > -------------------------------------------------------------- > -Your clock granularity/precision appears to be 1 microseconds. > -Each test below will take on the order of 112345 microseconds. > - (= 112345 clock ticks) > -Increase the size of the arrays if this shows that you are not getting > -at least 20 clock ticks per test. > -------------------------------------------------------------- > -WARNING -- The above is only a rough guideline. > -For best results, please be sure you know the precision of your system > -timer. > -------------------------------------------------------------- > -Function Rate (MB/s) RMS time Min time Max time > -Copy: 256.7683 0.1248 0.1246 0.1250 > -Scale: 246.0157 0.1302 0.1301 0.1302 > -Add: 255.0316 0.1883 0.1882 0.1885 > -Triad: 253.1245 0.1897 0.1896 0.1899 > - > - > -TTCP Benchmark Results > -ttcp-t: socket > -ttcp-t: connect > -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> > -localhost > -ttcp-t: 16777216 bytes in 0.28 real seconds = 454.29 Mbit/sec +++ > -ttcp-t: 2048 I/O calls, msec/call = 0.14, calls/sec = 7268.57 > -ttcp-t: 0.0user 0.1sys 0:00real 60% 0i+0d 0maxrss 0+2pf 3+1506csw > - > ----------------------------------------- > -SDRAM0_CFG0[PMU] = 0 (Suggested modification) > -Setting PMU = 0 provides a noticeable performance improvement *2% to > -5% improvement in memory performance. > -*Improves the Mbit/sec for TTCP benchmark by almost 76%. > ----------------------------------------- > -Stream benchmark results > -------------------------------------------------------------- > -This system uses 8 bytes per DOUBLE PRECISION word. > -------------------------------------------------------------- > -Array size = 2000000, Offset = 0 > -Total memory required = 45.8 MB. > -Each test is run 10 times, but only > -the *best* time for each is used. > -------------------------------------------------------------- > -Your clock granularity/precision appears to be 1 microseconds. > -Each test below will take on the order of 120066 microseconds. > - (= 120066 clock ticks) > -Increase the size of the arrays if this shows that you are not getting > -at least 20 clock ticks per test. > -------------------------------------------------------------- > -WARNING -- The above is only a rough guideline. > -For best results, please be sure you know the precision of your system > -timer. > -------------------------------------------------------------- > -Function Rate (MB/s) RMS time Min time Max time > -Copy: 262.5167 0.1221 0.1219 0.1223 > -Scale: 258.4856 0.1238 0.1238 0.1240 > -Add: 262.5404 0.1829 0.1828 0.1831 > -Triad: 266.8594 0.1800 0.1799 0.1802 > - > -TTCP Benchmark Results > -ttcp-t: socket > -ttcp-t: connect > -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> > -localhost > -ttcp-t: 16777216 bytes in 0.16 real seconds = 804.06 Mbit/sec +++ > -ttcp-t: 2048 I/O calls, msec/call = 0.08, calls/sec = 12864.89 > -ttcp-t: 0.0user 0.0sys 0:00real 46% 0i+0d 0maxrss 0+2pf 120+1csw > - > - > -2006-07-28, Stefan Roese <sr@denx.de> >
On 21.10.21 00:32, Heinrich Schuchardt wrote: > On 10/19/21 9:25 AM, Thomas Huth wrote: >> The PPC 440 support has been removed in commit 98f705c9ce >> ("powerpc: remove 4xx support") already, so this file is >> certainly not required anymore. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> Reviewed-by: Stefan Roese <sr@denx.de> >> --- >> doc/README.440-DDR-performance | 90 ---------------------------------- > > Shouldn't doc/README.nand-boot-ppc440 be removed too? Yes. I'll send a patch for this soonish. Thanks, Stefan > Best regards > > Heinrich > >> 1 file changed, 90 deletions(-) >> delete mode 100644 doc/README.440-DDR-performance >> >> diff --git a/doc/README.440-DDR-performance >> b/doc/README.440-DDR-performance >> deleted file mode 100644 >> index 66b97bc9b5..0000000000 >> --- a/doc/README.440-DDR-performance >> +++ /dev/null >> @@ -1,90 +0,0 @@ >> -AMCC suggested to set the PMU bit to 0 for best performace on the >> -PPC440 DDR controller. The 440er common DDR setup files (sdram.c & >> -spd_sdram.c) are changed accordingly. So all 440er boards using >> -these setup routines will automatically receive this performance >> -increase. >> - >> -Please see below some benchmarks done by AMCC to demonstrate this >> -performance changes: >> - >> - >> ----------------------------------------- >> -SDRAM0_CFG0[PMU] = 1 (U-Boot default for Bamboo, Yosemite and >> Yellowstone) >> ----------------------------------------- >> -Stream benchmark results >> -------------------------------------------------------------- >> -This system uses 8 bytes per DOUBLE PRECISION word. >> -------------------------------------------------------------- >> -Array size = 2000000, Offset = 0 >> -Total memory required = 45.8 MB. >> -Each test is run 10 times, but only >> -the *best* time for each is used. >> -------------------------------------------------------------- >> -Your clock granularity/precision appears to be 1 microseconds. >> -Each test below will take on the order of 112345 microseconds. >> - (= 112345 clock ticks) >> -Increase the size of the arrays if this shows that you are not getting >> -at least 20 clock ticks per test. >> -------------------------------------------------------------- >> -WARNING -- The above is only a rough guideline. >> -For best results, please be sure you know the precision of your system >> -timer. >> -------------------------------------------------------------- >> -Function Rate (MB/s) RMS time Min time Max time >> -Copy: 256.7683 0.1248 0.1246 0.1250 >> -Scale: 246.0157 0.1302 0.1301 0.1302 >> -Add: 255.0316 0.1883 0.1882 0.1885 >> -Triad: 253.1245 0.1897 0.1896 0.1899 >> - >> - >> -TTCP Benchmark Results >> -ttcp-t: socket >> -ttcp-t: connect >> -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> >> -localhost >> -ttcp-t: 16777216 bytes in 0.28 real seconds = 454.29 Mbit/sec +++ >> -ttcp-t: 2048 I/O calls, msec/call = 0.14, calls/sec = 7268.57 >> -ttcp-t: 0.0user 0.1sys 0:00real 60% 0i+0d 0maxrss 0+2pf 3+1506csw >> - >> ----------------------------------------- >> -SDRAM0_CFG0[PMU] = 0 (Suggested modification) >> -Setting PMU = 0 provides a noticeable performance improvement *2% to >> -5% improvement in memory performance. >> -*Improves the Mbit/sec for TTCP benchmark by almost 76%. >> ----------------------------------------- >> -Stream benchmark results >> -------------------------------------------------------------- >> -This system uses 8 bytes per DOUBLE PRECISION word. >> -------------------------------------------------------------- >> -Array size = 2000000, Offset = 0 >> -Total memory required = 45.8 MB. >> -Each test is run 10 times, but only >> -the *best* time for each is used. >> -------------------------------------------------------------- >> -Your clock granularity/precision appears to be 1 microseconds. >> -Each test below will take on the order of 120066 microseconds. >> - (= 120066 clock ticks) >> -Increase the size of the arrays if this shows that you are not getting >> -at least 20 clock ticks per test. >> -------------------------------------------------------------- >> -WARNING -- The above is only a rough guideline. >> -For best results, please be sure you know the precision of your system >> -timer. >> -------------------------------------------------------------- >> -Function Rate (MB/s) RMS time Min time Max time >> -Copy: 262.5167 0.1221 0.1219 0.1223 >> -Scale: 258.4856 0.1238 0.1238 0.1240 >> -Add: 262.5404 0.1829 0.1828 0.1831 >> -Triad: 266.8594 0.1800 0.1799 0.1802 >> - >> -TTCP Benchmark Results >> -ttcp-t: socket >> -ttcp-t: connect >> -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> >> -localhost >> -ttcp-t: 16777216 bytes in 0.16 real seconds = 804.06 Mbit/sec +++ >> -ttcp-t: 2048 I/O calls, msec/call = 0.08, calls/sec = 12864.89 >> -ttcp-t: 0.0user 0.0sys 0:00real 46% 0i+0d 0maxrss 0+2pf 120+1csw >> - >> - >> -2006-07-28, Stefan Roese <sr@denx.de> >> > Viele Grüße, Stefan
On 21/10/2021 07.16, Stefan Roese wrote: > On 21.10.21 00:32, Heinrich Schuchardt wrote: >> On 10/19/21 9:25 AM, Thomas Huth wrote: >>> The PPC 440 support has been removed in commit 98f705c9ce >>> ("powerpc: remove 4xx support") already, so this file is >>> certainly not required anymore. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>> Reviewed-by: Stefan Roese <sr@denx.de> >>> --- >>> doc/README.440-DDR-performance | 90 ---------------------------------- >> >> Shouldn't doc/README.nand-boot-ppc440 be removed too? > > Yes. I'll send a patch for this soonish. ... and doc/README.ppc440, too? And what about doc/README.bedbug, it still mentions ppc405 stuff ... is bedbug still used? I think you could also add doc/README.mpc74xx, the 74xx support has been removed in commit d928664f4101e24. Thomas
On 21/10/2021 08.00, Thomas Huth wrote: > On 21/10/2021 07.16, Stefan Roese wrote: >> On 21.10.21 00:32, Heinrich Schuchardt wrote: >>> On 10/19/21 9:25 AM, Thomas Huth wrote: >>>> The PPC 440 support has been removed in commit 98f705c9ce >>>> ("powerpc: remove 4xx support") already, so this file is >>>> certainly not required anymore. >>>> >>>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>>> Reviewed-by: Stefan Roese <sr@denx.de> >>>> --- >>>> doc/README.440-DDR-performance | 90 ---------------------------------- >>> >>> Shouldn't doc/README.nand-boot-ppc440 be removed too? >> >> Yes. I'll send a patch for this soonish. > > ... and doc/README.ppc440, too? And what about doc/README.bedbug, it still > mentions ppc405 stuff ... is bedbug still used? Ah, never mind my comment about README.ppc440, I just noticed that I had checked out an older branch and that this file is already gone. Thomas
On 21.10.21 08:11, Thomas Huth wrote: > On 21/10/2021 08.00, Thomas Huth wrote: >> On 21/10/2021 07.16, Stefan Roese wrote: >>> On 21.10.21 00:32, Heinrich Schuchardt wrote: >>>> On 10/19/21 9:25 AM, Thomas Huth wrote: >>>>> The PPC 440 support has been removed in commit 98f705c9ce >>>>> ("powerpc: remove 4xx support") already, so this file is >>>>> certainly not required anymore. >>>>> >>>>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>>>> Reviewed-by: Stefan Roese <sr@denx.de> >>>>> --- >>>>> doc/README.440-DDR-performance | 90 >>>>> ---------------------------------- >>>> >>>> Shouldn't doc/README.nand-boot-ppc440 be removed too? >>> >>> Yes. I'll send a patch for this soonish. >> >> ... and doc/README.ppc440, too? And what about doc/README.bedbug, it >> still mentions ppc405 stuff ... is bedbug still used? > > Ah, never mind my comment about README.ppc440, I just noticed that I had > checked out an older branch and that this file is already gone. Yes, I checked and couldn't find this file any more. Regarding bedbug. It also references PPC860, so we should not remove it now IMHO. Thanks, Stefan
diff --git a/doc/README.440-DDR-performance b/doc/README.440-DDR-performance deleted file mode 100644 index 66b97bc9b5..0000000000 --- a/doc/README.440-DDR-performance +++ /dev/null @@ -1,90 +0,0 @@ -AMCC suggested to set the PMU bit to 0 for best performace on the -PPC440 DDR controller. The 440er common DDR setup files (sdram.c & -spd_sdram.c) are changed accordingly. So all 440er boards using -these setup routines will automatically receive this performance -increase. - -Please see below some benchmarks done by AMCC to demonstrate this -performance changes: - - ----------------------------------------- -SDRAM0_CFG0[PMU] = 1 (U-Boot default for Bamboo, Yosemite and Yellowstone) ----------------------------------------- -Stream benchmark results -------------------------------------------------------------- -This system uses 8 bytes per DOUBLE PRECISION word. -------------------------------------------------------------- -Array size = 2000000, Offset = 0 -Total memory required = 45.8 MB. -Each test is run 10 times, but only -the *best* time for each is used. -------------------------------------------------------------- -Your clock granularity/precision appears to be 1 microseconds. -Each test below will take on the order of 112345 microseconds. - (= 112345 clock ticks) -Increase the size of the arrays if this shows that you are not getting -at least 20 clock ticks per test. -------------------------------------------------------------- -WARNING -- The above is only a rough guideline. -For best results, please be sure you know the precision of your system -timer. -------------------------------------------------------------- -Function Rate (MB/s) RMS time Min time Max time -Copy: 256.7683 0.1248 0.1246 0.1250 -Scale: 246.0157 0.1302 0.1301 0.1302 -Add: 255.0316 0.1883 0.1882 0.1885 -Triad: 253.1245 0.1897 0.1896 0.1899 - - -TTCP Benchmark Results -ttcp-t: socket -ttcp-t: connect -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> -localhost -ttcp-t: 16777216 bytes in 0.28 real seconds = 454.29 Mbit/sec +++ -ttcp-t: 2048 I/O calls, msec/call = 0.14, calls/sec = 7268.57 -ttcp-t: 0.0user 0.1sys 0:00real 60% 0i+0d 0maxrss 0+2pf 3+1506csw - ----------------------------------------- -SDRAM0_CFG0[PMU] = 0 (Suggested modification) -Setting PMU = 0 provides a noticeable performance improvement *2% to -5% improvement in memory performance. -*Improves the Mbit/sec for TTCP benchmark by almost 76%. ----------------------------------------- -Stream benchmark results -------------------------------------------------------------- -This system uses 8 bytes per DOUBLE PRECISION word. -------------------------------------------------------------- -Array size = 2000000, Offset = 0 -Total memory required = 45.8 MB. -Each test is run 10 times, but only -the *best* time for each is used. -------------------------------------------------------------- -Your clock granularity/precision appears to be 1 microseconds. -Each test below will take on the order of 120066 microseconds. - (= 120066 clock ticks) -Increase the size of the arrays if this shows that you are not getting -at least 20 clock ticks per test. -------------------------------------------------------------- -WARNING -- The above is only a rough guideline. -For best results, please be sure you know the precision of your system -timer. -------------------------------------------------------------- -Function Rate (MB/s) RMS time Min time Max time -Copy: 262.5167 0.1221 0.1219 0.1223 -Scale: 258.4856 0.1238 0.1238 0.1240 -Add: 262.5404 0.1829 0.1828 0.1831 -Triad: 266.8594 0.1800 0.1799 0.1802 - -TTCP Benchmark Results -ttcp-t: socket -ttcp-t: connect -ttcp-t: buflen=8192, nbuf=2048, align=16384/0, port=5000 tcp -> -localhost -ttcp-t: 16777216 bytes in 0.16 real seconds = 804.06 Mbit/sec +++ -ttcp-t: 2048 I/O calls, msec/call = 0.08, calls/sec = 12864.89 -ttcp-t: 0.0user 0.0sys 0:00real 46% 0i+0d 0maxrss 0+2pf 120+1csw - - -2006-07-28, Stefan Roese <sr@denx.de>
The PPC 440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support") already, so this file is certainly not required anymore. Signed-off-by: Thomas Huth <thuth@redhat.com> --- doc/README.440-DDR-performance | 90 ---------------------------------- 1 file changed, 90 deletions(-) delete mode 100644 doc/README.440-DDR-performance