| Message ID | 20211015072709.3167-1-george.song@maximintegrated.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/2] ASoC: dt-bindings: max98520: changed signed-off-by email address | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, Oct 15, 2021 at 04:27:08PM +0900, George Song wrote: > changed signed-off-by email address to maximintegrated group. > > Signed-off-by: George Song <george.song@maximintegrated.com> > --- > Documentation/devicetree/bindings/sound/maxim,max98520.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This file isn't upstream - it looks like you've sent an incremental patch against a previous posting instead of revising your patch? Once a patch is accepted upstream you should send incremental changes but until then you should repost the whole thing.
On Fri, Oct 15, 2021 at 04:27:09PM +0900, George Song wrote: > fixed all CHECK and WARNING for checkpatch --strict result > removed MODULE_AUTHOR to make one maintainer. > > Signed-off-by: George Song <george.song@maximintegrated.com> > --- > sound/soc/codecs/Kconfig | 7 +++ > sound/soc/codecs/max98520.c | 121 +++++++++++++++++------------------- > 2 files changed, 64 insertions(+), 64 deletions(-) Looks like the same issue here - squash the fixes into your original patch and then resend that as your version 2.
> On Fri, Oct 15, 2021 at 04:27:08PM +0900, George Song wrote: > > changed signed-off-by email address to maximintegrated group. > > > > Signed-off-by: George Song <george.song@maximintegrated.com> > > --- > > Documentation/devicetree/bindings/sound/maxim,max98520.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This file isn't upstream - it looks like you've sent an incremental patch > against a previous posting instead of revising your patch? Once a patch > is accepted upstream you should send incremental changes but until then > you should repost the whole thing. OK I see. I`ll re send patch including whole things.
> On Fri, Oct 15, 2021 at 04:27:09PM +0900, George Song wrote: > > fixed all CHECK and WARNING for checkpatch --strict result removed > > MODULE_AUTHOR to make one maintainer. > > > > Signed-off-by: George Song <george.song@maximintegrated.com> > > --- > > sound/soc/codecs/Kconfig | 7 +++ > > sound/soc/codecs/max98520.c | 121 > > +++++++++++++++++------------------- > > 2 files changed, 64 insertions(+), 64 deletions(-) > > Looks like the same issue here - squash the fixes into your original patch > and then resend that as your version 2. OK I see. I`ll re send patch including whole things.
diff --git a/Documentation/devicetree/bindings/sound/maxim,max98520.yaml b/Documentation/devicetree/bindings/sound/maxim,max98520.yaml index d1f2b5ee775a..ad38f56e1c49 100644 --- a/Documentation/devicetree/bindings/sound/maxim,max98520.yaml +++ b/Documentation/devicetree/bindings/sound/maxim,max98520.yaml @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Maxim Integrated MAX98520 Speaker Amplifier Driver maintainers: - - George Song <George.song@analog.com> + - George Song <George.song@maximintegrated.com> properties: compatible:
changed signed-off-by email address to maximintegrated group. Signed-off-by: George Song <george.song@maximintegrated.com> --- Documentation/devicetree/bindings/sound/maxim,max98520.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)