| Message ID | 20211011142215.9013-9-alexandru.tachici@analog.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | net: phy: adin1100: Add initial support for ADIN1100 industrial PHY | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 11 Oct 2021 17:22:15 +0300, alexandru.tachici@analog.com wrote: > From: Alexandru Tachici <alexandru.tachici@analog.com> > > DT bindings for the ADIN1100 10BASE-T1L Ethernet PHY. > > Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com> > --- > .../devicetree/bindings/net/adi,adin1100.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/adi,adin1100.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/adi,adin1100.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property hint: A schema with a "$ref" to another schema either can define all properties used and use "additionalProperties" or can use "unevaluatedProperties" from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/adi,adin1100.yaml: 'anyOf' conditional failed, one must be fixed: 'properties' is a required property 'patternProperties' is a required property hint: Metaschema for devicetree binding documentation from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/adi,adin1100.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/net/adi,adin1100.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/adi,adin1100.example.dt.yaml: ethernet: '10base-t1l-2.4vpp' does not match any of the regexes: '.*-names$', '.*-supply$', '^#.*-cells$', '^#[a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+(,[0-9a-fA-F]+)*$', '^__.*__$', 'pinctrl-[0-9]+' From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/dt-core.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1539350 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, Oct 11, 2021 at 05:22:15PM +0300, alexandru.tachici@analog.com wrote: > From: Alexandru Tachici <alexandru.tachici@analog.com> > > DT bindings for the ADIN1100 10BASE-T1L Ethernet PHY. > > Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com> > --- > .../devicetree/bindings/net/adi,adin1100.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/adi,adin1100.yaml > > diff --git a/Documentation/devicetree/bindings/net/adi,adin1100.yaml b/Documentation/devicetree/bindings/net/adi,adin1100.yaml > new file mode 100644 > index 000000000000..7f98ea8fdf51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/adi,adin1100.yaml > @@ -0,0 +1,30 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/adi,adin1100.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADIN1100 PHY > + > +maintainers: > + - Alexandru Tachici <alexandru.tachici@analog.com> > + > +description: > + Bindings for Analog Devices Industrial Low Power 10BASE-T1L Ethernet PHY This schema doesn't do anything. ethernet-phy.yaml is already applied based on the node name and you haven't added any phy specific properties. > + > +allOf: > + - $ref: ethernet-phy.yaml# > + > +examples: > + - | > + ethernet { > + #address-cells = <1>; > + #size-cells = <0>; > + > + 10base-t1l-2.4vpp = <0>; > + > + ethernet-phy@0 { > + compatible = "ethernet-phy-id0283.bc81"; > + reg = <0>; > + }; > + }; > -- > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/net/adi,adin1100.yaml b/Documentation/devicetree/bindings/net/adi,adin1100.yaml new file mode 100644 index 000000000000..7f98ea8fdf51 --- /dev/null +++ b/Documentation/devicetree/bindings/net/adi,adin1100.yaml @@ -0,0 +1,30 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/adi,adin1100.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADIN1100 PHY + +maintainers: + - Alexandru Tachici <alexandru.tachici@analog.com> + +description: + Bindings for Analog Devices Industrial Low Power 10BASE-T1L Ethernet PHY + +allOf: + - $ref: ethernet-phy.yaml# + +examples: + - | + ethernet { + #address-cells = <1>; + #size-cells = <0>; + + 10base-t1l-2.4vpp = <0>; + + ethernet-phy@0 { + compatible = "ethernet-phy-id0283.bc81"; + reg = <0>; + }; + };