Message ID | 20210816131335.142993-3-marcel@ziswiler.com |
---|---|
State | Superseded |
Delegated to: | Stefano Babic |
Headers | show |
Series | board: toradex: prepare and add colibri imx6ull 1gb (emmc) support | expand |
Hi Marcel, On Mon, Aug 16, 2021 at 10:13 AM Marcel Ziswiler <marcel@ziswiler.com> wrote: > > From: Denys Drozdov <denys.drozdov@toradex.com> > > Restore "Is the module an IT version? [y/N]" for "cfgblock create" > interactive mode command, which was leading to invalid detection > of 0051 Colibri iMX8DX 1GB WB module; > > Fixes: a5b5ad4d859b ("toradex: tdx-cfg-clock: add new i.mx 8m mini/plus skus") > Related-to: ELB-3482 This Related-to tag does not seem to be a valid one. Regards, Fabio Estevam
Hi Fabio On Mon, 2021-08-16 at 10:27 -0300, Fabio Estevam wrote: > Hi Marcel, > > On Mon, Aug 16, 2021 at 10:13 AM Marcel Ziswiler <marcel@ziswiler.com> wrote: > > > > From: Denys Drozdov <denys.drozdov@toradex.com> > > > > Restore "Is the module an IT version? [y/N]" for "cfgblock create" > > interactive mode command, which was leading to invalid detection > > of 0051 Colibri iMX8DX 1GB WB module; > > > > Fixes: a5b5ad4d859b ("toradex: tdx-cfg-clock: add new i.mx 8m mini/plus skus") > > Related-to: ELB-3482 > > This Related-to tag does not seem to be a valid one. I am not exactly sure as to what exactly you are referring to here concerning validity of such tags. I believe we are not the only company (e.g. NXP themselves included) using this to refer to our internal ticketing system which BTW is even half public (e.g. not all tickets have required public information and are therefore published but this particular one even is): https://developer.toradex.com/software/linux/linux-software/release-details?view=all&key=ELB-3482 > Regards, > > Fabio Estevam Cheers Marcel
Hi Marcel, On Mon, Aug 16, 2021 at 10:53 AM Marcel Ziswiler <marcel.ziswiler@toradex.com> wrote: > I am not exactly sure as to what exactly you are referring to here concerning validity of such tags. I believe > we are not the only company (e.g. NXP themselves included) using this to refer to our internal ticketing system > which BTW is even half public (e.g. not all tickets have required public information and are therefore > published but this particular one even is): I simply did "git log" and then searched for "Related-to" and could not find such a tag in U-Boot, so that is why I asked. Regards, Fabio Estevam
diff --git a/board/toradex/common/tdx-cfg-block.c b/board/toradex/common/tdx-cfg-block.c index e4f9a0db914..1295f389896 100644 --- a/board/toradex/common/tdx-cfg-block.c +++ b/board/toradex/common/tdx-cfg-block.c @@ -368,7 +368,10 @@ static int get_cfgblock_interactive(void) if (cpu_is_pxa27x()) sprintf(message, "Is the module the 312 MHz version? [y/N] "); else - it = 'y'; + sprintf(message, "Is the module an IT version? [y/N] "); + + len = cli_readline(message); + it = console_buffer[0]; #if defined(CONFIG_TARGET_APALIS_IMX8) || \ defined(CONFIG_TARGET_APALIS_IMX8X) || \