mbox series

[0/1,SRU,OEM-5.10/OEM-5.13/H/U] Fix HDR backlight issue on AMD

Message ID 20210730080228.415853-1-aaron.ma@canonical.com
Headers show
Series Fix HDR backlight issue on AMD | expand

Message

Aaron Ma July 30, 2021, 8:02 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1934557

SRU justification:

[Impact]
backlight can't be controlled on AMD platform.

[Fix]
AUX doesn't work on HDR panel, fallback to PWM mode to make backlight be
controlled.

[Test]
Verified on hardware, backlight brightness works fine.

[Where problems could occur]
It may break backlight control on AMD platform.

Alex Deucher (1):
  drm/amdgpu/display: only enable aux backlight control for OLED panels

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tim Gardner July 30, 2021, 11:20 a.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 7/30/21 2:02 AM, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934557
> 
> SRU justification:
> 
> [Impact]
> backlight can't be controlled on AMD platform.
> 
> [Fix]
> AUX doesn't work on HDR panel, fallback to PWM mode to make backlight be
> controlled.
> 
> [Test]
> Verified on hardware, backlight brightness works fine.
> 
> [Where problems could occur]
> It may break backlight control on AMD platform.
> 
> Alex Deucher (1):
>    drm/amdgpu/display: only enable aux backlight control for OLED panels
> 
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
Paolo Pisati Aug. 3, 2021, 3:33 p.m. UTC | #2
On Fri, Jul 30, 2021 at 04:02:27PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934557
AceLan Kao Aug. 9, 2021, 3:42 a.m. UTC | #3
applied to oem-5.10, thanks
Acked-By: AceLan Kao <acelan.kao@canonical.com>
Kelsey Skunberg Aug. 11, 2021, 11:45 p.m. UTC | #4
Acked-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>

On 2021-07-30 16:02:27 , Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934557
> 
> SRU justification:
> 
> [Impact]
> backlight can't be controlled on AMD platform.
> 
> [Fix]
> AUX doesn't work on HDR panel, fallback to PWM mode to make backlight be
> controlled.
> 
> [Test]
> Verified on hardware, backlight brightness works fine.
> 
> [Where problems could occur]
> It may break backlight control on AMD platform.
> 
> Alex Deucher (1):
>   drm/amdgpu/display: only enable aux backlight control for OLED panels
> 
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.32.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kelsey Skunberg Aug. 13, 2021, 1:05 a.m. UTC | #5
applied to hirsute master-next. Thank you!

-Kelsey

On 2021-07-30 16:02:27 , Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934557
> 
> SRU justification:
> 
> [Impact]
> backlight can't be controlled on AMD platform.
> 
> [Fix]
> AUX doesn't work on HDR panel, fallback to PWM mode to make backlight be
> controlled.
> 
> [Test]
> Verified on hardware, backlight brightness works fine.
> 
> [Where problems could occur]
> It may break backlight control on AMD platform.
> 
> Alex Deucher (1):
>   drm/amdgpu/display: only enable aux backlight control for OLED panels
> 
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.32.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Timo Aaltonen Aug. 17, 2021, 12:49 p.m. UTC | #6
On 30.7.2021 11.02, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934557
> 
> SRU justification:
> 
> [Impact]
> backlight can't be controlled on AMD platform.
> 
> [Fix]
> AUX doesn't work on HDR panel, fallback to PWM mode to make backlight be
> controlled.
> 
> [Test]
> Verified on hardware, backlight brightness works fine.
> 
> [Where problems could occur]
> It may break backlight control on AMD platform.
> 
> Alex Deucher (1):
>    drm/amdgpu/display: only enable aux backlight control for OLED panels
> 
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

This is already included in the drm sync from 5.14.