diff mbox series

of: fdt: do not update local variable after use

Message ID 20210803101309.904-1-ohoono.kwon@samsung.com
State Accepted, archived
Headers show
Series of: fdt: do not update local variable after use | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Ohhoon Kwon Aug. 3, 2021, 10:13 a.m. UTC
Fix the below warning:
drivers/of/fdt.c:196:4: warning: Value stored to 'pprev' is never read
[clang-analyzer-deadcode.DeadStores]
             pprev      = &pp->next;
             ^            ~~~~~~~~~

Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
---
 drivers/of/fdt.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Rob Herring (Arm) Aug. 3, 2021, 8:20 p.m. UTC | #1
On Tue, 03 Aug 2021 19:13:09 +0900, Ohhoon Kwon wrote:
> Fix the below warning:
> drivers/of/fdt.c:196:4: warning: Value stored to 'pprev' is never read
> [clang-analyzer-deadcode.DeadStores]
>              pprev      = &pp->next;
>              ^            ~~~~~~~~~
> 
> Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
> ---
>  drivers/of/fdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index bd35ba56aa96..5dc0b0310d7c 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -193,7 +193,6 @@  static void populate_properties(const void *blob,
 			pp->length = len;
 			pp->value  = pp + 1;
 			*pprev     = pp;
-			pprev      = &pp->next;
 			memcpy(pp->value, ps, len - 1);
 			((char *)pp->value)[len - 1] = 0;
 			pr_debug("fixed up name for %s -> %s\n",