| Message ID | 20210722181022.17110-1-ping.a.bao@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | UBUNTU: SAUCE: PCI/ASPM: Add AlderLake ASPM support for links under VMD domain | expand |
On 22.07.21 20:10, Ping Bao wrote: > BugLink: https://bugs.launchpad.net/bugs/1889384 > > Add AlderLake ASPM support for links under VMD to reach deeper power > saving state. > > Signed-off-by: Ping Bao <ping.a.bao@intel.com> > --- The bug report which is referred to suggest that this is already fixed. Also the submission gives not indication to which kernel this should be applied if it were still required. -Stefan > drivers/pci/quirks.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index fb13b3109a43..baa727330cdc 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -5650,7 +5650,7 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a, > PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class); > > /* > - * Device [8086:9a09], [8086:a0b0] and [8086:a0bc] > + * Device [8086:9a09], [8086:a0b0], [8086:a0bc] and [8086:464d] > * BIOS may not be able to access config space of devices under VMD domain, so > * it relies on software to enable ASPM for links under VMD. > */ > @@ -5658,6 +5658,7 @@ static const struct pci_device_id vmd_bridge_tbl[] = { > { PCI_VDEVICE(INTEL, 0x9a09) }, > { PCI_VDEVICE(INTEL, 0xa0b0) }, > { PCI_VDEVICE(INTEL, 0xa0bc) }, > + { PCI_VDEVICE(INTEL, 0x464d) }, > { } > }; > >
Hi Stefan, I added this device ID for Alder Lake (SoC) to the previous patch for Ubuntu-kernel hirsute 5.11.22. Without adding this device ID, the system cannot enter PC10 state once VMD is enabled in BIOS . After applying this patch (new device ID), this system can enter PC10 state (low power) successfully. Thanks, Ping > -----Original Message----- > From: Stefan Bader <stefan.bader@canonical.com> > Sent: Friday, July 23, 2021 12:35 AM > To: Ping Bao <pingbao@gmail.com>; kernel-team@lists.ubuntu.com > Cc: Bao, Ping A <ping.a.bao@intel.com>; You-Sheng Yang > <vicamo.yang@canonical.com> > Subject: NACK/Cmnt: [PATCH] UBUNTU: SAUCE: PCI/ASPM: Add AlderLake > ASPM support for links under VMD domain > > On 22.07.21 20:10, Ping Bao wrote: > > BugLink: https://bugs.launchpad.net/bugs/1889384 > > > > Add AlderLake ASPM support for links under VMD to reach deeper power > > saving state. > > > > Signed-off-by: Ping Bao <ping.a.bao@intel.com> > > --- > > The bug report which is referred to suggest that this is already fixed. Also the > submission gives not indication to which kernel this should be applied if it were > still required. > > -Stefan > > > drivers/pci/quirks.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index > > fb13b3109a43..baa727330cdc 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -5650,7 +5650,7 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, > 0x089a, > > PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class); > > > > /* > > - * Device [8086:9a09], [8086:a0b0] and [8086:a0bc] > > + * Device [8086:9a09], [8086:a0b0], [8086:a0bc] and [8086:464d] > > * BIOS may not be able to access config space of devices under VMD domain, > so > > * it relies on software to enable ASPM for links under VMD. > > */ > > @@ -5658,6 +5658,7 @@ static const struct pci_device_id vmd_bridge_tbl[] = > { > > { PCI_VDEVICE(INTEL, 0x9a09) }, > > { PCI_VDEVICE(INTEL, 0xa0b0) }, > > { PCI_VDEVICE(INTEL, 0xa0bc) }, > > + { PCI_VDEVICE(INTEL, 0x464d) }, > > { } > > }; > > > > >
[+Cc Anthony, David] Hi Ping, On Fri, Jul 23, 2021 at 1:41 PM Ping Bao <pingbao@gmail.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/1889384 > > Add AlderLake ASPM support for links under VMD to reach deeper power > saving state. I was told by David that ADL VMD ASPM should be enabled by BIOS. So wonder why the patch is necessary? Kai-Heng > > Signed-off-by: Ping Bao <ping.a.bao@intel.com> > --- > drivers/pci/quirks.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index fb13b3109a43..baa727330cdc 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -5650,7 +5650,7 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a, > PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class); > > /* > - * Device [8086:9a09], [8086:a0b0] and [8086:a0bc] > + * Device [8086:9a09], [8086:a0b0], [8086:a0bc] and [8086:464d] > * BIOS may not be able to access config space of devices under VMD domain, so > * it relies on software to enable ASPM for links under VMD. > */ > @@ -5658,6 +5658,7 @@ static const struct pci_device_id vmd_bridge_tbl[] = { > { PCI_VDEVICE(INTEL, 0x9a09) }, > { PCI_VDEVICE(INTEL, 0xa0b0) }, > { PCI_VDEVICE(INTEL, 0xa0bc) }, > + { PCI_VDEVICE(INTEL, 0x464d) }, > { } > }; > > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
Hi Kai-Heng, > -----Original Message----- > From: Kai-Heng Feng <kai.heng.feng@canonical.com> > Sent: Tuesday, July 27, 2021 7:44 PM > To: pingbao@gmail.com > Cc: Kernel team list <kernel-team@lists.ubuntu.com>; Bao, Ping A > <ping.a.bao@intel.com>; Wong, Anthony <anthony.wong@canonical.com>; > David E. Box <david.e.box@linux.intel.com> > Subject: Re: [PATCH] UBUNTU: SAUCE: PCI/ASPM: Add AlderLake ASPM support > for links under VMD domain > > [+Cc Anthony, David] > > Hi Ping, > > On Fri, Jul 23, 2021 at 1:41 PM Ping Bao <pingbao@gmail.com> wrote: > > > > BugLink: https://bugs.launchpad.net/bugs/1889384 > > > > Add AlderLake ASPM support for links under VMD to reach deeper power > > saving state. > > I was told by David that ADL VMD ASPM should be enabled by BIOS. So wonder > why the patch is necessary? Just talked with David. This feature has not been implemented yet. Ping > > Kai-Heng > > > > > Signed-off-by: Ping Bao <ping.a.bao@intel.com> > > --- > > drivers/pci/quirks.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index > > fb13b3109a43..baa727330cdc 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -5650,7 +5650,7 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, > 0x089a, > > PCI_CLASS_NOT_DEFINED, 8, > > apex_pci_fixup_class); > > > > /* > > - * Device [8086:9a09], [8086:a0b0] and [8086:a0bc] > > + * Device [8086:9a09], [8086:a0b0], [8086:a0bc] and [8086:464d] > > * BIOS may not be able to access config space of devices under VMD domain, > so > > * it relies on software to enable ASPM for links under VMD. > > */ > > @@ -5658,6 +5658,7 @@ static const struct pci_device_id vmd_bridge_tbl[] = > { > > { PCI_VDEVICE(INTEL, 0x9a09) }, > > { PCI_VDEVICE(INTEL, 0xa0b0) }, > > { PCI_VDEVICE(INTEL, 0xa0bc) }, > > + { PCI_VDEVICE(INTEL, 0x464d) }, > > { } > > }; > > > > -- > > 2.25.1 > > > > > > -- > > kernel-team mailing list > > kernel-team@lists.ubuntu.com > > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Thu, Jul 29, 2021 at 7:11 AM Bao, Ping A <ping.a.bao@intel.com> wrote: > > Hi Kai-Heng, > > > -----Original Message----- > > From: Kai-Heng Feng <kai.heng.feng@canonical.com> > > Sent: Tuesday, July 27, 2021 7:44 PM > > To: pingbao@gmail.com > > Cc: Kernel team list <kernel-team@lists.ubuntu.com>; Bao, Ping A > > <ping.a.bao@intel.com>; Wong, Anthony <anthony.wong@canonical.com>; > > David E. Box <david.e.box@linux.intel.com> > > Subject: Re: [PATCH] UBUNTU: SAUCE: PCI/ASPM: Add AlderLake ASPM support > > for links under VMD domain > > > > [+Cc Anthony, David] > > > > Hi Ping, > > > > On Fri, Jul 23, 2021 at 1:41 PM Ping Bao <pingbao@gmail.com> wrote: > > > > > > BugLink: https://bugs.launchpad.net/bugs/1889384 > > > > > > Add AlderLake ASPM support for links under VMD to reach deeper power > > > saving state. > > > > I was told by David that ADL VMD ASPM should be enabled by BIOS. So wonder > > why the patch is necessary? > > Just talked with David. This feature has not been implemented yet. Okay, please follow [1] to do the SRU, thanks! [1] https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat Kai-Heng > > Ping > > > > > Kai-Heng > > > > > > > > Signed-off-by: Ping Bao <ping.a.bao@intel.com> > > > --- > > > drivers/pci/quirks.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index > > > fb13b3109a43..baa727330cdc 100644 > > > --- a/drivers/pci/quirks.c > > > +++ b/drivers/pci/quirks.c > > > @@ -5650,7 +5650,7 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, > > 0x089a, > > > PCI_CLASS_NOT_DEFINED, 8, > > > apex_pci_fixup_class); > > > > > > /* > > > - * Device [8086:9a09], [8086:a0b0] and [8086:a0bc] > > > + * Device [8086:9a09], [8086:a0b0], [8086:a0bc] and [8086:464d] > > > * BIOS may not be able to access config space of devices under VMD domain, > > so > > > * it relies on software to enable ASPM for links under VMD. > > > */ > > > @@ -5658,6 +5658,7 @@ static const struct pci_device_id vmd_bridge_tbl[] = > > { > > > { PCI_VDEVICE(INTEL, 0x9a09) }, > > > { PCI_VDEVICE(INTEL, 0xa0b0) }, > > > { PCI_VDEVICE(INTEL, 0xa0bc) }, > > > + { PCI_VDEVICE(INTEL, 0x464d) }, > > > { } > > > }; > > > > > > -- > > > 2.25.1 > > > > > > > > > -- > > > kernel-team mailing list > > > kernel-team@lists.ubuntu.com > > > https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index fb13b3109a43..baa727330cdc 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5650,7 +5650,7 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a, PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class); /* - * Device [8086:9a09], [8086:a0b0] and [8086:a0bc] + * Device [8086:9a09], [8086:a0b0], [8086:a0bc] and [8086:464d] * BIOS may not be able to access config space of devices under VMD domain, so * it relies on software to enable ASPM for links under VMD. */ @@ -5658,6 +5658,7 @@ static const struct pci_device_id vmd_bridge_tbl[] = { { PCI_VDEVICE(INTEL, 0x9a09) }, { PCI_VDEVICE(INTEL, 0xa0b0) }, { PCI_VDEVICE(INTEL, 0xa0bc) }, + { PCI_VDEVICE(INTEL, 0x464d) }, { } };
BugLink: https://bugs.launchpad.net/bugs/1889384 Add AlderLake ASPM support for links under VMD to reach deeper power saving state. Signed-off-by: Ping Bao <ping.a.bao@intel.com> --- drivers/pci/quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)