diff mbox series

[1/2] lib: utils: remove unused variable in fdt_reset_init

Message ID 20210722105359.18622-2-xypron.glpk@gmx.de
State Accepted
Headers show
Series lib: utils: support both of gpio-poweroff, gpio-reset | expand

Commit Message

Heinrich Schuchardt July 22, 2021, 10:53 a.m. UTC 
The value of variable current_driver is unused. Remove the variable.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 lib/utils/reset/fdt_reset.c | 3 ---
 1 file changed, 3 deletions(-)

--
2.30.2

Comments

Atish Patra July 22, 2021, 7:15 p.m. UTC | #1 
On Thu, Jul 22, 2021 at 3:54 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> The value of variable current_driver is unused. Remove the variable.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  lib/utils/reset/fdt_reset.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/lib/utils/reset/fdt_reset.c b/lib/utils/reset/fdt_reset.c
> index aa5f59f..87f925c 100644
> --- a/lib/utils/reset/fdt_reset.c
> +++ b/lib/utils/reset/fdt_reset.c
> @@ -24,8 +24,6 @@ static struct fdt_reset *reset_drivers[] = {
>         &fdt_reset_thead,
>  };
>
> -static struct fdt_reset *current_driver = NULL;
> -
>  int fdt_reset_init(void)
>  {
>         int pos, noff, rc;
> @@ -47,7 +45,6 @@ int fdt_reset_init(void)
>                         if (rc)
>                                 return rc;
>                 }
> -               current_driver = drv;
>                 break;
>         }
>
> --
> 2.30.2
>
>
> --
> opensbi mailing list
> opensbi@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi


Reviewed-by: Atish Patra <atish.patra@wdc.com>
Anup Patel July 27, 2021, 11:54 a.m. UTC | #2 
On Fri, Jul 23, 2021 at 12:46 AM Atish Patra <atishp@atishpatra.org> wrote:
>
> On Thu, Jul 22, 2021 at 3:54 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > The value of variable current_driver is unused. Remove the variable.
> >
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

If possible please use same email in From: and Signed-off-by:

> > ---
> >  lib/utils/reset/fdt_reset.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/lib/utils/reset/fdt_reset.c b/lib/utils/reset/fdt_reset.c
> > index aa5f59f..87f925c 100644
> > --- a/lib/utils/reset/fdt_reset.c
> > +++ b/lib/utils/reset/fdt_reset.c
> > @@ -24,8 +24,6 @@ static struct fdt_reset *reset_drivers[] = {
> >         &fdt_reset_thead,
> >  };
> >
> > -static struct fdt_reset *current_driver = NULL;
> > -
> >  int fdt_reset_init(void)
> >  {
> >         int pos, noff, rc;
> > @@ -47,7 +45,6 @@ int fdt_reset_init(void)
> >                         if (rc)
> >                                 return rc;
> >                 }
> > -               current_driver = drv;
> >                 break;
> >         }
> >
> > --
> > 2.30.2
> >
> >
> > --
> > opensbi mailing list
> > opensbi@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/opensbi
>
>
> Reviewed-by: Atish Patra <atish.patra@wdc.com>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

>
> --
> Regards,
> Atish
>
> --
> opensbi mailing list
> opensbi@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
diff mbox series

Patch

diff --git a/lib/utils/reset/fdt_reset.c b/lib/utils/reset/fdt_reset.c
index aa5f59f..87f925c 100644
--- a/lib/utils/reset/fdt_reset.c
+++ b/lib/utils/reset/fdt_reset.c
@@ -24,8 +24,6 @@  static struct fdt_reset *reset_drivers[] = {
 	&fdt_reset_thead,
 };

-static struct fdt_reset *current_driver = NULL;
-
 int fdt_reset_init(void)
 {
 	int pos, noff, rc;
@@ -47,7 +45,6 @@  int fdt_reset_init(void)
 			if (rc)
 				return rc;
 		}
-		current_driver = drv;
 		break;
 	}