diff mbox series

[ovs-dev] netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref.

Message ID ME3PR01MB57813973FFCDED3F4C4927FFCD2B9@ME3PR01MB5781.ausprd01.prod.outlook.com
State Changes Requested
Headers show
Series [ovs-dev] netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref. | expand

Commit Message

miter May 19, 2021, 3:57 p.m. UTC 
netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref.

Signed-off-by: miter <linhuang@ruijie.com.cn>
---
 lib/netdev-linux.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--
2.31.1

Comments

Roi Dayan July 25, 2021, 6:25 a.m. UTC | #1 
On 2021-05-19 6:57 PM, lin huang wrote:
> netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref.
> 
> Signed-off-by: miter <linhuang@ruijie.com.cn>
> ---
>   lib/netdev-linux.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index 15b25084b..0994044ec 100644
> --- a/lib/netdev-linux.c
> +++ b/lib/netdev-linux.c
> @@ -634,7 +634,9 @@ netdev_linux_notify_sock(void)
>                   }
>               }
>           }
> -        nl_sock_listen_all_nsid(sock, true);
> +        if (sock) {
> +            nl_sock_listen_all_nsid(sock, true);
> + }
>           ovsthread_once_done(&once);
>       }
> 
> --
> 2.31.1
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=04%7C01%7Croid%40nvidia.com%7C215ca7c887024f7daef208d91adecd05%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637570366499393944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=Iz3GaO7wuuEtcEmKdN5tQHdF48pyhARZoJvw1HGQb9E%3D&amp;reserved=0
> 

Hi,

Can you fix the checkpatch warning?

Thanks,
Roi
diff mbox series

Patch

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 15b25084b..0994044ec 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -634,7 +634,9 @@  netdev_linux_notify_sock(void)
                 }
             }
         }
-        nl_sock_listen_all_nsid(sock, true);
+        if (sock) {
+            nl_sock_listen_all_nsid(sock, true);
+ }
         ovsthread_once_done(&once);
     }