diff mbox series

[ovs-dev,v1] ovsdb-server.7.rst Fix response result of monitor_cond_change

Message ID 20210615120147.2221410-1-aroytman@gmail.com
State Accepted
Headers show
Series [ovs-dev,v1] ovsdb-server.7.rst Fix response result of monitor_cond_change | expand

Commit Message

Alexey Roytman June 15, 2021, 12:01 p.m. UTC 
From: Alexey Roytman <roytman@il.ibm.com>

The original version said that "monitor_cond_change" request response 
should contain '"result": null'. However, if response message has form 
like {"id":13, "result":null} or {"id":13} the ovsdb client 
(ovn-controller) returns the folling misleading message and closes 
connection.

2021-06-07T14:32:30.116Z|00026|jsonrpc|WARN|tcp:172.18.0.4:6642: received
  bad JSON-RPC message: request must have "method"
2021-06-07T14:32:30.116Z|00027|reconnect|WARN|tcp:172.18.0.4:6642: 
  connection dropped (Protocol error)

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
---
 Documentation/ref/ovsdb-server.7.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff July 7, 2021, 8:32 p.m. UTC | #1 
On Tue, Jun 15, 2021 at 03:01:47PM +0300, Alexey Roytman wrote:
> From: Alexey Roytman <roytman@il.ibm.com>
> 
> The original version said that "monitor_cond_change" request response 
> should contain '"result": null'. However, if response message has form 
> like {"id":13, "result":null} or {"id":13} the ovsdb client 
> (ovn-controller) returns the folling misleading message and closes 
> connection.
> 
> 2021-06-07T14:32:30.116Z|00026|jsonrpc|WARN|tcp:172.18.0.4:6642: received
>   bad JSON-RPC message: request must have "method"
> 2021-06-07T14:32:30.116Z|00027|reconnect|WARN|tcp:172.18.0.4:6642: 
>   connection dropped (Protocol error)
> 
> Signed-off-by: Alexey Roytman <roytman@il.ibm.com>

Thanks for the correction.  I applied this patch to OVS.
diff mbox series

Patch

diff --git a/Documentation/ref/ovsdb-server.7.rst b/Documentation/ref/ovsdb-server.7.rst
index 04414350a..e1dca6dca 100644
--- a/Documentation/ref/ovsdb-server.7.rst
+++ b/Documentation/ref/ovsdb-server.7.rst
@@ -304,7 +304,7 @@  monitoring session.
 
 The response object has the following members::
 
-    "result": null
+    "result": {}
     "error": null
     "id": same "id" as request