diff mbox series

cmd: part: Correct error handling

Message ID 20210622094001.54811-1-anders.dellien@arm.com
State Accepted
Commit 7cb31e399e46a74d1d46e8b64598d86018fa4e0b
Delegated to: Tom Rini
Headers show
Series cmd: part: Correct error handling | expand

Commit Message

Anders Dellien June 22, 2021, 9:40 a.m. UTC 
As 'part_get_info_by_name' now returns more status codes than just
-1 to indicate failure, we need to update the return value check.

Signed-off-by: Anders Dellien <anders.dellien@arm.com>
---
 cmd/part.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Anderson June 22, 2021, 2:39 p.m. UTC | #1 
On 6/22/21 5:40 AM, Anders Dellien wrote:
> As 'part_get_info_by_name' now returns more status codes than just
> -1 to indicate failure, we need to update the return value check.
> 
> Signed-off-by: Anders Dellien <anders.dellien@arm.com>
> ---
>   cmd/part.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/part.c b/cmd/part.c
> index 3395c17b89..e0463b5a54 100644
> --- a/cmd/part.c
> +++ b/cmd/part.c
> @@ -140,7 +140,7 @@ static int do_part_info(int argc, char *const argv[], enum cmd_part_info param)
>   			return 1;
>   	} else {
>   		part = part_get_info_by_name(desc, argv[2], &info);
> -		if (part == -1)
> +		if (part < 0)
>   			return 1;
>   	}
>   
> 

Reviewed-by: Sean Anderson <sean.anderson@seco.com>
Tom Rini July 23, 2021, 12:34 p.m. UTC | #2 
On Tue, Jun 22, 2021 at 10:40:01AM +0100, Anders Dellien wrote:

> As 'part_get_info_by_name' now returns more status codes than just
> -1 to indicate failure, we need to update the return value check.
> 
> Signed-off-by: Anders Dellien <anders.dellien@arm.com>
> Reviewed-by: Sean Anderson <sean.anderson@seco.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/cmd/part.c b/cmd/part.c
index 3395c17b89..e0463b5a54 100644
--- a/cmd/part.c
+++ b/cmd/part.c
@@ -140,7 +140,7 @@  static int do_part_info(int argc, char *const argv[], enum cmd_part_info param)
 			return 1;
 	} else {
 		part = part_get_info_by_name(desc, argv[2], &info);
-		if (part == -1)
+		if (part < 0)
 			return 1;
 	}