| Message ID | 20200716155224.9671-1-arjunak234@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | package/comgt: Handle bind/unbind events | expand |
On 16/07/20 9:22 pm, Arjun AK wrote: > This script was expecting only add/remove events which has not been the > case since Kernel 4.12 (which added bind/unbind). Bind events were getting > treated as remove events which would cause hotplugged 3g modems to not > work. > > More info: > https://lkml.org/lkml/2018/12/23/128 > https://github.com/systemd/systemd/issues/8221 > > Signed-off-by: Arjun AK <arjunak234@gmail.com> > --- > package/network/utils/comgt/files/3g.usb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/network/utils/comgt/files/3g.usb b/package/network/utils/comgt/files/3g.usb > index 8f0d62ca83..9c7d07a0e6 100644 > --- a/package/network/utils/comgt/files/3g.usb > +++ b/package/network/utils/comgt/files/3g.usb > @@ -23,6 +23,8 @@ find_3g_iface() { > fi > } > > +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 > + > case "$DEVICENAME" in > tty*) > [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || exit 0 > Has this been merged?
On 06/01/21 9:03 pm, Arjun AK wrote: > On 16/07/20 9:22 pm, Arjun AK wrote: >> This script was expecting only add/remove events which has not been the >> case since Kernel 4.12 (which added bind/unbind). Bind events were >> getting >> treated as remove events which would cause hotplugged 3g modems to not >> work. >> >> More info: >> https://lkml.org/lkml/2018/12/23/128 >> https://github.com/systemd/systemd/issues/8221 >> >> Signed-off-by: Arjun AK <arjunak234@gmail.com> >> --- >> package/network/utils/comgt/files/3g.usb | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/package/network/utils/comgt/files/3g.usb >> b/package/network/utils/comgt/files/3g.usb >> index 8f0d62ca83..9c7d07a0e6 100644 >> --- a/package/network/utils/comgt/files/3g.usb >> +++ b/package/network/utils/comgt/files/3g.usb >> @@ -23,6 +23,8 @@ find_3g_iface() { >> fi >> } >> +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 >> + >> case "$DEVICENAME" in >> tty*) >> [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || exit 0 >> > > Has this been merged? Can someone please merge this in?
On 08/05/21 5:38 am, Arjun AK wrote: > On 06/01/21 9:03 pm, Arjun AK wrote: >> On 16/07/20 9:22 pm, Arjun AK wrote: >>> This script was expecting only add/remove events which has not been the >>> case since Kernel 4.12 (which added bind/unbind). Bind events were >>> getting >>> treated as remove events which would cause hotplugged 3g modems to not >>> work. >>> >>> More info: >>> https://lkml.org/lkml/2018/12/23/128 >>> https://github.com/systemd/systemd/issues/8221 >>> >>> Signed-off-by: Arjun AK <arjunak234@gmail.com> >>> --- >>> package/network/utils/comgt/files/3g.usb | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/package/network/utils/comgt/files/3g.usb >>> b/package/network/utils/comgt/files/3g.usb >>> index 8f0d62ca83..9c7d07a0e6 100644 >>> --- a/package/network/utils/comgt/files/3g.usb >>> +++ b/package/network/utils/comgt/files/3g.usb >>> @@ -23,6 +23,8 @@ find_3g_iface() { >>> fi >>> } >>> +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 >>> + >>> case "$DEVICENAME" in >>> tty*) >>> [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || exit 0 >>> >> >> Has this been merged? > > Can someone please merge this in? Its been over a year now, can someone merge this one in? - Arjun
On 19/06/21 01:44, Arjun AK wrote: > On 08/05/21 5:38 am, Arjun AK wrote: >> On 06/01/21 9:03 pm, Arjun AK wrote: >>> On 16/07/20 9:22 pm, Arjun AK wrote: >>>> This script was expecting only add/remove events which has not been the >>>> case since Kernel 4.12 (which added bind/unbind). Bind events were >>>> getting >>>> treated as remove events which would cause hotplugged 3g modems to not >>>> work. >>>> >>>> More info: >>>> https://lkml.org/lkml/2018/12/23/128 >>>> https://github.com/systemd/systemd/issues/8221 >>>> >>>> Signed-off-by: Arjun AK <arjunak234@gmail.com> >>>> --- >>>> package/network/utils/comgt/files/3g.usb | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/package/network/utils/comgt/files/3g.usb >>>> b/package/network/utils/comgt/files/3g.usb >>>> index 8f0d62ca83..9c7d07a0e6 100644 >>>> --- a/package/network/utils/comgt/files/3g.usb >>>> +++ b/package/network/utils/comgt/files/3g.usb >>>> @@ -23,6 +23,8 @@ find_3g_iface() { >>>> fi >>>> } >>>> +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 >>>> + >>>> case "$DEVICENAME" in >>>> tty*) >>>> [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || exit 0 >>>> >>> >>> Has this been merged? >> >> Can someone please merge this in? > > Its been over a year now, can someone merge this one in? > > - > Arjun > It does not seem there are many core developers able or interested in maintaining these packages in core repository. You might accomplish more if you send a PR where you move the whole comgt (and uim package) to the community packages repo and become maintainer. It was done for some other packages in a similar situation, and a few core developers have been active on this migration and might be interested (Paul Spooren <mail@aparcar.org> and Petr Štetiar <ynezz@true.cz> for example) -Alberto
On 22/06/21 2:07 am, Alberto Bursi wrote: > > > On 19/06/21 01:44, Arjun AK wrote: >> On 08/05/21 5:38 am, Arjun AK wrote: >>> On 06/01/21 9:03 pm, Arjun AK wrote: >>>> On 16/07/20 9:22 pm, Arjun AK wrote: >>>>> This script was expecting only add/remove events which has not been >>>>> the >>>>> case since Kernel 4.12 (which added bind/unbind). Bind events were >>>>> getting >>>>> treated as remove events which would cause hotplugged 3g modems to not >>>>> work. >>>>> >>>>> More info: >>>>> https://lkml.org/lkml/2018/12/23/128 >>>>> https://github.com/systemd/systemd/issues/8221 >>>>> >>>>> Signed-off-by: Arjun AK <arjunak234@gmail.com> >>>>> --- >>>>> package/network/utils/comgt/files/3g.usb | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/package/network/utils/comgt/files/3g.usb >>>>> b/package/network/utils/comgt/files/3g.usb >>>>> index 8f0d62ca83..9c7d07a0e6 100644 >>>>> --- a/package/network/utils/comgt/files/3g.usb >>>>> +++ b/package/network/utils/comgt/files/3g.usb >>>>> @@ -23,6 +23,8 @@ find_3g_iface() { >>>>> fi >>>>> } >>>>> +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 >>>>> + >>>>> case "$DEVICENAME" in >>>>> tty*) >>>>> [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || >>>>> exit 0 >>>>> >>>> >>>> Has this been merged? >>> >>> Can someone please merge this in? >> >> Its been over a year now, can someone merge this one in? >> >> - >> Arjun >> > > > > It does not seem there are many core developers able or interested in > maintaining these packages in core repository. > > You might accomplish more if you send a PR where you move the whole > comgt (and uim package) to the community packages repo and become > maintainer. > It was done for some other packages in a similar situation, and a few > core developers have been active on this migration and might be > interested (Paul Spooren <mail@aparcar.org> and Petr Štetiar > <ynezz@true.cz> for example) > > > -Alberto > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel You mean to move the packages into https://git.openwrt.org/feed/packages.git ? - Arjun
On 23/06/21 19:16, Arjun AK wrote: > On 22/06/21 2:07 am, Alberto Bursi wrote: >> >> >> On 19/06/21 01:44, Arjun AK wrote: >>> On 08/05/21 5:38 am, Arjun AK wrote: >>>> On 06/01/21 9:03 pm, Arjun AK wrote: >>>>> On 16/07/20 9:22 pm, Arjun AK wrote: >>>>>> This script was expecting only add/remove events which has not >>>>>> been the >>>>>> case since Kernel 4.12 (which added bind/unbind). Bind events were >>>>>> getting >>>>>> treated as remove events which would cause hotplugged 3g modems to >>>>>> not >>>>>> work. >>>>>> >>>>>> More info: >>>>>> https://lkml.org/lkml/2018/12/23/128 >>>>>> https://github.com/systemd/systemd/issues/8221 >>>>>> >>>>>> Signed-off-by: Arjun AK <arjunak234@gmail.com> >>>>>> --- >>>>>> package/network/utils/comgt/files/3g.usb | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/package/network/utils/comgt/files/3g.usb >>>>>> b/package/network/utils/comgt/files/3g.usb >>>>>> index 8f0d62ca83..9c7d07a0e6 100644 >>>>>> --- a/package/network/utils/comgt/files/3g.usb >>>>>> +++ b/package/network/utils/comgt/files/3g.usb >>>>>> @@ -23,6 +23,8 @@ find_3g_iface() { >>>>>> fi >>>>>> } >>>>>> +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 >>>>>> + >>>>>> case "$DEVICENAME" in >>>>>> tty*) >>>>>> [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || >>>>>> exit 0 >>>>>> >>>>> >>>>> Has this been merged? >>>> >>>> Can someone please merge this in? >>> >>> Its been over a year now, can someone merge this one in? >>> >>> - >>> Arjun >>> >> >> >> >> It does not seem there are many core developers able or interested in >> maintaining these packages in core repository. >> >> You might accomplish more if you send a PR where you move the whole >> comgt (and uim package) to the community packages repo and become >> maintainer. >> It was done for some other packages in a similar situation, and a few >> core developers have been active on this migration and might be >> interested (Paul Spooren <mail@aparcar.org> and Petr Štetiar >> <ynezz@true.cz> for example) >> >> >> -Alberto >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > You mean to move the packages into > https://git.openwrt.org/feed/packages.git ? > > - > Arjun > That is a mirror, the community packages feed where you must send PRs to is on Github. Also bugs on packages and whatnot are handled by Github issues tickets and not through OpenWrt bug report server. This is the link: https://github.com/openwrt/packages You send an email on mailing list to drop the package and open a PR in the packages repository to add it and become its maintainer. You can look at the recent email from Paul Spooren called [PATCH] dante: move to packages.git, and the PR he made in the packages repo as an example. -Alberto
diff --git a/package/network/utils/comgt/files/3g.usb b/package/network/utils/comgt/files/3g.usb index 8f0d62ca83..9c7d07a0e6 100644 --- a/package/network/utils/comgt/files/3g.usb +++ b/package/network/utils/comgt/files/3g.usb @@ -23,6 +23,8 @@ find_3g_iface() { fi } +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 + case "$DEVICENAME" in tty*) [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || exit 0
This script was expecting only add/remove events which has not been the case since Kernel 4.12 (which added bind/unbind). Bind events were getting treated as remove events which would cause hotplugged 3g modems to not work. More info: https://lkml.org/lkml/2018/12/23/128 https://github.com/systemd/systemd/issues/8221 Signed-off-by: Arjun AK <arjunak234@gmail.com> --- package/network/utils/comgt/files/3g.usb | 2 ++ 1 file changed, 2 insertions(+)