diff mbox series

[B/F/G/H/I/unstable,linux] UBUNTU: [Packaging]: Add kernel command line condition to hv-kvp-daemon service

Message ID 20210615224258.452471-1-dimitri.ledkov@canonical.com
State New
Headers show
Series [B/F/G/H/I/unstable,linux] UBUNTU: [Packaging]: Add kernel command line condition to hv-kvp-daemon service | expand

Commit Message

Dimitri John Ledkov June 15, 2021, 10:42 p.m. UTC
linux-cloud-tools-common ships a service for hyper-v hypervisor. It is
known to be prohibited on certain instance types. Add a kernel command
line condition to skip starting this service there.

BugLink: https://bugs.launchpad.net/bugs/1932081
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
cc: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
---
 This patch needs to go into bionic:linux focal:linux groovy:linux
 hirsute:linux impish:linux and unstable.

 focal:linux is desired first.

 debian/linux-cloud-tools-common.hv-kvp-daemon.service | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Bader June 18, 2021, 9:03 a.m. UTC | #1
On 16.06.21 00:42, Dimitri John Ledkov wrote:
> linux-cloud-tools-common ships a service for hyper-v hypervisor. It is
> known to be prohibited on certain instance types. Add a kernel command
> line condition to skip starting this service there.
> 
> BugLink: https://bugs.launchpad.net/bugs/1932081
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> cc: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> --- >   This patch needs to go into bionic:linux focal:linux groovy:linux
>   hirsute:linux impish:linux and unstable.
> 
>   focal:linux is desired first.
> 
>   debian/linux-cloud-tools-common.hv-kvp-daemon.service | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> index 571440344cb5..9f65063bfb1b 100644
> --- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> +++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> @@ -4,6 +4,7 @@
>   [Unit]
>   Description=Hyper-V KVP Protocol Daemon
>   ConditionVirtualization=microsoft
> +ConditionKernelCommandLine=!snapd_recovery_mode
>   DefaultDependencies=no
>   BindsTo=sys-devices-virtual-misc-vmbus\x21hv_kvp.device
>   After=sys-devices-virtual-misc-vmbus\x21hv_kvp.device systemd-remount-fs.service
>
Andy Whitcroft June 18, 2021, 9:04 a.m. UTC | #2
Acked-by: Andy Whitcroft <apw@canonical.com>

Though the description is poor.

-apw

On Tue, 15 Jun 2021 at 23:43, Dimitri John Ledkov <
dimitri.ledkov@canonical.com> wrote:

> linux-cloud-tools-common ships a service for hyper-v hypervisor. It is
> known to be prohibited on certain instance types. Add a kernel command
> line condition to skip starting this service there.
>
> BugLink: https://bugs.launchpad.net/bugs/1932081
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> cc: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
>  This patch needs to go into bionic:linux focal:linux groovy:linux
>  hirsute:linux impish:linux and unstable.
>
>  focal:linux is desired first.
>
>  debian/linux-cloud-tools-common.hv-kvp-daemon.service | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> index 571440344cb5..9f65063bfb1b 100644
> --- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> +++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> @@ -4,6 +4,7 @@
>  [Unit]
>  Description=Hyper-V KVP Protocol Daemon
>  ConditionVirtualization=microsoft
> +ConditionKernelCommandLine=!snapd_recovery_mode
>  DefaultDependencies=no
>  BindsTo=sys-devices-virtual-misc-vmbus\x21hv_kvp.device
>  After=sys-devices-virtual-misc-vmbus\x21hv_kvp.device
> systemd-remount-fs.service
> --
> 2.27.0
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Andrea Righi June 18, 2021, 9:06 a.m. UTC | #3
On Tue, Jun 15, 2021 at 11:42:58PM +0100, Dimitri John Ledkov wrote:
> linux-cloud-tools-common ships a service for hyper-v hypervisor. It is
> known to be prohibited on certain instance types. Add a kernel command
> line condition to skip starting this service there.
> 
> BugLink: https://bugs.launchpad.net/bugs/1932081
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> cc: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>

Applied to unstable/5.13.

Thanks,
-Andrea

> ---
>  This patch needs to go into bionic:linux focal:linux groovy:linux
>  hirsute:linux impish:linux and unstable.
> 
>  focal:linux is desired first.
> 
>  debian/linux-cloud-tools-common.hv-kvp-daemon.service | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> index 571440344cb5..9f65063bfb1b 100644
> --- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> +++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> @@ -4,6 +4,7 @@
>  [Unit]
>  Description=Hyper-V KVP Protocol Daemon
>  ConditionVirtualization=microsoft
> +ConditionKernelCommandLine=!snapd_recovery_mode
>  DefaultDependencies=no
>  BindsTo=sys-devices-virtual-misc-vmbus\x21hv_kvp.device
>  After=sys-devices-virtual-misc-vmbus\x21hv_kvp.device systemd-remount-fs.service
> -- 
> 2.27.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Stefan Bader June 18, 2021, 9:50 a.m. UTC | #4
On 16.06.21 00:42, Dimitri John Ledkov wrote:
> linux-cloud-tools-common ships a service for hyper-v hypervisor. It is
> known to be prohibited on certain instance types. Add a kernel command
> line condition to skip starting this service there.
> 
> BugLink: https://bugs.launchpad.net/bugs/1932081
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> cc: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
Applied to hirsute:linux. Thanks.

-Stefan

>   This patch needs to go into bionic:linux focal:linux groovy:linux
>   hirsute:linux impish:linux and unstable.
> 
>   focal:linux is desired first.
> 
>   debian/linux-cloud-tools-common.hv-kvp-daemon.service | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> index 571440344cb5..9f65063bfb1b 100644
> --- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> +++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> @@ -4,6 +4,7 @@
>   [Unit]
>   Description=Hyper-V KVP Protocol Daemon
>   ConditionVirtualization=microsoft
> +ConditionKernelCommandLine=!snapd_recovery_mode
>   DefaultDependencies=no
>   BindsTo=sys-devices-virtual-misc-vmbus\x21hv_kvp.device
>   After=sys-devices-virtual-misc-vmbus\x21hv_kvp.device systemd-remount-fs.service
>
diff mbox series

Patch

diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
index 571440344cb5..9f65063bfb1b 100644
--- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
+++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
@@ -4,6 +4,7 @@ 
 [Unit]
 Description=Hyper-V KVP Protocol Daemon
 ConditionVirtualization=microsoft
+ConditionKernelCommandLine=!snapd_recovery_mode
 DefaultDependencies=no
 BindsTo=sys-devices-virtual-misc-vmbus\x21hv_kvp.device
 After=sys-devices-virtual-misc-vmbus\x21hv_kvp.device systemd-remount-fs.service