diff mbox series

[committed] wwwdocs: gcc-11/changes.html: Editorial changes for RISC-V

Message ID 20210613055857.33BA133E8E@hamza.pair.com
State New
Headers show
Series [committed] wwwdocs: gcc-11/changes.html: Editorial changes for RISC-V | expand

Commit Message

Gerald Pfeifer June 13, 2021, 5:58 a.m. UTC
RISC-V has received a very nice section in the GCC 11 release notes
thanks to Kito.

This are a couple of editorial changes, completing some sentence and
breaking longer sentences among others, and a bit of grammar.

Pushed.

Gerald

---
 htdocs/gcc-11/changes.html | 33 ++++++++++++++++++---------------
 1 file changed, 18 insertions(+), 15 deletions(-)

Comments

Bernhard Reutner-Fischer June 13, 2021, 10:16 a.m. UTC | #1
On Sun, 13 Jun 2021 07:58:50 +0200 (CEST)
Gerald Pfeifer <gerald@pfeifer.com> wrote:

> RISC-V has received a very nice section in the GCC 11 release notes
> thanks to Kito.
> 
> This are a couple of editorial changes, completing some sentence and
> breaking longer sentences among others, and a bit of grammar.
> 
> Pushed.
> 
> Gerald
> 
> ---
>  htdocs/gcc-11/changes.html | 33 ++++++++++++++++++---------------
>  1 file changed, 18 insertions(+), 15 deletions(-)
> 
> diff --git a/htdocs/gcc-11/changes.html b/htdocs/gcc-11/changes.html
> index 97606174..491b6b71 100644
> --- a/htdocs/gcc-11/changes.html
> +++ b/htdocs/gcc-11/changes.html
> @@ -953,33 +953,36 @@ You may also want to check out our

> +  <li>Legacy architecture extension test macros like
> +      <code>__riscv_atomic</code> are deprecated, but will still be
> +      supported for at least 2 release cycles.

I didn't look if we can annotate macros as deprecated to emit a warning
on use nor if they are marked as such.

>    </li>
>    <li>Support IFUNC for <code>riscv*-*-linux*</code>.</li>

> +  <li>Add new option <code>-misa-spec=*</code> to control ISA spec version.
> +      This controls the default version of each extensions.
> +      It defaults to 2.2.</li>

Is "each extensions" in plural really correct gramatically?
"default version of extensions" or
"default version of each extension"
And is "version of" correct WRT the code or does the code control the
version "for extensions"?

I.e.
"to control the default ISA spec version for extensions" if that's what
the option does?

thanks,
Gerald Pfeifer June 14, 2021, 7:41 a.m. UTC | #2
On Sun, 13 Jun 2021, Bernhard Reutner-Fischer wrote:
>> +  <li>Add new option <code>-misa-spec=*</code> to control ISA spec version.
>> +      This controls the default version of each extensions.
>> +      It defaults to 2.2.</li>
> Is "each extensions" in plural really correct gramatically?
> "default version of extensions" or
> "default version of each extension"

No, that one escaped my edits - good catch, Bernhard!

> And is "version of" correct WRT the code or does the code control the 
> version "for extensions"?
> 
> I.e.
> "to control the default ISA spec version for extensions" if that's what
> the option does?

Let's see what Kito advises. Once we know, feel free to make a change or
advise and I'll do.

Thanks,
Gerald
Kito Cheng June 14, 2021, 5:23 p.m. UTC | #3
Hi Gerald:

Thanks your patch, my grammar is really...weak :p

Hi Bernhard:

>> +  <li>Add new option <code>-misa-spec=*</code> to control ISA spec version.
>> +      This controls the default version of each extensions.
>> +      It defaults to 2.2.</li>
> Is "each extensions" in plural really correct gramatically?
> "default version of extensions" or
> "default version of each extension"
> And is "version of" correct WRT the code or does the code control the
> version "for extensions"?
>
> I.e.
> "to control the default ISA spec version for extensions" if that's what
> the option does?

ISA spec version control a set of default version, like that:

2.2 = { i-ext=2.0, m-ext=2.0, a-ext=2.0 f-ext=2.0 ..}
20190608 = { i-ext=2.1, m-ext=2.0, a-ext=2.0 f-ext=2.2 ...}
20191213 = { i-ext=2.1, m-ext=2.0, a-ext=2.1 f-ext=2.2 ...}

so...I think
"to control the default ISA spec version for extensions"
should be right, feel free to commit patches to fix the
 gramm issue, I will be very grateful :)


On Mon, Jun 14, 2021 at 3:41 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> On Sun, 13 Jun 2021, Bernhard Reutner-Fischer wrote:
> >> +  <li>Add new option <code>-misa-spec=*</code> to control ISA spec version.
> >> +      This controls the default version of each extensions.
> >> +      It defaults to 2.2.</li>
> > Is "each extensions" in plural really correct gramatically?
> > "default version of extensions" or
> > "default version of each extension"
>
> No, that one escaped my edits - good catch, Bernhard!
>
> > And is "version of" correct WRT the code or does the code control the
> > version "for extensions"?
> >
> > I.e.
> > "to control the default ISA spec version for extensions" if that's what
> > the option does?
>
> Let's see what Kito advises. Once we know, feel free to make a change or
> advise and I'll do.
>
> Thanks,
> Gerald
diff mbox series

Patch

diff --git a/htdocs/gcc-11/changes.html b/htdocs/gcc-11/changes.html
index 97606174..491b6b71 100644
--- a/htdocs/gcc-11/changes.html
+++ b/htdocs/gcc-11/changes.html
@@ -953,33 +953,36 @@  You may also want to check out our
 <ul>
   <li>Support address sanitizer for RISC-V.</li>
   <li>Support big-endian for RISC-V, thanks to Marcus Comstedt.</li>
-  <li>Implement new style of architecture extension test macros,
-      each architecture extension has corresponding feature test macro, which
-      could use to test its existence and version information.
+  <li>Implement new style of architecture extension test macros:
+      each architecture extension has a corresponding feature test macro,
+      which can be used to test its existence and version information.
   </li>
-  <li>Legacy architecture extension test macro like <code>__riscv_atomic</code>,
-       are deprecated, but it will still supported for at least 2 release cycles.
+  <li>Legacy architecture extension test macros like
+      <code>__riscv_atomic</code> are deprecated, but will still be
+      supported for at least 2 release cycles.
   </li>
   <li>Support IFUNC for <code>riscv*-*-linux*</code>.</li>
-  <li>Add new option -misa-spec=* to control ISA spec version, default is 2.2,
-      this option could control the default version of each extensions.</li>
-  <li>Introduce <code>--with-multilib-generator</code> to configure time option,
-      this option could flexible config multi-lib settings, syntax is same as
-      RISC-V's <code>multilib-generator</code>.
+  <li>Add new option <code>-misa-spec=*</code> to control ISA spec version.
+      This controls the default version of each extensions.
+      It defaults to 2.2.</li>
+  <li>Introduce the <code>--with-multilib-generator</code> configure time
+      option.
+      This allows for flexible config multi-lib settings. Its syntax is
+      the same as RISC-V's <code>multilib-generator</code>.
   </li>
   <li>Extend the sytax for <code>multilib-generator</code>, support expansion
       operator <code>*</code> to reduce the complexity of complicated multi-lib
-      re-use rule.
+      re-use rules.
   </li>
-  <li>Support <code>-mcpu=*</code> option, the behavior is aligned to RISC-V
-      clang/LLVM, it will set pipeline model and architecture extension, like
+  <li>Support <code>-mcpu=*</code> option aligned with RISC-V clang/LLVM.
+      It sets the pipeline model and architecture extensions, like
       <code>-mtune=*</code> plus <code>-march=*</code>.
   </li>
   <li>Support for TLS stack protector canary access, thanks to Cooper Qu.
   </li>
   <li>Support <code>__builtin_thread_pointer</code> for RISC-V.</li>
-  <li>Introduce <code>shorten_memrefs</code> optimization, which could reduce the
-      code size for memory access, thanks to Craig Blackmore.
+  <li>Introduce <code>shorten_memrefs</code> optimization, which reduces
+      the code size for memory access, thanks to Craig Blackmore.
   </li>
 </ul>