diff mbox series

tools: fix ninja build dependency

Message ID 20210612121206.25751-1-bjorn@mork.no
State Superseded
Headers show
Series tools: fix ninja build dependency | expand

Commit Message

Bjørn Mork June 12, 2021, 12:12 p.m. UTC
Fixing this build error:

 make[3]: Entering directory '/p/tools/ccache'
 MAKEFLAGS="" /p/staging_dir/host/bin/ninja  -j1 -C /p/build_dir/host/ccache-4.2.1
 bash: /p/staging_dir/host/bin/ninja: No such file or directory
 make[3]: *** [Makefile:43: /p/build_dir/host/ccache-4.2.1/.built] Error 127
 make[3]: Leaving directory '/p/tools/ccache'
 time: tools/ccache/compile#0.03#0.00#0.04
     ERROR: tools/ccache failed to build.
 make[2]: *** [tools/Makefile:158: tools/ccache/compile] Error 1

Fixes: 97258f53634d ("build: add ninja build tool and make it available for cmake")
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 tools/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Blumenstingl June 12, 2021, 12:32 p.m. UTC | #1
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
On Sat, Jun 12, 2021 at 2:15 PM Bjørn Mork <bjorn@mork.no> wrote:
>
> Fixing this build error:
>
>  make[3]: Entering directory '/p/tools/ccache'
>  MAKEFLAGS="" /p/staging_dir/host/bin/ninja  -j1 -C /p/build_dir/host/ccache-4.2.1
>  bash: /p/staging_dir/host/bin/ninja: No such file or directory
>  make[3]: *** [Makefile:43: /p/build_dir/host/ccache-4.2.1/.built] Error 127
>  make[3]: Leaving directory '/p/tools/ccache'
>  time: tools/ccache/compile#0.03#0.00#0.04
>      ERROR: tools/ccache failed to build.
>  make[2]: *** [tools/Makefile:158: tools/ccache/compile] Error 1
>
> Fixes: 97258f53634d ("build: add ninja build tool and make it available for cmake")
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Felix pushed a fix like 1.5 hours ago: [0]
to me your patch looks identical to Felix'


Best regards,
Martin


[0] https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=d45baa860ffc79ae1cf68fceb94990e39bb06bab
Bjørn Mork June 12, 2021, 1:27 p.m. UTC | #2
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> Felix pushed a fix like 1.5 hours ago: [0]
> to me your patch looks identical to Felix'

Great! That's the result of being interrupted between preparing a patch
and sending it.  I should have pulled again.  Nice timing :-)

Anyway, happy to see it fixed. And to see us both choosing the exact
same place to put this.


Bjørn
diff mbox series

Patch

diff --git a/tools/Makefile b/tools/Makefile
index 47a82fd23782..dccf298af6ee 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -43,7 +43,7 @@  $(curdir)/b43-tools/compile := $(curdir)/bison/compile
 $(curdir)/bc/compile := $(curdir)/bison/compile $(curdir)/libtool/compile
 $(curdir)/bison/compile := $(curdir)/flex/compile
 $(curdir)/cbootimage/compile += $(curdir)/automake/compile
-$(curdir)/cmake/compile += $(curdir)/libressl/compile
+$(curdir)/cmake/compile += $(curdir)/libressl/compile $(curdir)/ninja/compile
 $(curdir)/dosfstools/compile := $(curdir)/autoconf/compile $(curdir)/automake/compile
 $(curdir)/e2fsprogs/compile := $(curdir)/libtool/compile
 $(curdir)/fakeroot/compile := $(curdir)/libtool/compile