| Message ID | 4af6a7138fbd400e458352f6b384115f4adc4301.1623380367.git.fthain@linux-m68k.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | powerpc/tau: Remove redundant parameter in alloc_workqueue() call | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (c53db722ec7ab3ebf29ecf61e922820f31e5284b) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
Redundant with what ? Do you mean superfluous ? Le 11/06/2021 à 04:59, Finn Thain a écrit : > This avoids an (optional) compiler warning: > > arch/powerpc/kernel/tau_6xx.c: In function 'TAU_init': > arch/powerpc/kernel/tau_6xx.c:204:30: error: too many arguments for format [-Werror=format-extra-args] > tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1, 0); > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Fixes: b1c6a0a10bfa ("powerpc/tau: Convert from timer to workqueue") > Signed-off-by: Finn Thain <fthain@linux-m68k.org> > --- > arch/powerpc/kernel/tau_6xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c > index 6c31af7f4fa8..b9a047d92ec0 100644 > --- a/arch/powerpc/kernel/tau_6xx.c > +++ b/arch/powerpc/kernel/tau_6xx.c > @@ -201,7 +201,7 @@ static int __init TAU_init(void) > tau_int_enable = IS_ENABLED(CONFIG_TAU_INT) && > !strcmp(cur_cpu_spec->platform, "ppc750"); > > - tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1, 0); > + tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1); > if (!tau_workq) > return -ENOMEM; > >
diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c index 6c31af7f4fa8..b9a047d92ec0 100644 --- a/arch/powerpc/kernel/tau_6xx.c +++ b/arch/powerpc/kernel/tau_6xx.c @@ -201,7 +201,7 @@ static int __init TAU_init(void) tau_int_enable = IS_ENABLED(CONFIG_TAU_INT) && !strcmp(cur_cpu_spec->platform, "ppc750"); - tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1, 0); + tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1); if (!tau_workq) return -ENOMEM;
This avoids an (optional) compiler warning: arch/powerpc/kernel/tau_6xx.c: In function 'TAU_init': arch/powerpc/kernel/tau_6xx.c:204:30: error: too many arguments for format [-Werror=format-extra-args] tau_workq = alloc_workqueue("tau", WQ_UNBOUND, 1, 0); Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Fixes: b1c6a0a10bfa ("powerpc/tau: Convert from timer to workqueue") Signed-off-by: Finn Thain <fthain@linux-m68k.org> --- arch/powerpc/kernel/tau_6xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)