| Message ID | 20210609234819.1860554-2-mmayer@broadcom.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd-utils-2.1.2: ubihealthd depends on ubifs support | expand |
Hallo Markus, Am Do., 10. Juni 2021 um 01:54 Uhr schrieb Markus Mayer via buildroot <buildroot@busybox.net>: > > ubihealthd is only being built, if mtd-utils are being built > --with-ubifs. Reflect that dependency within buildroot. > This seems to fix the issue reported to the commiter: http://lists.busybox.net/pipermail/buildroot/2021-June/311951.html > Signed-off-by: Markus Mayer <mmayer@broadcom.com> > --- > package/mtd/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/mtd/Config.in b/package/mtd/Config.in > index c7ad3b3cdc9c..64a7ae19a7e2 100644 > --- a/package/mtd/Config.in > +++ b/package/mtd/Config.in > @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT > > config BR2_PACKAGE_MTD_UBIHEALTHD > bool "ubihealthd" > + depends on BR2_PACKAGE_MTD_UBIFS_UTILS > default y > > config BR2_PACKAGE_MTD_UBIMKVOL Thanks
On Wed, 9 Jun 2021 at 21:36, Heiko Thiery <heiko.thiery@gmail.com> wrote: > > ubihealthd is only being built, if mtd-utils are being built > > --with-ubifs. Reflect that dependency within buildroot. > > > > This seems to fix the issue reported to the commiter: > http://lists.busybox.net/pipermail/buildroot/2021-June/311951.html Yes, it does look like it would address this issue. Have you been able to confirm that it addresses the problem? If so, can you reply with a Tested-by? Thanks, -Markus > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> > > --- > > package/mtd/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/mtd/Config.in b/package/mtd/Config.in > > index c7ad3b3cdc9c..64a7ae19a7e2 100644 > > --- a/package/mtd/Config.in > > +++ b/package/mtd/Config.in > > @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT > > > > config BR2_PACKAGE_MTD_UBIHEALTHD > > bool "ubihealthd" > > + depends on BR2_PACKAGE_MTD_UBIFS_UTILS > > default y > > > > config BR2_PACKAGE_MTD_UBIMKVOL > > Thanks > -- > Heiko
Hi Markus, Am Do., 10. Juni 2021 um 01:54 Uhr schrieb Markus Mayer via buildroot <buildroot@busybox.net>: > > ubihealthd is only being built, if mtd-utils are being built > --with-ubifs. Reflect that dependency within buildroot. > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> Tested-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > package/mtd/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/mtd/Config.in b/package/mtd/Config.in > index c7ad3b3cdc9c..64a7ae19a7e2 100644 > --- a/package/mtd/Config.in > +++ b/package/mtd/Config.in > @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT > > config BR2_PACKAGE_MTD_UBIHEALTHD > bool "ubihealthd" > + depends on BR2_PACKAGE_MTD_UBIFS_UTILS > default y > > config BR2_PACKAGE_MTD_UBIMKVOL Thanks
Markus, All, On 2021-06-09 16:48 -0700, Markus Mayer via buildroot spake thusly: > ubihealthd is only being built, if mtd-utils are being built > --with-ubifs. Reflect that dependency within buildroot. > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> > --- > package/mtd/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/mtd/Config.in b/package/mtd/Config.in > index c7ad3b3cdc9c..64a7ae19a7e2 100644 > --- a/package/mtd/Config.in > +++ b/package/mtd/Config.in > @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT > > config BR2_PACKAGE_MTD_UBIHEALTHD > bool "ubihealthd" > + depends on BR2_PACKAGE_MTD_UBIFS_UTILS # make check-package package/mtd/Config.in:143: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files) Applied to master with the above fixed, thanks. Regards, Yann E. MORIN. > default y > > config BR2_PACKAGE_MTD_UBIMKVOL > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/mtd/Config.in b/package/mtd/Config.in index c7ad3b3cdc9c..64a7ae19a7e2 100644 --- a/package/mtd/Config.in +++ b/package/mtd/Config.in @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT config BR2_PACKAGE_MTD_UBIHEALTHD bool "ubihealthd" + depends on BR2_PACKAGE_MTD_UBIFS_UTILS default y config BR2_PACKAGE_MTD_UBIMKVOL
ubihealthd is only being built, if mtd-utils are being built --with-ubifs. Reflect that dependency within buildroot. Signed-off-by: Markus Mayer <mmayer@broadcom.com> --- package/mtd/Config.in | 1 + 1 file changed, 1 insertion(+)