diff mbox series

[1/1] package/rpcbind fix version number

Message ID 20210608085332.19296-1-br015@umbiko.net
State Accepted
Headers show
Series [1/1] package/rpcbind fix version number | expand

Commit Message

Andreas Ziegler June 8, 2021, 8:53 a.m. UTC
Commit d13b292cec8166c4712cf4a0defbeee827ffaf78 introduced a patch for rpcbind but also changed the version number to a non-existing value. 

Change rpcbind to last released version and adapt hash value. 

Signed-off-by: Andreas Ziegler <br015@umbiko.net>
---
 package/rpcbind/rpcbind.hash | 2 +-
 package/rpcbind/rpcbind.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Baruch Siach June 8, 2021, 9:21 a.m. UTC | #1
Hi Andreas,

On Tue, Jun 08 2021, Andreas Ziegler wrote:
> Commit d13b292cec8166c4712cf4a0defbeee827ffaf78 introduced a patch for
> rpcbind but also changed the version number to a non-existing value.
>
> Change rpcbind to last released version and adapt hash value. 
>
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> ---
>  package/rpcbind/rpcbind.hash | 2 +-
>  package/rpcbind/rpcbind.mk   | 2 +-

The comment in 0001-Remove-yellow-pages-support.patch also mentions this
non existing version number.

baruch

>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpcbind/rpcbind.hash b/package/rpcbind/rpcbind.hash
> index 1960b86c13..6ab7d89265 100644
> --- a/package/rpcbind/rpcbind.hash
> +++ b/package/rpcbind/rpcbind.hash
> @@ -1,3 +1,3 @@
>  # Locally computed:
> -sha256 2ce360683963b35c19c43f0ee2c7f18aa5b81ef41c3fdbd15ffcb00b8bffda7a  rpcbind-1.2.5.tar.bz2
> +sha256 5613746489cae5ae23a443bb85c05a11741a5f12c8f55d2bb5e83b9defeee8de  rpcbind-1.2.6.tar.bz2
>  sha256 2b9477d2f4ab277b29702958f0058546edc120aae4b5fb8b8d1a9652104e1ba3  COPYING
> diff --git a/package/rpcbind/rpcbind.mk b/package/rpcbind/rpcbind.mk
> index fea2103794..d9f25e698e 100644
> --- a/package/rpcbind/rpcbind.mk
> +++ b/package/rpcbind/rpcbind.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -RPCBIND_VERSION = 1.3.2
> +RPCBIND_VERSION = 1.2.6
>  RPCBIND_SITE = http://downloads.sourceforge.net/project/rpcbind/rpcbind/$(RPCBIND_VERSION)
>  RPCBIND_SOURCE = rpcbind-$(RPCBIND_VERSION).tar.bz2
>  RPCBIND_LICENSE = BSD-3-Clause
Thomas Petazzoni June 8, 2021, 10:02 a.m. UTC | #2
Hello,

On Tue,  8 Jun 2021 10:53:32 +0200
Andreas Ziegler <br015@umbiko.net> wrote:

> Commit d13b292cec8166c4712cf4a0defbeee827ffaf78 introduced a patch for rpcbind but also changed the version number to a non-existing value. 
> 
> Change rpcbind to last released version and adapt hash value. 
> 
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>

Indeed. This is weird. Petr, do you know where/how you found this 1.3.2
version of rpcbind ?

Thomas
Petr Vorel June 8, 2021, 8:08 p.m. UTC | #3
Hi Thomas, Andreas,

> Hello,

> On Tue,  8 Jun 2021 10:53:32 +0200
> Andreas Ziegler <br015@umbiko.net> wrote:

> > Commit d13b292cec8166c4712cf4a0defbeee827ffaf78 introduced a patch for rpcbind but also changed the version number to a non-existing value. 

> > Change rpcbind to last released version and adapt hash value. 

> > Signed-off-by: Andreas Ziegler <br015@umbiko.net>

> Indeed. This is weird. Petr, do you know where/how you found this 1.3.2
> version of rpcbind ?
I'm sorry, my commit d13b292cec was completely wrong. I got confused with
libtirpc update. I usually test well my patches, because I keep basic errors,
this one I didn't test, which would catch both errors.

Yes, correct version 1.2.6. I also didn't update hash, thank you Andreas for
fixing both.

Kind regards,
Petr

> Thomas
Petr Vorel June 8, 2021, 8:11 p.m. UTC | #4
Hi all,

> Hi Andreas,

> On Tue, Jun 08 2021, Andreas Ziegler wrote:
> > Commit d13b292cec8166c4712cf4a0defbeee827ffaf78 introduced a patch for
> > rpcbind but also changed the version number to a non-existing value.

> > Change rpcbind to last released version and adapt hash value. 

> > Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> > ---
> >  package/rpcbind/rpcbind.hash | 2 +-
> >  package/rpcbind/rpcbind.mk   | 2 +-

> The comment in 0001-Remove-yellow-pages-support.patch also mentions this
> non existing version number.
+1

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Thanks for fixing my error.

Kind regards,
Petr

> baruch
Yann E. MORIN June 14, 2021, 8:02 p.m. UTC | #5
Andreas, All,

On 2021-06-08 10:53 +0200, Andreas Ziegler spake thusly:
> Commit d13b292cec8166c4712cf4a0defbeee827ffaf78 introduced a patch for rpcbind but also changed the version number to a non-existing value. 
> 
> Change rpcbind to last released version and adapt hash value. 
> 
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>

Applied to master, with the version string also fixed in the patch, as
noticed by Baruch, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/rpcbind/rpcbind.hash | 2 +-
>  package/rpcbind/rpcbind.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/rpcbind/rpcbind.hash b/package/rpcbind/rpcbind.hash
> index 1960b86c13..6ab7d89265 100644
> --- a/package/rpcbind/rpcbind.hash
> +++ b/package/rpcbind/rpcbind.hash
> @@ -1,3 +1,3 @@
>  # Locally computed:
> -sha256 2ce360683963b35c19c43f0ee2c7f18aa5b81ef41c3fdbd15ffcb00b8bffda7a  rpcbind-1.2.5.tar.bz2
> +sha256 5613746489cae5ae23a443bb85c05a11741a5f12c8f55d2bb5e83b9defeee8de  rpcbind-1.2.6.tar.bz2
>  sha256 2b9477d2f4ab277b29702958f0058546edc120aae4b5fb8b8d1a9652104e1ba3  COPYING
> diff --git a/package/rpcbind/rpcbind.mk b/package/rpcbind/rpcbind.mk
> index fea2103794..d9f25e698e 100644
> --- a/package/rpcbind/rpcbind.mk
> +++ b/package/rpcbind/rpcbind.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -RPCBIND_VERSION = 1.3.2
> +RPCBIND_VERSION = 1.2.6
>  RPCBIND_SITE = http://downloads.sourceforge.net/project/rpcbind/rpcbind/$(RPCBIND_VERSION)
>  RPCBIND_SOURCE = rpcbind-$(RPCBIND_VERSION).tar.bz2
>  RPCBIND_LICENSE = BSD-3-Clause
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/rpcbind/rpcbind.hash b/package/rpcbind/rpcbind.hash
index 1960b86c13..6ab7d89265 100644
--- a/package/rpcbind/rpcbind.hash
+++ b/package/rpcbind/rpcbind.hash
@@ -1,3 +1,3 @@ 
 # Locally computed:
-sha256 2ce360683963b35c19c43f0ee2c7f18aa5b81ef41c3fdbd15ffcb00b8bffda7a  rpcbind-1.2.5.tar.bz2
+sha256 5613746489cae5ae23a443bb85c05a11741a5f12c8f55d2bb5e83b9defeee8de  rpcbind-1.2.6.tar.bz2
 sha256 2b9477d2f4ab277b29702958f0058546edc120aae4b5fb8b8d1a9652104e1ba3  COPYING
diff --git a/package/rpcbind/rpcbind.mk b/package/rpcbind/rpcbind.mk
index fea2103794..d9f25e698e 100644
--- a/package/rpcbind/rpcbind.mk
+++ b/package/rpcbind/rpcbind.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-RPCBIND_VERSION = 1.3.2
+RPCBIND_VERSION = 1.2.6
 RPCBIND_SITE = http://downloads.sourceforge.net/project/rpcbind/rpcbind/$(RPCBIND_VERSION)
 RPCBIND_SOURCE = rpcbind-$(RPCBIND_VERSION).tar.bz2
 RPCBIND_LICENSE = BSD-3-Clause