| Message ID | 20210601105253.33960-1-ivan.hu@canonical.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | uefirttime: set test time for the settime and setwakeuptime tests(LP: #1929509) | expand |
On 01/06/2021 11:52, Ivan Hu wrote: > Set test time for settime and setwakeuptime unsupported tests, in case > we won't get EFI_INVALID_PARAMETER returned instead. > > Signed-off-by: Ivan Hu <ivan.hu@canonical.com> > --- > src/uefi/uefirttime/uefirttime.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c > index 41503843..2fa19040 100644 > --- a/src/uefi/uefirttime/uefirttime.c > +++ b/src/uefi/uefirttime/uefirttime.c > @@ -1272,6 +1272,12 @@ static int uefirttime_test38(fwts_framework *fw) > } else > fwts_skipped(fw, "GetTime runtime service supported, skip test."); > > + /* set test time for settime and setwakeuptime tests */ > + memset(&efi_time, 0, sizeof(EFI_TIME)); Not sure, but is the sizeof wrong here? Should it be sizeof(efi_time) ? > + efi_time.Year = 2000; > + efi_time.Month = 1; > + efi_time.Day = 1; > + > if (!(runtimeservicessupported & EFI_RT_SUPPORTED_SET_TIME)) { > settime.Time = &efi_time; > status = ~0ULL; >
On 2021-06-01 4:52 a.m., Ivan Hu wrote: > Set test time for settime and setwakeuptime unsupported tests, in case > we won't get EFI_INVALID_PARAMETER returned instead. > > Signed-off-by: Ivan Hu <ivan.hu@canonical.com> > --- > src/uefi/uefirttime/uefirttime.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c > index 41503843..2fa19040 100644 > --- a/src/uefi/uefirttime/uefirttime.c > +++ b/src/uefi/uefirttime/uefirttime.c > @@ -1272,6 +1272,12 @@ static int uefirttime_test38(fwts_framework *fw) > } else > fwts_skipped(fw, "GetTime runtime service supported, skip test."); > > + /* set test time for settime and setwakeuptime tests */ > + memset(&efi_time, 0, sizeof(EFI_TIME)); > + efi_time.Year = 2000; > + efi_time.Month = 1; > + efi_time.Day = 1; > + > if (!(runtimeservicessupported & EFI_RT_SUPPORTED_SET_TIME)) { > settime.Time = &efi_time; > status = ~0ULL; > There are trailing white spaces that should be removed: Applying: uefirttime: set test time for the settime and setwakeuptime tests(LP: #1929509) .git/rebase-apply/patch:13: trailing whitespace. /* set test time for settime and setwakeuptime tests */ .git/rebase-apply/patch:16: trailing whitespace. efi_time.Month = 1; warning: 2 lines add whitespace errors.
diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c index 41503843..2fa19040 100644 --- a/src/uefi/uefirttime/uefirttime.c +++ b/src/uefi/uefirttime/uefirttime.c @@ -1272,6 +1272,12 @@ static int uefirttime_test38(fwts_framework *fw) } else fwts_skipped(fw, "GetTime runtime service supported, skip test."); + /* set test time for settime and setwakeuptime tests */ + memset(&efi_time, 0, sizeof(EFI_TIME)); + efi_time.Year = 2000; + efi_time.Month = 1; + efi_time.Day = 1; + if (!(runtimeservicessupported & EFI_RT_SUPPORTED_SET_TIME)) { settime.Time = &efi_time; status = ~0ULL;
Set test time for settime and setwakeuptime unsupported tests, in case we won't get EFI_INVALID_PARAMETER returned instead. Signed-off-by: Ivan Hu <ivan.hu@canonical.com> --- src/uefi/uefirttime/uefirttime.c | 6 ++++++ 1 file changed, 6 insertions(+)