| Message ID | 20210507094304.21719-1-heiko.thiery@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] package/dhcp: add host-gawk optional dependency | expand |
On 07/05/2021 11:43, Heiko Thiery wrote: > On hosts where gawk is not available, it is not possible to build the > package with server option (BR2_PACKAGE_DHCP_SERVER). > The build goes through without errors but the binaries are not created > and installed. The reason is that autotools cannot find gawk. > > Fixes: Bug 13781 > > Reported-by: Kay Jeschonneck <kay.jeschonneck@airbus.com> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> Applied to master, thanks. Regards, Arnout > --- > v2: > - set to correct bug number > > package/dhcp/dhcp.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk > index 988c7792dc..8d7157f357 100644 > --- a/package/dhcp/dhcp.mk > +++ b/package/dhcp/dhcp.mk > @@ -55,6 +55,7 @@ define DHCP_INSTALL_LIBS > endef > > ifeq ($(BR2_PACKAGE_DHCP_SERVER),y) > +DHCP_DEPENDENCIES += host-gawk > define DHCP_INSTALL_CTL_LIBS > $(MAKE) -C $(@D)/dhcpctl install-exec DESTDIR=$(TARGET_DIR) > endef >
>>>>> "Heiko" == Heiko Thiery <heiko.thiery@gmail.com> writes: > On hosts where gawk is not available, it is not possible to build the > package with server option (BR2_PACKAGE_DHCP_SERVER). > The build goes through without errors but the binaries are not created > and installed. The reason is that autotools cannot find gawk. > Fixes: Bug 13781 > Reported-by: Kay Jeschonneck <kay.jeschonneck@airbus.com> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > v2: > - set to correct bug number Committed to 2021.02.x, thanks.
diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk index 988c7792dc..8d7157f357 100644 --- a/package/dhcp/dhcp.mk +++ b/package/dhcp/dhcp.mk @@ -55,6 +55,7 @@ define DHCP_INSTALL_LIBS endef ifeq ($(BR2_PACKAGE_DHCP_SERVER),y) +DHCP_DEPENDENCIES += host-gawk define DHCP_INSTALL_CTL_LIBS $(MAKE) -C $(@D)/dhcpctl install-exec DESTDIR=$(TARGET_DIR) endef
On hosts where gawk is not available, it is not possible to build the package with server option (BR2_PACKAGE_DHCP_SERVER). The build goes through without errors but the binaries are not created and installed. The reason is that autotools cannot find gawk. Fixes: Bug 13781 Reported-by: Kay Jeschonneck <kay.jeschonneck@airbus.com> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- v2: - set to correct bug number package/dhcp/dhcp.mk | 1 + 1 file changed, 1 insertion(+)