| Message ID | 20210518125748.26823-4-o.rempel@pengutronix.de |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2,1/4] dt-bindings: touchscreen: Convert resistive-adc-touch binding to json schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 18 May 2021 14:57:47 +0200, Oleksij Rempel wrote: > For pressure calculation based on plates resistance we need some additional > properties: > - z1 and z2 channels with additional measurements between plates > - actual resistance of the touchscreen. Currently we use only > X-resistance. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../bindings/input/touchscreen/resistive-adc-touch.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.example.dt.yaml: resistive_touch: io-channels: [[4294967295, 1], [4294967295, 2], [4294967295, 3], [4294967295, 4]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.example.dt.yaml: resistive_touch: io-channels: Additional items are not allowed ([4294967295, 4] was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.example.dt.yaml: resistive_touch: io-channel-names:2: 'pressure' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.example.dt.yaml: resistive_touch: io-channel-names: ['x', 'y', 'z1', 'z2'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.example.dt.yaml: resistive_touch: io-channel-names: Additional items are not allowed ('z2' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml See https://patchwork.ozlabs.org/patch/1480237 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml b/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml index 53df21a6589e..538c3b1ef1e1 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml @@ -43,6 +43,7 @@ properties: touchscreen-inverted-y: true touchscreen-swapped-x-y: true touchscreen-min-pressure: true + touchscreen-x-plate-ohms: true additionalProperties: false @@ -59,3 +60,11 @@ examples: io-channels = <&adc 24>, <&adc 25>, <&adc 26>; io-channel-names = "x", "y", "pressure"; }; + - | + resistive_touch { + compatible = "resistive-adc-touch"; + touchscreen-min-pressure = <50000>; + io-channels = <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>; + io-channel-names = "x", "y", "z1", "z2"; + touchscreen-x-plate-ohms = <800>; + };
For pressure calculation based on plates resistance we need some additional properties: - z1 and z2 channels with additional measurements between plates - actual resistance of the touchscreen. Currently we use only X-resistance. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../bindings/input/touchscreen/resistive-adc-touch.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)