| Message ID | 20210513134941.27656-1-mdoucha@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Skip tmpfs in all-filesystem shell tests | expand |
Hi! > All-filesystem shell tests like LVM currently don't support tmpfs. Remove it > from tst_supported_fs helper output for now. git grep shows that we use that in zram01.sh and *_lvm.sh scripts, in both cases tmpfs does not make any sense... Looks good for the release: Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Hi Martin, Cyril > Hi! > > All-filesystem shell tests like LVM currently don't support tmpfs. Remove it > > from tst_supported_fs helper output for now. > git grep shows that we use that in zram01.sh and *_lvm.sh scripts, in > both cases tmpfs does not make any sense... > Looks good for the release: Reviewed-by: Petr Vorel <pvorel@suse.cz> Good point, thanks! I also think it's good for a release. But in the future I'd like to take single NFS test and run it in all filesystems. Currently there is ongoing work to fix tmpfs on NFS. So we might need to move this skip in the future to respected tests (zram01.sh and *_lvm.sh). And for that we will have to implement skip filesystem for shell (or just skip it "manually"). Kind regards, Petr
Hi! > Good point, thanks! I also think it's good for a release. But in the future I'd > like to take single NFS test and run it in all filesystems. Currently there is > ongoing work to fix tmpfs on NFS. So we might need to move this skip in the > future to respected tests (zram01.sh and *_lvm.sh). And for that we will have > to implement skip filesystem for shell (or just skip it "manually"). Sure, we should implement a proper skiplist later on once it's needed. Pushed, thanks.
diff --git a/testcases/lib/tst_supported_fs.c b/testcases/lib/tst_supported_fs.c index 154b12ece..43eac194f 100644 --- a/testcases/lib/tst_supported_fs.c +++ b/testcases/lib/tst_supported_fs.c @@ -22,6 +22,7 @@ static void usage(void) int main(int argc, char *argv[]) { + const char *skiplist[] = {"tmpfs", NULL}; const char *const *filesystems; int i; @@ -39,7 +40,7 @@ int main(int argc, char *argv[]) if (argv[1]) return !tst_fs_is_supported(argv[1]); - filesystems = tst_get_supported_fs_types(NULL); + filesystems = tst_get_supported_fs_types(skiplist); for (i = 0; filesystems[i]; i++) printf("%s\n", filesystems[i]);
All-filesystem shell tests like LVM currently don't support tmpfs. Remove it from tst_supported_fs helper output for now. Signed-off-by: Martin Doucha <mdoucha@suse.cz> --- testcases/lib/tst_supported_fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)