mbox series

[net-next,0/3] mptcp: improve MSG_* flags handling

Message ID cover.1618502178.git.pabeni@redhat.com
Headers show
Series mptcp: improve MSG_* flags handling | expand

Message

Paolo Abeni April 15, 2021, 4:02 p.m. UTC 
The current handling is a bit fuzzy. Sometimes we silently ignore,
sometimes we bail on unsupported even on no-op ones.

Let's silently provide a provide a reasonable implementation or 
bail (currently only for MSG_FASTOPEN) for the flags with user-visible
side effects. Finally silently ignore the unsupported flags with no
user visible side effects.

Paolo Abeni (3):
  mptcp: implement dummy MSG_ERRQUEUE support
  mptcp: implement MSG_TRUNC support
  mptcp: ignore unsupported msg flags

 net/mptcp/protocol.c | 29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)

Comments

Mat Martineau April 16, 2021, 11:01 p.m. UTC | #1 
On Thu, 15 Apr 2021, Paolo Abeni wrote:

> The current handling is a bit fuzzy. Sometimes we silently ignore,
> sometimes we bail on unsupported even on no-op ones.
>
> Let's silently provide a provide a reasonable implementation or
> bail (currently only for MSG_FASTOPEN) for the flags with user-visible
> side effects. Finally silently ignore the unsupported flags with no
> user visible side effects.
>
> Paolo Abeni (3):
>  mptcp: implement dummy MSG_ERRQUEUE support
>  mptcp: implement MSG_TRUNC support
>  mptcp: ignore unsupported msg flags
>
> net/mptcp/protocol.c | 29 ++++++++++++++++++-----------
> 1 file changed, 18 insertions(+), 11 deletions(-)
>
> -- 
> 2.26.2

Hi Paolo -

Thanks, series looks good to me.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel
Matthieu Baerts April 19, 2021, 4:39 p.m. UTC | #2 
Hi Paolo, Mat,

On 15/04/2021 18:02, Paolo Abeni wrote:
> The current handling is a bit fuzzy. Sometimes we silently ignore,
> sometimes we bail on unsupported even on no-op ones.
> 
> Let's silently provide a provide a reasonable implementation or 
> bail (currently only for MSG_FASTOPEN) for the flags with user-visible
> side effects. Finally silently ignore the unsupported flags with no
> user visible side effects.

Thank you for the patches and the review!

Applied in our tree with Mat's RvB tags, without a spelling mistake and
a switch from ENOTSUPP to EOPNOTSUPP:

- 79f8f01a2fbe: mptcp: implement dummy MSG_ERRQUEUE support



- 5ea72f542f69: mptcp: implement MSG_TRUNC support



- faf109acd959: mptcp: ignore unsupported msg flags



- Results: 8da9d3d6f081..0bc569d1592d

Tests + export are in progress!

Cheers,
Matt