| Message ID | 20210305170045.869437-1-kbastian@mail.uni-paderborn.de |
|---|---|
| Headers | show |
| Series | tests/tcg: Add TriCore tests | expand |
Patchew URL: https://patchew.org/QEMU/20210305170045.869437-1-kbastian@mail.uni-paderborn.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210305170045.869437-1-kbastian@mail.uni-paderborn.de
Subject: [PATCH v3 00/15] tests/tcg: Add TriCore tests
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210302175741.1079851-1-richard.henderson@linaro.org -> patchew/20210302175741.1079851-1-richard.henderson@linaro.org
* [new tag] patchew/20210305170045.869437-1-kbastian@mail.uni-paderborn.de -> patchew/20210305170045.869437-1-kbastian@mail.uni-paderborn.de
Switched to a new branch 'test'
785f2f1 tests/tcg/tricore: Add muls test
6ebe3c1 tests/tcg/tricore: Add msub test
0d35ed5 tests/tcg/tricore: Add madd test
a84017b tests/tcg/tricore: Add ftoi test
4826c78 tests/tcg/tricore: Add fmul test
5b6068a tests/tcg/tricore: Add fadd test
04b0e67 tests/tcg/tricore: Add dvstep test
a25a3b7 tests/tcg/tricore: Add clz test
d936575 tests/tcg/tricore: Add bmerge test
9dec54f tests/tcg/tricore: Add macros to create tests and first test 'abs'
1b6b30f configure: Emit HOST_CC to config-host.mak
b2cb09f tests/tcg/tricore: Add build infrastructure
babfdc2 hw/tricore: Add testdevice for tests in tests/tcg/
cdd7404 tests/tcg: Run timeout cmds using --foreground
b984fc1 tests/tcg: Add docker_as and docker_ld cmds
=== OUTPUT BEGIN ===
1/15 Checking commit b984fc156b90 (tests/tcg: Add docker_as and docker_ld cmds)
2/15 Checking commit cdd740438950 (tests/tcg: Run timeout cmds using --foreground)
3/15 Checking commit babfdc203cf6 (hw/tricore: Add testdevice for tests in tests/tcg/)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#65:
new file mode 100644
total: 0 errors, 1 warnings, 151 lines checked
Patch 3/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/15 Checking commit b2cb09f9515b (tests/tcg/tricore: Add build infrastructure)
5/15 Checking commit 1b6b30f24216 (configure: Emit HOST_CC to config-host.mak)
6/15 Checking commit 9dec54ffbf04 (tests/tcg/tricore: Add macros to create tests and first test 'abs')
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
ERROR: line over 90 characters
#36: FILE: tests/tcg/configure.sh:105:
+ alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64|tricore)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66:
new file mode 100644
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#72: FILE: tests/tcg/tricore/macros.h:2:
+#define LI(reg, val) \
+ mov.u reg, lo:val; \
+ movh DREG_TEMP_LI, up:val; \
+ or reg, reg, DREG_TEMP_LI; \
+
ERROR: spaces required around that ':' (ctx:VxV)
#73: FILE: tests/tcg/tricore/macros.h:3:
+ mov.u reg, lo:val; \
^
ERROR: spaces required around that ':' (ctx:VxV)
#74: FILE: tests/tcg/tricore/macros.h:4:
+ movh DREG_TEMP_LI, up:val; \
^
ERROR: spaces required around that '%' (ctx:WxV)
#80: FILE: tests/tcg/tricore/macros.h:10:
+#define DREG_RS1 %d0
^
ERROR: Macros with complex values should be enclosed in parenthesis
#80: FILE: tests/tcg/tricore/macros.h:10:
+#define DREG_RS1 %d0
ERROR: spaces required around that '%' (ctx:WxV)
#81: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_CALC_RESULT %d1
^
ERROR: Macros with complex values should be enclosed in parenthesis
#81: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_CALC_RESULT %d1
ERROR: spaces required around that '%' (ctx:WxV)
#82: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_TEMP_LI %d10
^
ERROR: Macros with complex values should be enclosed in parenthesis
#82: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_TEMP_LI %d10
ERROR: spaces required around that '%' (ctx:WxV)
#83: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_TEMP %d11
^
ERROR: Macros with complex values should be enclosed in parenthesis
#83: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_TEMP %d11
ERROR: spaces required around that '%' (ctx:WxV)
#84: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_TEST_NUM %d14
^
ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_TEST_NUM %d14
ERROR: spaces required around that '%' (ctx:WxV)
#85: FILE: tests/tcg/tricore/macros.h:15:
+#define DREG_CORRECT_RESULT %d15
^
ERROR: Macros with complex values should be enclosed in parenthesis
#85: FILE: tests/tcg/tricore/macros.h:15:
+#define DREG_CORRECT_RESULT %d15
ERROR: spaces required around that '%' (ctx:WxV)
#87: FILE: tests/tcg/tricore/macros.h:17:
+#define DREG_DEV_ADDR %a15
^
ERROR: Macros with complex values should be enclosed in parenthesis
#87: FILE: tests/tcg/tricore/macros.h:17:
+#define DREG_DEV_ADDR %a15
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#90: FILE: tests/tcg/tricore/macros.h:20:
+#define TEST_CASE(num, testreg, correct, code...) \
+test_ ## num: \
+ code; \
+ LI(DREG_CORRECT_RESULT, correct) \
+ mov DREG_TEST_NUM, num; \
+ jne testreg, DREG_CORRECT_RESULT, fail \
+
ERROR: spaces required around that ':' (ctx:VxE)
#91: FILE: tests/tcg/tricore/macros.h:21:
+test_ ## num: \
^
WARNING: Block comments use a leading /* on a separate line
#97: FILE: tests/tcg/tricore/macros.h:27:
+/* Actual test case type
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#109: FILE: tests/tcg/tricore/macros.h:39:
+#define TEST_PASSFAIL \
+ j pass; \
+fail: \
+ LI(DREG_TEMP, TESTDEV_ADDR) \
+ mov.a DREG_DEV_ADDR, DREG_TEMP; \
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+ debug; \
+ j fail; \
+pass: \
+ LI(DREG_TEMP, TESTDEV_ADDR) \
+ mov.a DREG_DEV_ADDR, DREG_TEMP; \
+ mov DREG_TEST_NUM, 0; \
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+ debug; \
+ j pass;
ERROR: space prohibited before open square bracket '['
#114: FILE: tests/tcg/tricore/macros.h:44:
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
ERROR: space prohibited before open square bracket '['
#121: FILE: tests/tcg/tricore/macros.h:51:
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
total: 23 errors, 2 warnings, 87 lines checked
Patch 6/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/15 Checking commit d93657590bf8 (tests/tcg/tricore: Add bmerge test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
ERROR: spaces required around that '%' (ctx:WxV)
#36: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_RS2 %d1
^
ERROR: Macros with complex values should be enclosed in parenthesis
#36: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_RS2 %d1
ERROR: spaces required around that '%' (ctx:WxV)
#38: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_CALC_PSW %d2
^
ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_CALC_PSW %d2
ERROR: spaces required around that '%' (ctx:WxV)
#39: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_CORRECT_PSW %d3
^
ERROR: Macros with complex values should be enclosed in parenthesis
#39: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_CORRECT_PSW %d3
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tests/tcg/tricore/macros.h:31:
+test_ ## num: \
^
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#79:
new file mode 100644
total: 7 errors, 1 warnings, 58 lines checked
Patch 7/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit a25a3b734c10 (tests/tcg/tricore: Add clz test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 34 lines checked
Patch 8/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 04b0e6738bde (tests/tcg/tricore: Add dvstep test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
ERROR: spaces required around that '%' (ctx:WxV)
#49: FILE: tests/tcg/tricore/macros.h:22:
+#define EREG_RS1 %e6
^
ERROR: Macros with complex values should be enclosed in parenthesis
#49: FILE: tests/tcg/tricore/macros.h:22:
+#define EREG_RS1 %e6
ERROR: spaces required around that '%' (ctx:WxV)
#50: FILE: tests/tcg/tricore/macros.h:23:
+#define EREG_RS1_LO %d6
^
ERROR: Macros with complex values should be enclosed in parenthesis
#50: FILE: tests/tcg/tricore/macros.h:23:
+#define EREG_RS1_LO %d6
ERROR: spaces required around that '%' (ctx:WxV)
#51: FILE: tests/tcg/tricore/macros.h:24:
+#define EREG_RS1_HI %d7
^
ERROR: Macros with complex values should be enclosed in parenthesis
#51: FILE: tests/tcg/tricore/macros.h:24:
+#define EREG_RS1_HI %d7
ERROR: spaces required around that '%' (ctx:WxV)
#52: FILE: tests/tcg/tricore/macros.h:25:
+#define EREG_RS2 %e8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#52: FILE: tests/tcg/tricore/macros.h:25:
+#define EREG_RS2 %e8
ERROR: spaces required around that '%' (ctx:WxV)
#53: FILE: tests/tcg/tricore/macros.h:26:
+#define EREG_RS2_LO %d8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#53: FILE: tests/tcg/tricore/macros.h:26:
+#define EREG_RS2_LO %d8
ERROR: spaces required around that '%' (ctx:WxV)
#54: FILE: tests/tcg/tricore/macros.h:27:
+#define EREG_RS2_HI %d9
^
ERROR: Macros with complex values should be enclosed in parenthesis
#54: FILE: tests/tcg/tricore/macros.h:27:
+#define EREG_RS2_HI %d9
ERROR: spaces required around that '%' (ctx:WxV)
#55: FILE: tests/tcg/tricore/macros.h:28:
+#define EREG_CALC_RESULT %e8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#55: FILE: tests/tcg/tricore/macros.h:28:
+#define EREG_CALC_RESULT %e8
ERROR: spaces required around that '%' (ctx:WxV)
#56: FILE: tests/tcg/tricore/macros.h:29:
+#define EREG_CALC_RESULT_HI %d9
^
ERROR: Macros with complex values should be enclosed in parenthesis
#56: FILE: tests/tcg/tricore/macros.h:29:
+#define EREG_CALC_RESULT_HI %d9
ERROR: spaces required around that '%' (ctx:WxV)
#57: FILE: tests/tcg/tricore/macros.h:30:
+#define EREG_CALC_RESULT_LO %d8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#57: FILE: tests/tcg/tricore/macros.h:30:
+#define EREG_CALC_RESULT_LO %d8
ERROR: spaces required around that '%' (ctx:WxV)
#58: FILE: tests/tcg/tricore/macros.h:31:
+#define EREG_CORRECT_RESULT_LO %d0
^
ERROR: Macros with complex values should be enclosed in parenthesis
#58: FILE: tests/tcg/tricore/macros.h:31:
+#define EREG_CORRECT_RESULT_LO %d0
ERROR: spaces required around that '%' (ctx:WxV)
#59: FILE: tests/tcg/tricore/macros.h:32:
+#define EREG_CORRECT_RESULT_HI %d1
^
ERROR: Macros with complex values should be enclosed in parenthesis
#59: FILE: tests/tcg/tricore/macros.h:32:
+#define EREG_CORRECT_RESULT_HI %d1
ERROR: spaces required around that ':' (ctx:VxE)
#69: FILE: tests/tcg/tricore/macros.h:43:
+test_ ## num: \
^
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#96:
new file mode 100644
total: 23 errors, 1 warnings, 76 lines checked
Patch 9/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 5b6068a01b76 (tests/tcg/tricore: Add fadd test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41:
new file mode 100644
total: 0 errors, 1 warnings, 30 lines checked
Patch 10/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/15 Checking commit 4826c78c990d (tests/tcg/tricore: Add fmul test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41:
new file mode 100644
total: 0 errors, 1 warnings, 22 lines checked
Patch 11/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/15 Checking commit a84017baab90 (tests/tcg/tricore: Add ftoi test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60:
new file mode 100644
total: 0 errors, 1 warnings, 37 lines checked
Patch 12/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 0d35ed524fc2 (tests/tcg/tricore: Add madd test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
ERROR: spaces required around that '%' (ctx:WxV)
#49: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_RS3 %d4
^
ERROR: Macros with complex values should be enclosed in parenthesis
#49: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_RS3 %d4
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78:
new file mode 100644
total: 2 errors, 1 warnings, 55 lines checked
Patch 13/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/15 Checking commit 6ebe3c1d09fb (tests/tcg/tricore: Add msub test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41:
new file mode 100644
total: 0 errors, 1 warnings, 23 lines checked
Patch 14/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/15 Checking commit 785f2f191e37 (tests/tcg/tricore: Add muls test)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41:
new file mode 100644
total: 0 errors, 1 warnings, 23 lines checked
Patch 15/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210305170045.869437-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Fri, Mar 05, 2021 at 06:00:30PM +0100, Bastian Koppelmann wrote: > Hi Alex, > > after a long while and thanks to Thomas reminder, I finally came back to this > series. I addressed most of your comments except for the timeout --foreground > problem (see https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg00921.html). > I just couldn't figure out why QEMU hangs when run from the Makefile. > > You can find the full tree here: > https://github.com/bkoppelmann/qemu/tree/tricore-tcg-tests2 > > Cheers, > Bastian ping? Cheers, Bastian
Bastian Koppelmann <kbastian@mail.uni-paderborn.de> writes: > On Fri, Mar 05, 2021 at 06:00:30PM +0100, Bastian Koppelmann wrote: >> Hi Alex, >> >> after a long while and thanks to Thomas reminder, I finally came back to this >> series. I addressed most of your comments except for the timeout --foreground >> problem (see https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg00921.html). >> I just couldn't figure out why QEMU hangs when run from the Makefile. >> >> You can find the full tree here: >> https://github.com/bkoppelmann/qemu/tree/tricore-tcg-tests2 >> >> Cheers, >> Bastian > > ping? Sorry it dropped off my radar, added to the TODO list.
Bastian Koppelmann <kbastian@mail.uni-paderborn.de> writes: > Hi Alex, > > after a long while and thanks to Thomas reminder, I finally came back to this > series. I addressed most of your comments except for the timeout --foreground > problem (see https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg00921.html). > I just couldn't figure out why QEMU hangs when run from the Makefile. As I'm refactoring configure.sh anyway I have pulled the series and made the suggested changes myself. Queued to testing/next, thanks. > > You can find the full tree here: > https://github.com/bkoppelmann/qemu/tree/tricore-tcg-tests2 > > Cheers, > Bastian > > Bastian Koppelmann (15): > tests/tcg: Add docker_as and docker_ld cmds > tests/tcg: Run timeout cmds using --foreground > hw/tricore: Add testdevice for tests in tests/tcg/ > tests/tcg/tricore: Add build infrastructure > configure: Emit HOST_CC to config-host.mak > tests/tcg/tricore: Add macros to create tests and first test 'abs' > tests/tcg/tricore: Add bmerge test > tests/tcg/tricore: Add clz test > tests/tcg/tricore: Add dvstep test > tests/tcg/tricore: Add fadd test > tests/tcg/tricore: Add fmul test > tests/tcg/tricore: Add ftoi test > tests/tcg/tricore: Add madd test > tests/tcg/tricore: Add msub test > tests/tcg/tricore: Add muls test > > MAINTAINERS | 1 + > configure | 1 + > hw/tricore/meson.build | 1 + > hw/tricore/tricore_testboard.c | 8 ++ > hw/tricore/tricore_testdevice.c | 82 +++++++++++ > include/hw/tricore/tricore_testdevice.h | 38 ++++++ > tests/tcg/Makefile.qemu | 15 ++ > tests/tcg/Makefile.target | 5 +- > tests/tcg/configure.sh | 27 +++- > tests/tcg/tricore/Makefile.softmmu-target | 26 ++++ > .../tcg/tricore/Makefile.softmmu-target.orig | 25 ++++ > tests/tcg/tricore/link.ld | 60 ++++++++ > tests/tcg/tricore/macros.h | 129 ++++++++++++++++++ > tests/tcg/tricore/test_abs.S | 7 + > tests/tcg/tricore/test_bmerge.S | 8 ++ > tests/tcg/tricore/test_clz.S | 9 ++ > tests/tcg/tricore/test_dvstep.S | 15 ++ > tests/tcg/tricore/test_fadd.S | 16 +++ > tests/tcg/tricore/test_fmul.S | 8 ++ > tests/tcg/tricore/test_ftoi.S | 10 ++ > tests/tcg/tricore/test_madd.S | 11 ++ > tests/tcg/tricore/test_msub.S | 9 ++ > tests/tcg/tricore/test_muls.S | 9 ++ > 23 files changed, 517 insertions(+), 3 deletions(-) > create mode 100644 hw/tricore/tricore_testdevice.c > create mode 100644 include/hw/tricore/tricore_testdevice.h > create mode 100644 tests/tcg/tricore/Makefile.softmmu-target > create mode 100644 tests/tcg/tricore/Makefile.softmmu-target.orig > create mode 100644 tests/tcg/tricore/link.ld > create mode 100644 tests/tcg/tricore/macros.h > create mode 100644 tests/tcg/tricore/test_abs.S > create mode 100644 tests/tcg/tricore/test_bmerge.S > create mode 100644 tests/tcg/tricore/test_clz.S > create mode 100644 tests/tcg/tricore/test_dvstep.S > create mode 100644 tests/tcg/tricore/test_fadd.S > create mode 100644 tests/tcg/tricore/test_fmul.S > create mode 100644 tests/tcg/tricore/test_ftoi.S > create mode 100644 tests/tcg/tricore/test_madd.S > create mode 100644 tests/tcg/tricore/test_msub.S > create mode 100644 tests/tcg/tricore/test_muls.S