mbox series

[SRU,OEM-5.10,0/1] alsa/realtek: extend the delay time in the determine_headset_type for a Dell AIO

Message ID 20210322115249.3362-1-hui.wang@canonical.com
Headers show
Series alsa/realtek: extend the delay time in the determine_headset_type for a Dell AIO | expand

Message

Hui Wang March 22, 2021, 11:52 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1920747

Dell waited for the fix for a long time, today the fix is accepted by
upstream, I sent it to oem-5.10 kernel, and this patch is CCed to
stable, other ubuntu kernels will merge this fix with stable update.

[Impact]
Users plug a headset to this AIO and select headset-mic from UI, but
can't record any sound from the headset-mic.

[Fix]
The root cause is the driver return a wrong type of the headset, need
to add more delay in the determine_headset_type(), so backport that
patch to ubuntu kernel.

[Test]
Booting the system with patched kernel, plug headset and select
headset-mic from UI, could record sound from headset-mic, we tested
more than 10 times, all worked well.


[Where problems could occur]
This could make the user experience a small delay from pop-up dialogue
when plugging a headset, but the delay is less than 1s and the delay
is not much longer than other codecs, QA think it is acceptable.


Hui Wang (1):
  UBUNTU: SAUCE: ALSA: hda/realtek: fix a determine_headset_type issue
    for a Dell AIO

 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner March 22, 2021, 11:56 a.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 3/22/21 5:52 AM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920747
> 
> Dell waited for the fix for a long time, today the fix is accepted by
> upstream, I sent it to oem-5.10 kernel, and this patch is CCed to
> stable, other ubuntu kernels will merge this fix with stable update.
> 
> [Impact]
> Users plug a headset to this AIO and select headset-mic from UI, but
> can't record any sound from the headset-mic.
> 
> [Fix]
> The root cause is the driver return a wrong type of the headset, need
> to add more delay in the determine_headset_type(), so backport that
> patch to ubuntu kernel.
> 
> [Test]
> Booting the system with patched kernel, plug headset and select
> headset-mic from UI, could record sound from headset-mic, we tested
> more than 10 times, all worked well.
> 
> 
> [Where problems could occur]
> This could make the user experience a small delay from pop-up dialogue
> when plugging a headset, but the delay is less than 1s and the delay
> is not much longer than other codecs, QA think it is acceptable.
> 
> 
> Hui Wang (1):
>    UBUNTU: SAUCE: ALSA: hda/realtek: fix a determine_headset_type issue
>      for a Dell AIO
> 
>   sound/pci/hda/patch_realtek.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Timo Aaltonen March 23, 2021, 5:04 p.m. UTC | #2
On 22.3.2021 13.52, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920747
> 
> Dell waited for the fix for a long time, today the fix is accepted by
> upstream, I sent it to oem-5.10 kernel, and this patch is CCed to
> stable, other ubuntu kernels will merge this fix with stable update.
> 
> [Impact]
> Users plug a headset to this AIO and select headset-mic from UI, but
> can't record any sound from the headset-mic.
> 
> [Fix]
> The root cause is the driver return a wrong type of the headset, need
> to add more delay in the determine_headset_type(), so backport that
> patch to ubuntu kernel.
> 
> [Test]
> Booting the system with patched kernel, plug headset and select
> headset-mic from UI, could record sound from headset-mic, we tested
> more than 10 times, all worked well.
> 
> 
> [Where problems could occur]
> This could make the user experience a small delay from pop-up dialogue
> when plugging a headset, but the delay is less than 1s and the delay
> is not much longer than other codecs, QA think it is acceptable.
> 
> 
> Hui Wang (1):
>    UBUNTU: SAUCE: ALSA: hda/realtek: fix a determine_headset_type issue
>      for a Dell AIO
> 
>   sound/pci/hda/patch_realtek.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied to oem-5.10, thanks
Paolo Pisati March 29, 2021, 10:19 a.m. UTC | #3
On Mon, Mar 22, 2021 at 07:52:48PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920747
Andrea Righi March 29, 2021, 11:26 a.m. UTC | #4
Applied to hirsute/5.11.

Thanks,
-Andrea

On Mon, Mar 22, 2021 at 07:52:48PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920747
> 
> Dell waited for the fix for a long time, today the fix is accepted by
> upstream, I sent it to oem-5.10 kernel, and this patch is CCed to
> stable, other ubuntu kernels will merge this fix with stable update.
> 
> [Impact]
> Users plug a headset to this AIO and select headset-mic from UI, but
> can't record any sound from the headset-mic.
> 
> [Fix]
> The root cause is the driver return a wrong type of the headset, need
> to add more delay in the determine_headset_type(), so backport that
> patch to ubuntu kernel.
> 
> [Test]
> Booting the system with patched kernel, plug headset and select
> headset-mic from UI, could record sound from headset-mic, we tested
> more than 10 times, all worked well.
> 
> 
> [Where problems could occur]
> This could make the user experience a small delay from pop-up dialogue
> when plugging a headset, but the delay is less than 1s and the delay
> is not much longer than other codecs, QA think it is acceptable.
> 
> 
> Hui Wang (1):
>   UBUNTU: SAUCE: ALSA: hda/realtek: fix a determine_headset_type issue
>     for a Dell AIO
> 
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team