| Message ID | 20201207134556.25217-3-uwe@kleine-koenig.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: get rid of pwmchip_add_with_polarity() | expand |
On Mon, Dec 07, 2020 at 02:45:55PM +0100, Uwe Kleine-König wrote: > The only side effect of this change is that pwm->state.polarity is > initialized to PWM_POLARITY_NORMAL instead of PWM_POLARITY_INVERSED. > However all other members of pwm->state are uninitialized and consumers > are expected to provide the right polarity (either by setting it explicitly > or by using a helper like pwm_init_state() that overwrites .polarity > anyhow with a value independent of the initial value). > > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> > --- > drivers/pwm/pwm-atmel-hlcdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thierry
diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c index dcbc0489dfd4..4551aa2c484c 100644 --- a/drivers/pwm/pwm-atmel-hlcdc.c +++ b/drivers/pwm/pwm-atmel-hlcdc.c @@ -270,7 +270,7 @@ static int atmel_hlcdc_pwm_probe(struct platform_device *pdev) chip->chip.of_xlate = of_pwm_xlate_with_flags; chip->chip.of_pwm_n_cells = 3; - ret = pwmchip_add_with_polarity(&chip->chip, PWM_POLARITY_INVERSED); + ret = pwmchip_add(&chip->chip); if (ret) { clk_disable_unprepare(hlcdc->periph_clk); return ret;
The only side effect of this change is that pwm->state.polarity is initialized to PWM_POLARITY_NORMAL instead of PWM_POLARITY_INVERSED. However all other members of pwm->state are uninitialized and consumers are expected to provide the right polarity (either by setting it explicitly or by using a helper like pwm_init_state() that overwrites .polarity anyhow with a value independent of the initial value). Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> --- drivers/pwm/pwm-atmel-hlcdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)