diff mbox series

version: remove /proc/acpi/info

Message ID 20210213010820.277666-1-alex.hung@canonical.com
State Accepted
Headers show
Series version: remove /proc/acpi/info | expand

Commit Message

Alex Hung Feb. 13, 2021, 1:08 a.m. UTC
This interface has been deprecated for long time

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/kernel/version/version.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Colin Ian King Feb. 13, 2021, 10:18 a.m. UTC | #1
On 13/02/2021 01:08, Alex Hung wrote:
> This interface has been deprecated for long time

Yes, it got removed in 2.6.36 back in 2010.

> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/kernel/version/version.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/kernel/version/version.c b/src/kernel/version/version.c
> index c473b3c1..8c5a88bb 100644
> --- a/src/kernel/version/version.c
> +++ b/src/kernel/version/version.c
> @@ -89,8 +89,7 @@ static int version_test4(fwts_framework *fw)
>  {
>  	char *str;
>  
> -	if (((str = fwts_get("/sys/module/acpi/parameters/acpica_version")) == NULL) &&
> -	    ((str = fwts_get("/proc/acpi/info")) == NULL))
> +	if ((str = fwts_get("/sys/module/acpi/parameters/acpica_version")) == NULL)
>  		fwts_log_info(fw,
>  			"Cannot get ACPI version info from "
>  			"/sys/module/acpi/parameters/acpica_version "
> 

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu Feb. 22, 2021, 4:05 a.m. UTC | #2
On 2/13/21 9:08 AM, Alex Hung wrote:
> This interface has been deprecated for long time
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/kernel/version/version.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/kernel/version/version.c b/src/kernel/version/version.c
> index c473b3c1..8c5a88bb 100644
> --- a/src/kernel/version/version.c
> +++ b/src/kernel/version/version.c
> @@ -89,8 +89,7 @@ static int version_test4(fwts_framework *fw)
>  {
>  	char *str;
>  
> -	if (((str = fwts_get("/sys/module/acpi/parameters/acpica_version")) == NULL) &&
> -	    ((str = fwts_get("/proc/acpi/info")) == NULL))
> +	if ((str = fwts_get("/sys/module/acpi/parameters/acpica_version")) == NULL)
>  		fwts_log_info(fw,
>  			"Cannot get ACPI version info from "
>  			"/sys/module/acpi/parameters/acpica_version "
> 


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/kernel/version/version.c b/src/kernel/version/version.c
index c473b3c1..8c5a88bb 100644
--- a/src/kernel/version/version.c
+++ b/src/kernel/version/version.c
@@ -89,8 +89,7 @@  static int version_test4(fwts_framework *fw)
 {
 	char *str;
 
-	if (((str = fwts_get("/sys/module/acpi/parameters/acpica_version")) == NULL) &&
-	    ((str = fwts_get("/proc/acpi/info")) == NULL))
+	if ((str = fwts_get("/sys/module/acpi/parameters/acpica_version")) == NULL)
 		fwts_log_info(fw,
 			"Cannot get ACPI version info from "
 			"/sys/module/acpi/parameters/acpica_version "